From 3758a07c450bbb5ac21c9bb29466c72c7f7b3485 Mon Sep 17 00:00:00 2001 From: david Date: Wed, 4 Feb 2026 09:34:21 +0100 Subject: [PATCH] Cambio de nombre de las variables de entorno que representan los nombres de los secretos --- .env.example | 4 ++-- docs/development-secrets.md | 4 ++-- pyproject.toml | 2 +- .../application/settings/app_settings_loader.py | 4 ++-- .../infrastructure/factories/pdf_signer_factory.py | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.env.example b/.env.example index 66ccf16..8bf86ae 100644 --- a/.env.example +++ b/.env.example @@ -36,5 +36,5 @@ GCP_PROJECT_ID= # -------------------- # PDF signing # -------------------- -PDF_CERT_SECRET_NAME=pdf_cert_pfx_b64 -PDF_CERT_PASSWORD_SECRET_NAME=pdf_cert_password \ No newline at end of file +CERT_SECRET_NAME=certificate_secret_name +CERT_PASSWORD_SECRET_NAME=certificate_password_secret_name \ No newline at end of file diff --git a/docs/development-secrets.md b/docs/development-secrets.md index ff39fc8..821911f 100644 --- a/docs/development-secrets.md +++ b/docs/development-secrets.md @@ -128,8 +128,8 @@ INFISICAL_PROJECT_ID=your_project_id INFISICAL_ENV_SLUG=development INFISICAL_TOKEN_AUTH=your_dev_token_auth -PDF_CERT_PFX_SECRET_NAME=PDF_CERT_PFX_B64 -PDF_CERT_PASSWORD_SECRET_NAME=PDF_CERT_PASSWORD +CERT_SECRET_NAME=certificate_secret_name +CERT_PASSWORD_SECRET_NAME=certificate_password_secret_name ``` ***📌 El archivo .env NO debe commitearse.*** diff --git a/pyproject.toml b/pyproject.toml index 5e39b9b..de517fc 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta" [project] name = "factuges-document-signing-service" -version = "0.2.4" +version = "0.2.7" description = "FastAPI service for signing PDF documents using external secret managers" requires-python = ">=3.11" diff --git a/src/signing_service/application/settings/app_settings_loader.py b/src/signing_service/application/settings/app_settings_loader.py index c23439e..0bfad1f 100644 --- a/src/signing_service/application/settings/app_settings_loader.py +++ b/src/signing_service/application/settings/app_settings_loader.py @@ -110,12 +110,12 @@ def load_app_settings() -> AppSettings: # PDF signing # -------------------- pdf_cert_secret_name = get_env( - "PDF_CERT_SECRET_NAME", + "CERT_SECRET_NAME", required=True, ) pdf_cert_password_secret_name = get_env( - "PDF_CERT_PASSWORD_SECRET_NAME", + "CERT_PASSWORD_SECRET_NAME", required=True, ) diff --git a/src/signing_service/infrastructure/factories/pdf_signer_factory.py b/src/signing_service/infrastructure/factories/pdf_signer_factory.py index 0653ff7..d564fc2 100644 --- a/src/signing_service/infrastructure/factories/pdf_signer_factory.py +++ b/src/signing_service/infrastructure/factories/pdf_signer_factory.py @@ -14,6 +14,6 @@ def create_pdf_signer() -> PDFSignerPort: ) if not settings.pdf_cert_password_secret_name: - raise ValueError("PDF_CERT_PASSWORD_SECRET_NAME is required") + raise ValueError("CERT_PASSWORD_SECRET_NAME is required") return PyHankoPDFSigner()