- Implemented a new test suite in `visual-audit-ui.test.py` to perform visual audits on the UI. - Tests include checking row contrast, wizard geometry, focus behavior, and review headers across different screen sizes. - Utilizes Playwright for browser automation and captures visual snapshots for comparison. - Ensures that the tests run against a synthetic session state for accurate results.
135 lines
4.1 KiB
TypeScript
135 lines
4.1 KiB
TypeScript
import { Button } from "@repo/shadcn-ui/components/button";
|
|
import {
|
|
Dialog,
|
|
DialogClose,
|
|
DialogContent,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
} from "@repo/shadcn-ui/components/dialog";
|
|
import type { ComponentProps, ReactNode } from "react";
|
|
import { createContext, useContext, useRef } from "react";
|
|
|
|
type FormDialogLayout = "content" | "stable" | "picker";
|
|
|
|
const FormLayoutContext = createContext<FormDialogLayout>("content");
|
|
|
|
const FormCancelContext = createContext<string | undefined>(undefined);
|
|
|
|
export function FormDialog({
|
|
open,
|
|
onOpenChange,
|
|
title,
|
|
cancelLabel,
|
|
children,
|
|
wide = false,
|
|
size,
|
|
formActions = false,
|
|
layout = "content",
|
|
finalFocus,
|
|
}: {
|
|
open: boolean;
|
|
onOpenChange: (open: boolean) => void;
|
|
title: ReactNode;
|
|
cancelLabel: string;
|
|
children: ReactNode;
|
|
wide?: boolean;
|
|
size?: "small" | "medium" | "large";
|
|
formActions?: boolean;
|
|
layout?: FormDialogLayout;
|
|
finalFocus?: ComponentProps<typeof DialogContent>["finalFocus"];
|
|
}) {
|
|
const popupRef = useRef<HTMLDivElement>(null);
|
|
const width = size ?? (wide ? "large" : "small");
|
|
const widths = {
|
|
small: "sm:max-w-xl",
|
|
medium: "sm:max-w-3xl",
|
|
large: "sm:w-[90vw] sm:max-w-[1200px]",
|
|
};
|
|
|
|
// La altura de los diálogos dinámicos depende de la ventana, nunca de sus resultados o pasos.
|
|
const height = layout === "content" ? "" : "h-[calc(100dvh-2rem)] sm:h-[min(85dvh,900px)]";
|
|
|
|
return (
|
|
<Dialog onOpenChange={onOpenChange} open={open}>
|
|
<DialogContent
|
|
className={`flex max-h-[calc(100dvh-2rem)] flex-col gap-0 overflow-hidden p-0 ${widths[width]} ${height}`}
|
|
finalFocus={finalFocus}
|
|
initialFocus={
|
|
layout === "picker"
|
|
? () =>
|
|
popupRef.current?.querySelector<HTMLInputElement>("input[data-quick-search]") ??
|
|
true
|
|
: undefined
|
|
}
|
|
ref={popupRef}
|
|
showCloseButton={true}
|
|
>
|
|
<DialogHeader className="shrink-0 border-b px-6 py-5 pr-14">
|
|
<DialogTitle className="text-lg font-bold">{title}</DialogTitle>
|
|
</DialogHeader>
|
|
<div
|
|
className="@container flex min-h-0 flex-1 flex-col overflow-y-auto px-6 pt-5 pb-5 [&:has([data-slot=form-body])]:overflow-hidden [&:has([data-slot=form-body])]:pb-0"
|
|
data-slot="form-dialog-content"
|
|
>
|
|
<FormCancelContext.Provider value={formActions ? cancelLabel : undefined}>
|
|
<FormLayoutContext.Provider value={layout}>{children}</FormLayoutContext.Provider>
|
|
</FormCancelContext.Provider>
|
|
</div>
|
|
{!formActions && (
|
|
<DialogFooter className="shrink-0 border-t px-6 py-4">
|
|
<DialogClose render={<Button type="button" variant="outline" />}>
|
|
{cancelLabel}
|
|
</DialogClose>
|
|
</DialogFooter>
|
|
)}
|
|
</DialogContent>
|
|
</Dialog>
|
|
);
|
|
}
|
|
|
|
export function FormActions({
|
|
children,
|
|
leadingActions,
|
|
cancelDisabled = false,
|
|
}: {
|
|
children: ReactNode;
|
|
leadingActions?: ReactNode;
|
|
cancelDisabled?: boolean;
|
|
}) {
|
|
const cancelLabel = useContext(FormCancelContext);
|
|
|
|
return (
|
|
<DialogFooter className="shrink-0 border-t bg-popover py-4">
|
|
{leadingActions && <div className="flex sm:mr-auto">{leadingActions}</div>}
|
|
{cancelLabel && (
|
|
<DialogClose render={<Button disabled={cancelDisabled} type="button" variant="outline" />}>
|
|
{cancelLabel}
|
|
</DialogClose>
|
|
)}
|
|
{children}
|
|
</DialogFooter>
|
|
);
|
|
}
|
|
|
|
/** El cuerpo reserva espacio simétrico para que el scroll no recorte el anillo de foco. */
|
|
export function FormBody({
|
|
children,
|
|
contentLayout = "stack",
|
|
}: {
|
|
children: ReactNode;
|
|
contentLayout?: "stack" | "fill";
|
|
}) {
|
|
const layout = useContext(FormLayoutContext);
|
|
const fills = layout === "picker" || contentLayout === "fill";
|
|
|
|
return (
|
|
<div
|
|
className={`@container min-h-0 flex-1 overflow-y-auto px-1 pt-1 pb-5 ${fills ? "flex flex-col [&>*]:shrink-0" : "space-y-5"} ${layout === "picker" ? "gap-3" : fills ? "gap-5" : ""} ${layout === "content" ? "" : "[scrollbar-gutter:stable]"}`}
|
|
data-slot="form-body"
|
|
>
|
|
{children}
|
|
</div>
|
|
);
|
|
}
|