From 2202dfd9f0fdc45da481b618249919ccc393be8d Mon Sep 17 00:00:00 2001 From: david Date: Sat, 4 Apr 2026 20:39:53 +0200 Subject: [PATCH] =?UTF-8?q?Customers=20->=20peque=C3=B1os=20arreglos?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../src/common/dto/request/create-customer.request.dto.ts | 2 +- .../src/common/dto/request/customer-list.request.dto.ts | 2 +- .../common/dto/request/update-customer-by-id.request.dto.ts | 2 +- .../src/web/create/utils/build-customer-create-params.ts | 2 +- .../src/web/shared/api/delete-customer-by-id.api.ts | 2 ++ .../customers/src/web/shared/api/get-customer-by-id.api.ts | 5 ++++- 6 files changed, 10 insertions(+), 5 deletions(-) diff --git a/modules/customers/src/common/dto/request/create-customer.request.dto.ts b/modules/customers/src/common/dto/request/create-customer.request.dto.ts index 027199f0..bd3cbdf9 100644 --- a/modules/customers/src/common/dto/request/create-customer.request.dto.ts +++ b/modules/customers/src/common/dto/request/create-customer.request.dto.ts @@ -8,7 +8,7 @@ export const CreateCustomerRequestSchema = z.object({ name: z.string(), trade_name: z.string().optional(), tin: z.string().optional(), - default_taxes: z.array(z.string()).default([]), + default_taxes: z.string().default(""), street: z.string().optional(), street2: z.string().optional(), diff --git a/modules/customers/src/common/dto/request/customer-list.request.dto.ts b/modules/customers/src/common/dto/request/customer-list.request.dto.ts index c1385d1d..87854a4a 100644 --- a/modules/customers/src/common/dto/request/customer-list.request.dto.ts +++ b/modules/customers/src/common/dto/request/customer-list.request.dto.ts @@ -1,5 +1,5 @@ import { CriteriaSchema } from "@erp/core"; -import { z } from "zod/v4"; +import type { z } from "zod/v4"; export const CustomerListRequestSchema = CriteriaSchema; export type CustomerListRequestDTO = z.infer; diff --git a/modules/customers/src/common/dto/request/update-customer-by-id.request.dto.ts b/modules/customers/src/common/dto/request/update-customer-by-id.request.dto.ts index 19ff1867..ba86ac38 100644 --- a/modules/customers/src/common/dto/request/update-customer-by-id.request.dto.ts +++ b/modules/customers/src/common/dto/request/update-customer-by-id.request.dto.ts @@ -11,7 +11,7 @@ export const UpdateCustomerByIdRequestSchema = z.object({ name: z.string().optional(), trade_name: z.string().optional(), tin: z.string().optional(), - default_taxes: z.array(z.string()).optional(), // completo (sustituye), o null => vaciar + default_taxes: z.string().optional(), // completo (sustituye), o null => vaciar street: z.string().optional(), street2: z.string().optional(), diff --git a/modules/customers/src/web/create/utils/build-customer-create-params.ts b/modules/customers/src/web/create/utils/build-customer-create-params.ts index 2a3a6a9d..6871812c 100644 --- a/modules/customers/src/web/create/utils/build-customer-create-params.ts +++ b/modules/customers/src/web/create/utils/build-customer-create-params.ts @@ -34,7 +34,7 @@ export const buildCreateCustomerParams = (formData: CustomerCreateForm): CreateC name: formData.name, trade_name: formData.tradeName, tin: formData.tin, - default_taxes: formData.defaultTaxes, + default_taxes: formData.defaultTaxes.join(";"), street: formData.street, street2: formData.street2, diff --git a/modules/customers/src/web/shared/api/delete-customer-by-id.api.ts b/modules/customers/src/web/shared/api/delete-customer-by-id.api.ts index 9a69c971..032bd4a0 100644 --- a/modules/customers/src/web/shared/api/delete-customer-by-id.api.ts +++ b/modules/customers/src/web/shared/api/delete-customer-by-id.api.ts @@ -21,7 +21,9 @@ export function deleteCustomerById( params: DeleteCustomerByIdParams ): Promise { const { id, signal } = params; + if (!id) throw new Error("customerId is required"); + return dataSource.deleteOne("customers", id, { signal, }); diff --git a/modules/customers/src/web/shared/api/get-customer-by-id.api.ts b/modules/customers/src/web/shared/api/get-customer-by-id.api.ts index ab05869b..c9ffb55a 100644 --- a/modules/customers/src/web/shared/api/get-customer-by-id.api.ts +++ b/modules/customers/src/web/shared/api/get-customer-by-id.api.ts @@ -18,7 +18,10 @@ export interface GetCustomerByIdParams { export type GetCustomerByIdResult = GetCustomerByIdResponseDTO; -export function getCustomerById(dataSource: IDataSource, params: GetCustomerByIdParams) { +export function getCustomerById( + dataSource: IDataSource, + params: GetCustomerByIdParams +): Promise { const { id, signal } = params; if (!id) throw new Error("customerId is required"); return dataSource.getOne("customers", id, { signal });