Facturas de cliente

This commit is contained in:
David Arranz 2025-11-12 15:48:57 +01:00
parent 75a0294cb1
commit 5f08cfaa15
30 changed files with 512 additions and 157 deletions

View File

@ -1,5 +1,5 @@
import { IPresenterRegistry } from "./presenter-registry.interface";
import { IPresenter, IPresenterOutputParams } from "./presenter.interface";
import type { IPresenter, IPresenterOutputParams } from "./presenter.interface";
import type { IPresenterRegistry } from "./presenter-registry.interface";
export abstract class Presenter<TSource = unknown, TOutput = unknown>
implements IPresenter<TSource, TOutput>

View File

@ -1,8 +1,9 @@
// --- Adaptador que carga el catálogo JSON en memoria e indexa por code ---
import { Maybe } from "@repo/rdx-utils";
import { TaxCatalogProvider } from "./tax-catalog.provider";
import { TaxCatalogType, TaxItemType, TaxLookupItems } from "./tax-catalog-types";
import type { TaxCatalogProvider } from "./tax-catalog.provider";
import type { TaxCatalogType, TaxItemType, TaxLookupItems } from "./tax-catalog-types";
export class JsonTaxCatalogProvider implements TaxCatalogProvider {
// Índice por código normalizado

View File

@ -1,7 +1,6 @@
// --- Puerto (interfaz) para resolver tasas desde un catálogo ---
import type { Maybe } from "@repo/rdx-utils"; // Usa tu implementación real de Maybe
import { Maybe } from "@repo/rdx-utils"; // Usa tu implementación real de Maybe
import { TaxCatalogType, TaxItemType, TaxLookupItems } from "./tax-catalog-types";
import type { TaxCatalogType, TaxItemType, TaxLookupItems } from "./tax-catalog-types";
export interface TaxCatalogProvider {
/**

View File

@ -3,11 +3,14 @@ import type { UniqueID } from "@repo/rdx-ddd";
import { type Collection, Maybe, Result } from "@repo/rdx-utils";
import type { Transaction } from "sequelize";
import type {
CustomerInvoiceNumber,
CustomerInvoiceSerie,
CustomerInvoiceStatus,
ICustomerInvoiceNumberGenerator,
import {
CustomerInvoiceIsProformaSpecification,
type CustomerInvoiceNumber,
type CustomerInvoiceSerie,
type CustomerInvoiceStatus,
type ICustomerInvoiceNumberGenerator,
ProformaCannotBeDeletedError,
StatusInvoiceIsDraftSpecification,
} from "../../domain";
import {
CustomerInvoice,
@ -69,6 +72,27 @@ export class CustomerInvoiceApplicationService {
return CustomerInvoice.create({ ...props, companyId }, proformaId);
}
/**
* Guarda una nueva factura y devuelve la factura guardada.
*
* @param companyId - Identificador de la empresa a la que pertenece la factura.
* @param proforma - La factura a guardar.
* @param transaction - Transacción activa para la operación.
* @returns Result<CustomerInvoice, Error> - La factura guardada o un error si falla la operación.
*/
async createIssueInvoiceInCompany(
companyId: UniqueID,
invoice: CustomerInvoice,
transaction: Transaction
): Promise<Result<CustomerInvoice, Error>> {
const result = await this.repository.create(invoice, transaction);
if (result.isFailure) {
return Result.fail(result.error);
}
return this.getIssueInvoiceByIdInCompany(companyId, invoice.id, transaction);
}
/**
* Guarda una nueva proforma y devuelve la proforma guardada.
*
@ -77,7 +101,7 @@ export class CustomerInvoiceApplicationService {
* @param transaction - Transacción activa para la operación.
* @returns Result<CustomerInvoice, Error> - La proforma guardada o un error si falla la operación.
*/
async createInvoiceInCompany(
async createProformaInCompany(
companyId: UniqueID,
proforma: CustomerInvoice,
transaction: Transaction
@ -113,7 +137,27 @@ export class CustomerInvoiceApplicationService {
/**
*
* Comprueba si existe o no en persistencia una factura con el ID proporcionado
* Comprueba si existe o no en persistencia una proforma con el ID proporcionado
*
* @param companyId - Identificador de la empresa a la que pertenece la factura.
* @param proformaId - Identificador UUID de la factura.
* @param transaction - Transacción activa para la operación.
* @returns Result<Boolean, Error> - Existe la factura o no.
*/
async existsProformaByIdInCompany(
companyId: UniqueID,
proformaId: UniqueID,
transaction?: Transaction
): Promise<Result<boolean, Error>> {
return this.repository.existsByIdInCompany(companyId, proformaId, transaction, {
is_proforma: true,
});
}
/**
*
* Comprueba si existe o no en persistencia una proforma con el ID proporcionado
*
* @param companyId - Identificador de la empresa a la que pertenece la factura.
* @param invoiceId - Identificador UUID de la factura.
@ -121,12 +165,14 @@ export class CustomerInvoiceApplicationService {
* @returns Result<Boolean, Error> - Existe la factura o no.
*/
async existsByIdInCompany(
async existsIssueInvoiceByIdInCompany(
companyId: UniqueID,
invoiceId: UniqueID,
transaction?: Transaction
): Promise<Result<boolean, Error>> {
return this.repository.existsByIdInCompany(companyId, invoiceId, transaction);
return this.repository.existsByIdInCompany(companyId, invoiceId, transaction, {
is_proforma: false,
});
}
/**
@ -199,13 +245,13 @@ export class CustomerInvoiceApplicationService {
changes: CustomerInvoicePatchProps,
transaction?: Transaction
): Promise<Result<CustomerInvoice, Error>> {
const invoiceResult = await this.getProformaByIdInCompany(companyId, proformaId, transaction);
const proformaResult = await this.getProformaByIdInCompany(companyId, proformaId, transaction);
if (invoiceResult.isFailure) {
return Result.fail(invoiceResult.error);
if (proformaResult.isFailure) {
return Result.fail(proformaResult.error);
}
const updated = invoiceResult.data.update(changes);
const updated = proformaResult.data.update(changes);
if (updated.isFailure) {
return Result.fail(updated.error);
@ -215,27 +261,48 @@ export class CustomerInvoiceApplicationService {
}
/**
* Elimina (o marca como eliminada) una factura según su ID.
* Elimina (o marca como eliminada) una proforma según su ID.
*
* @param companyId - Identificador de la empresa a la que pertenece la factura.
* @param invoiceId - Identificador UUID de la factura.
* @param companyId - Identificador de la empresa a la que pertenece la proforma.
* @param proformaId - Identificador UUID de la proforma.
* @param transaction - Transacción activa para la operación.
* @returns Result<boolean, Error> - Resultado de la operación.
*/
async deleteInvoiceByIdInCompany(
async deleteProformaByIdInCompany(
companyId: UniqueID,
invoiceId: UniqueID,
proformaId: UniqueID,
transaction?: Transaction
): Promise<Result<boolean, Error>> {
return this.repository.deleteByIdInCompany(companyId, invoiceId, transaction);
// 1) Buscar la proforma
const proformaResult = await this.getProformaByIdInCompany(companyId, proformaId, transaction);
if (proformaResult.isFailure) return Result.fail(proformaResult.error);
const proforma = proformaResult.data;
// 2) Validar: es proforma
const isProforma = new CustomerInvoiceIsProformaSpecification();
if (!(await isProforma.isSatisfiedBy(proforma))) {
return Result.fail(new ProformaCannotBeDeletedError(proformaId.toString(), "not a proforma"));
}
// 3) Validar: estado draft
const isDraft = new StatusInvoiceIsDraftSpecification();
if (!(await isDraft.isSatisfiedBy(proforma))) {
return Result.fail(
new ProformaCannotBeDeletedError(proformaId.toString(), "status is not 'draft'")
);
}
// 4) Borrar la proforma (baja lógica)
return this.repository.deleteProformaByIdInCompany(companyId, proformaId, transaction);
}
/**
*
* Actualiza el "status" de una proforma
*
* @param companyId - Identificador UUID de la empresa a la que pertenece el cliente.
* @param proformaId - UUID de la factura a eliminar.
* @param companyId - Identificador UUID de la empresa a la que pertenece la proforma.
* @param proformaId - UUID de la proforma a actualizar.
* @param newStatus - nuevo estado
* @param transaction - Transacción activa para la operación.
* @returns Result<boolean, Error>

View File

@ -37,7 +37,7 @@ export class ChangeStatusProformaUseCase {
return this.transactionManager.complete(async (transaction) => {
try {
/** 1. Recuperamos la proforma */
const proformaResult = await this.service.getInvoiceByIdInCompany(
const proformaResult = await this.service.getProformaByIdInCompany(
companyId,
proformaId,
transaction

View File

@ -1,4 +1,4 @@
import { EntityNotFoundError, type ITransactionManager } from "@erp/core/api";
import type { ITransactionManager } from "@erp/core/api";
import { UniqueID } from "@repo/rdx-ddd";
import { Result } from "@repo/rdx-utils";
@ -19,32 +19,15 @@ export class DeleteProformaUseCase {
const { proforma_id, companyId } = params;
const idOrError = UniqueID.create(proforma_id);
if (idOrError.isFailure) {
return Result.fail(idOrError.error);
}
const invoiceId = idOrError.data;
const proformaId = idOrError.data;
return this.transactionManager.complete(async (transaction) => {
try {
const existsCheck = await this.service.existsByIdInCompany(
companyId,
invoiceId,
transaction
);
if (existsCheck.isFailure) {
return Result.fail(existsCheck.error);
}
const invoiceExists = existsCheck.data;
if (!invoiceExists) {
return Result.fail(new EntityNotFoundError("Proforma", "id", invoiceId.toString()));
}
return await this.service.deleteInvoiceByIdInCompany(companyId, invoiceId, transaction);
return await this.service.deleteProformaByIdInCompany(companyId, proformaId, transaction);
} catch (error: unknown) {
return Result.fail(error as Error);
}

View File

@ -50,7 +50,7 @@ export class IssueProformaInvoiceUseCase {
return this.transactionManager.complete(async (transaction) => {
try {
/** 1. Recuperamos la proforma */
const proformaResult = await this.service.getInvoiceByIdInCompany(
const proformaResult = await this.service.getProformaByIdInCompany(
companyId,
proformaId,
transaction
@ -74,7 +74,7 @@ export class IssueProformaInvoiceUseCase {
if (issuedInvoiceOrError.isFailure) return Result.fail(issuedInvoiceOrError.error);
/** 5. Guardar la nueva factura */
const saveInvoiceResult = await this.service.createInvoiceInCompany(
const saveInvoiceResult = await this.service.createIssueInvoiceInCompany(
companyId,
issuedInvoiceOrError.data,
transaction

View File

@ -8,7 +8,7 @@
<title>Factura F26200</title>
<style>
body {
font-family: Arial, sans-serif;
font-family: Tahoma, sans-serif;
margin: 40px;
color: #333;
font-size: 11pt;
@ -55,7 +55,9 @@
table th,
table td {
border: 0px solid;
border-top: 1px solid;
border-left: 1px solid;
border-bottom: 0px solid;
padding: 3px 10px;
text-align: left;
vertical-align: top;
@ -114,13 +116,24 @@
<aside class="flex items-start mb-4 w-full">
<!-- Bloque IZQUIERDO: imagen arriba + texto abajo, alineado a la izquierda -->
<div class="w-[70%] flex flex-col items-start text-left">
<img src="https://rodax-software.com/images/logo1.jpg" alt="Logo Rodax" class="block h-14 w-auto mb-1" />
<img src="https://rodax-software.com/images/logo_acana.jpg" alt="Logo Acana" class="block h-24 w-auto mb-1" />
<div class="p-3 not-italic text-xs leading-tight" style="font-size: 8pt;">
<p>Aliso Design S.L. B86913910</p>
<p>C/ La Fundición, 27. Pol. Santa Ana</p>
<p>Rivas Vaciamadrid 28522 Madrid</p>
<p>Telf: 91 301 65 57 / 91 301 65 58</p>
<p><a href="mailto:info@acanainteriorismo.com"
class="hover:underline">info@acanainteriorismo.com</a>&nbsp;-&nbsp;<a
href="https://www.acanainteriorismo.com" target="_blank" rel="noopener"
class="hover:underline">www.acanainteriorismo.com</a></p>
</div>
<div class="flex w-full">
<div class="p-1 ">
<div class="p-3 ">
<p>Factura nº:<strong>&nbsp;{{series}}{{invoice_number}}</strong></p>
<p><span>Fecha:<strong>&nbsp;{{invoice_date}}</strong></p>
<p>Página <span class="pageNumber"></span> de <span class="totalPages"></span></p>
</div>
<div class="p-1 ml-9">
<div class="p-3 ml-9">
<h2 class="font-semibold uppercase mb-1">{{recipient.name}}</h2>
<p>{{recipient.tin}}</p>
<p>{{recipient.street}}</p>
@ -131,14 +144,8 @@
<!-- Bloque DERECHO: logo2 arriba y texto DEBAJO -->
<div class="ml-auto flex flex-col items-end text-right">
<img src="https://rodax-software.com/images/logo2.jpg" alt="Logo secundario"
class="block h-5 w-auto md:h-8 mb-1" />
<div class="not-italic text-xs leading-tight">
<p>Telf: 91 785 02 47 / 686 62 10 59</p>
<p><a href="mailto:info@rodax-software.com" class="hover:underline">info@rodax-software.com</a></p>
<p><a href="https://www.rodax-software.com" target="_blank" rel="noopener"
class="hover:underline">www.rodax-software.com</a></p>
</div>
<img src="https://rodax-software.com/images/factura_acana.jpg" alt="Factura"
class="block h-14 w-auto md:h-8 mb-1" />
</div>
</aside>
</header>
@ -146,25 +153,15 @@
<main id="main">
<section id="details" class="border-b border-black ">
<div class="relative pt-0 border-b border-black">
<!-- Badge TOTAL decorado con imagen -->
<div class="absolute -top-9 right-0">
<div class="relative text-sm font-semibold text-black pr-2 pl-10 py-2 justify-center bg-red-900"
style="background-image: url('https://rodax-software.com/images/img-total2.jpg'); background-size: cover; background-position: left;">
<!-- Texto del total -->
<span>TOTAL: {{total_amount}}</span>
</div>
</div>
</div>
<!-- Tu tabla -->
<table class="table-header">
<thead>
<tr class="text-left">
<tr class="text-left bg-gray-200 text-red-500">
<th class="py-2">Concepto</th>
<th class="py-2">Cantidad</th>
<th class="py-2">Precio&nbsp;unidad</th>
<th class="py-2">Dto</th>
<th class="py-2">Importe&nbsp;total</th>
</tr>
</thead>
@ -225,20 +222,11 @@
<td class="w-5">&nbsp;</td>
<td class="px-4 text-right">{{taxable_amount}}</td>
</tr>
{{#if taxes_amount }}
<tr>
<td class="px-4 text-right">IVA&nbsp;21%</td>
<td class="w-5">&nbsp;</td>
<td class="px-4 text-right">{{taxes_amount}}</td>
</tr>
{{else}}
<!-- iva 0-->
{{/if}}
{{#each taxes}}
<tr>
<td class="px-4 text-right">IVA&nbsp;{{tax_code}}%</td>
<td class="px-4 text-right">{{tax_name}}</td>
<td class="w-5">&nbsp;</td>
<td class="px-4 text-right">{{taxes_amount.value}}</td>
<td class="px-4 text-right">{{taxes_amount}}</td>
</tr>
{{/each}}
<tr class="">

View File

@ -0,0 +1,260 @@
<!DOCTYPE html>
<html lang="es">
<head>
<meta charset="UTF-8">
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/tailwindcss/2.2.19/tailwind.css"
referrerpolicy="no-referrer" />
<title>Factura F26200</title>
<style>
body {
font-family: Arial, sans-serif;
margin: 40px;
color: #333;
font-size: 11pt;
line-height: 1.6;
}
header {
display: flex;
justify-content: space-between;
margin-bottom: 20px;
margin-bottom: 0;
padding-bottom: 0;
}
.accent-color {
background-color: #F08119;
}
.company-info,
.invoice-meta {
width: 48%;
}
.invoice-meta {
text-align: right;
}
h1 {
font-size: 20px;
margin-bottom: 5px;
}
.contact {
font-size: 14px;
margin-top: 10px;
}
table {
width: 100%;
border-collapse: collapse;
margin-top: 0px;
margin-bottom: 15px;
}
table th,
table td {
border: 0px solid;
padding: 3px 10px;
text-align: left;
vertical-align: top;
}
table th {
margin-bottom: 10px;
}
.totals {
margin-top: 20px;
width: 100%;
}
.totals td {
padding: 5px 10px;
}
.totals td.label {
text-align: right;
font-weight: bold;
}
footer {
margin-top: 40px;
font-size: 10px;
}
.highlight {
background-color: #eef;
}
.accent-color {
background-color: #F08119;
}
@media print {
* {
-webkit-print-color-adjust: exact;
}
thead {
display: table-header-group;
}
tfoot {
display: table-footer-group;
}
}
</style>
</head>
<body>
<header>
<aside class="flex items-start mb-4 w-full">
<!-- Bloque IZQUIERDO: imagen arriba + texto abajo, alineado a la izquierda -->
<div class="w-[70%] flex flex-col items-start text-left">
<img src="https://rodax-software.com/images/logo_rodax.jpg" alt="Logo Rodax" class="block h-14 w-auto mb-1" />
<div class="flex w-full">
<div class="p-1 ">
<p>Factura nº:<strong>&nbsp;{{series}}{{invoice_number}}</strong></p>
<p><span>Fecha:<strong>&nbsp;{{invoice_date}}</strong></p>
</div>
<div class="p-1 ml-9">
<h2 class="font-semibold uppercase mb-1">{{recipient.name}}</h2>
<p>{{recipient.tin}}</p>
<p>{{recipient.street}}</p>
<p>{{recipient.postal_code}}&nbsp;&nbsp;{{recipient.city}}&nbsp;&nbsp;{{recipient.province}}</p>
</div>
</div>
</div>
<!-- Bloque DERECHO: logo2 arriba y texto DEBAJO -->
<div class="ml-auto flex flex-col items-end text-right">
<img src="https://rodax-software.com/images/logo2.jpg" alt="Logo secundario"
class="block h-5 w-auto md:h-8 mb-1" />
<div class="not-italic text-xs leading-tight">
<p>Telf: 91 785 02 47 / 686 62 10 59</p>
<p><a href="mailto:info@rodax-software.com" class="hover:underline">info@rodax-software.com</a></p>
<p><a href="https://www.rodax-software.com" target="_blank" rel="noopener"
class="hover:underline">www.rodax-software.com</a></p>
</div>
</div>
</aside>
</header>
<main id="main">
<section id="details" class="border-b border-black ">
<div class="relative pt-0 border-b border-black">
<!-- Badge TOTAL decorado con imagen -->
<div class="absolute -top-9 right-0">
<div class="relative text-sm font-semibold text-black pr-2 pl-10 py-2 justify-center bg-red-900"
style="background-image: url('https://rodax-software.com/images/img-total2.jpg'); background-size: cover; background-position: left;">
<!-- Texto del total -->
<span>TOTAL: {{total_amount}}</span>
</div>
</div>
</div>
<!-- Tu tabla -->
<table class="table-header">
<thead>
<tr class="text-left">
<th class="py-2">Concepto</th>
<th class="py-2">Cantidad</th>
<th class="py-2">Precio&nbsp;unidad</th>
<th class="py-2">Importe&nbsp;total</th>
</tr>
</thead>
<tbody>
{{#each items}}
<tr>
<td>{{description}}</td>
<td class="text-right">{{#if quantity}}{{quantity}}{{else}}&nbsp;{{/if}}</td>
<td class="text-right">{{#if unit_amount}}{{unit_amount}}{{else}}&nbsp;{{/if}}</td>
<td class="text-right">{{#if taxable_amount}}{{taxable_amount}}{{else}}&nbsp;{{/if}}</td>
</td>
</tr>
{{/each}}
</tbody>
</table>
</section>
<section id="resume" class="flex items-center justify-between pb-4 mb-4">
<div class="grow relative pt-10 self-start">
{{#if payment_method}}
<div class="">
<p class=" text-sm"><strong>Forma de pago:</strong> {{payment_method}}</p>
</div>
{{else}}
<!-- Empty payment method-->
{{/if}}
{{#if notes}}
<div class="pt-4">
<p class="text-sm"><strong>Notas:</strong> {{notes}} </p>
</div>
{{else}}
<!-- Empty notes-->
{{/if}}
</div>
<div class="relative pt-10 grow">
<table class=" table-header min-w-full bg-transparent">
<tbody>
{{#if discount_percentage}}
<tr>
<td class="px-4 text-right">Importe&nbsp;neto</td>
<td class="w-5">&nbsp;</td>
<td class="px-4 text-right">{{subtotal_amount}}</td>
</tr>
<tr>
<td class="px-4 text-right">Descuento&nbsp;{{discount_percentage}}</td>
<td class="w-5">&nbsp;</td>
<td class="px-4 text-right">{{discount_amount.value}}</td>
</tr>
{{else}}
<!-- dto 0-->
{{/if}}
<tr>
<td class="px-4 text-right">Base&nbsp;imponible</td>
<td class="w-5">&nbsp;</td>
<td class="px-4 text-right">{{taxable_amount}}</td>
</tr>
{{#each taxes}}
<tr>
<td class="px-4 text-right">{{tax_name}}</td>
<td class="w-5">&nbsp;</td>
<td class="px-4 text-right">{{taxes_amount}}</td>
</tr>
{{/each}}
<tr class="">
<td class="px-4 text-right accent-color">
Total&nbsp;factura
</td>
<td class="w-5">&nbsp;</td>
<td class="px-4 text-right accent-color">
{{total_amount}}</td>
</tr>
</tbody>
</table>
</div>
</section>
</main>
<footer id="footer" class="mt-4">
<aside>
<p class="text-center">Insc. en el Reg. Merc. de Madrid, Tomo 20.073, Libro 0, Folio 141, Sección 8, Hoja M-354212
| CIF: B83999441 -
Rodax Software S.L.</p>
</aside>
</footer>
</body>
</html>

View File

@ -1 +1 @@
export * from "./update-customer-invoice.use-case";
export * from "./update-proforma.use-case";

View File

@ -10,20 +10,20 @@ import type { CustomerInvoiceApplicationService } from "../../../services/custom
import { mapDTOToUpdateCustomerInvoicePatchProps } from "./map-dto-to-update-customer-invoice-props";
type UpdateCustomerInvoiceUseCaseInput = {
type UpdateProformaUseCaseInput = {
companyId: UniqueID;
proforma_id: string;
dto: UpdateProformaByIdRequestDTO;
};
export class UpdateCustomerInvoiceUseCase {
export class UpdateProformaUseCase {
constructor(
private readonly service: CustomerInvoiceApplicationService,
private readonly transactionManager: ITransactionManager,
private readonly presenterRegistry: IPresenterRegistry
) {}
public execute(params: UpdateCustomerInvoiceUseCaseInput) {
public execute(params: UpdateProformaUseCaseInput) {
const { companyId, proforma_id, dto } = params;
const idOrError = UniqueID.create(proforma_id);

View File

@ -2,3 +2,4 @@ export * from "./customer-invoice-id-already-exits-error";
export * from "./entity-is-not-proforma-error";
export * from "./invalid-proforma-transition-error";
export * from "./proforma-cannot-be-converted-to-invoice-error";
export * from "./proforma-cannot-be-deleted-error";

View File

@ -0,0 +1,12 @@
// domain/errors/proforma-cannot-be-deleted.error.ts
import { DomainError } from "@repo/rdx-ddd";
/** Proforma solo se puede borrar si está en 'draft' */
export class ProformaCannotBeDeletedError extends DomainError {
constructor(id: string, reason?: string, options?: ErrorOptions) {
super(`Proforma '${id}' cannot be deleted${reason ? `: ${reason}` : ""}.`, options);
this.name = "ProformaCannotBeDeletedError";
}
}
export const isProformaCannotBeDeletedError = (e: unknown): e is ProformaCannotBeDeletedError =>
e instanceof ProformaCannotBeDeletedError;

View File

@ -36,7 +36,8 @@ export interface ICustomerInvoiceRepository {
existsByIdInCompany(
companyId: UniqueID,
id: UniqueID,
transaction?: unknown
transaction: unknown,
options: unknown
): Promise<Result<boolean, Error>>;
/**
@ -71,14 +72,14 @@ export interface ICustomerInvoiceRepository {
/**
*
* Elimina o marca como eliminada una factura dentro de una empresa.
* Elimina o marca como eliminada una proforma dentro de una empresa.
*
* @param companyId - ID de la empresa.
* @param id - UUID de la factura a eliminar.
* @param id - UUID de la proforma a eliminar.
* @param transaction - Transacción activa para la operación.
* @returns Result<void, Error>
*/
deleteByIdInCompany(
deleteProformaByIdInCompany(
companyId: UniqueID,
id: UniqueID,
transaction: unknown

View File

@ -1,12 +1,13 @@
import { UtcDate } from "@repo/rdx-ddd";
import type { UtcDate } from "@repo/rdx-ddd";
import { Maybe, Result } from "@repo/rdx-utils";
import { CustomerInvoice } from "../aggregates";
import { EntityIsNotProformaError, ProformaCannotBeConvertedToInvoiceError } from "../errors";
import {
CustomerInvoiceIsProformaSpecification,
ProformaCanTranstionToIssuedSpecification,
} from "../specs";
import { CustomerInvoiceNumber, CustomerInvoiceStatus } from "../value-objects";
import { type CustomerInvoiceNumber, CustomerInvoiceStatus } from "../value-objects";
/**
* Servicio de dominio que encapsula la lógica de emisión de factura definitiva desde una proforma.
@ -15,11 +16,6 @@ export class IssueCustomerInvoiceDomainService {
private readonly isProformaSpec = new CustomerInvoiceIsProformaSpecification();
private readonly isApprovedSpec = new ProformaCanTranstionToIssuedSpecification();
public linkWithProforma(
invoice: CustomerInvoice,
proforma: CustomerInvoice
): Result<CustomerInvoice, Error> {}
/**
* Convierte una proforma en factura definitiva.
*

View File

@ -1,4 +1,5 @@
import { Result } from "@repo/rdx-utils";
import { CustomerInvoice } from "../aggregates";
import { EntityIsNotProformaError, InvalidProformaTransitionError } from "../errors";
import { CustomerInvoiceIsProformaSpecification } from "../specs";

View File

@ -1,5 +1,6 @@
import { CompositeSpecification } from "@repo/rdx-ddd";
import { CustomerInvoice } from "../aggregates";
import type { CustomerInvoice } from "../aggregates";
export class CustomerInvoiceIsProformaSpecification extends CompositeSpecification<CustomerInvoice> {
public async isSatisfiedBy(proforma: CustomerInvoice): Promise<boolean> {

View File

@ -1,2 +1,3 @@
export * from "./customer-invoice-is-proforma.specification";
export * from "./proforma-can-transtion-to-issued.specification";
export * from "./status-invoice-is-draft.specification";

View File

@ -0,0 +1,11 @@
// domain/specifications/status-invoice-is-draft.specification.ts
import { CompositeSpecification } from "@repo/rdx-ddd";
import type { CustomerInvoice } from "../aggregates";
/** Verifica que el estado es borrador */
export class StatusInvoiceIsDraftSpecification extends CompositeSpecification<CustomerInvoice> {
public async isSatisfiedBy(invoice: CustomerInvoice): Promise<boolean> {
return invoice.status.isDraft();
}
}

View File

@ -19,13 +19,14 @@ import {
CustomerInvoiceReportPDFPresenter,
CustomerInvoiceReportPresenter,
CustomerInvoiceTaxesReportPresenter,
DeleteProformaUseCase,
GetProformaUseCase,
IssueProformaInvoiceUseCase,
ListCustomerInvoicesPresenter,
ListProformasUseCase,
RecipientInvoiceFullPresenter,
ReportProformaUseCase,
UpdateCustomerInvoiceUseCase,
UpdateProformaUseCase,
} from "../application";
import { CustomerInvoiceDomainMapper, CustomerInvoiceListMapper } from "./mappers";
@ -42,14 +43,14 @@ export type CustomerInvoiceDeps = {
taxes: JsonTaxCatalogProvider;
};
useCases: {
list: () => ListProformasUseCase;
get: () => GetProformaUseCase;
create: () => CreateProformaUseCase;
update: () => UpdateCustomerInvoiceUseCase;
//delete: () => DeleteCustomerInvoiceUseCase;
report: () => ReportProformaUseCase;
issue: () => IssueProformaInvoiceUseCase;
changeStatus: () => ChangeStatusProformaUseCase;
list_proformas: () => ListProformasUseCase;
get_proforma: () => GetProformaUseCase;
create_proforma: () => CreateProformaUseCase;
update_proforma: () => UpdateProformaUseCase;
delete_proforma: () => DeleteProformaUseCase;
report_proforma: () => ReportProformaUseCase;
issue_proforma: () => IssueProformaInvoiceUseCase;
changeStatus_proforma: () => ChangeStatusProformaUseCase;
};
};
@ -123,16 +124,20 @@ export function buildCustomerInvoiceDependencies(params: ModuleParams): Customer
},
]);
const useCases = {
list: () => new ListProformasUseCase(appService, transactionManager, presenterRegistry),
get: () => new GetProformaUseCase(appService, transactionManager, presenterRegistry),
create: () =>
const useCases: CustomerInvoiceDeps["useCases"] = {
list_proformas: () =>
new ListProformasUseCase(appService, transactionManager, presenterRegistry),
get_proforma: () => new GetProformaUseCase(appService, transactionManager, presenterRegistry),
create_proforma: () =>
new CreateProformaUseCase(appService, transactionManager, presenterRegistry, catalogs.taxes),
update: () =>
new UpdateCustomerInvoiceUseCase(appService, transactionManager, presenterRegistry),
report: () => new ReportProformaUseCase(appService, transactionManager, presenterRegistry),
issue: () => new IssueProformaInvoiceUseCase(appService, transactionManager, presenterRegistry),
changeStatus: () => new ChangeStatusProformaUseCase(appService, transactionManager),
update_proforma: () =>
new UpdateProformaUseCase(appService, transactionManager, presenterRegistry),
delete_proforma: () => new DeleteProformaUseCase(appService, transactionManager),
report_proforma: () =>
new ReportProformaUseCase(appService, transactionManager, presenterRegistry),
issue_proforma: () =>
new IssueProformaInvoiceUseCase(appService, transactionManager, presenterRegistry),
changeStatus_proforma: () => new ChangeStatusProformaUseCase(appService, transactionManager),
};
return {

View File

@ -4,10 +4,7 @@ import type { DeleteProformaUseCase } from "../../../../application";
import { customerInvoicesApiErrorMapper } from "../../customer-invoices-api-error-mapper";
export class DeleteProformaController extends ExpressController {
public constructor(
private readonly useCase: DeleteProformaUseCase
/* private readonly presenter: any */
) {
public constructor(private readonly useCase: DeleteProformaUseCase) {
super();
this.errorMapper = customerInvoicesApiErrorMapper;
@ -22,6 +19,9 @@ export class DeleteProformaController extends ExpressController {
}
const { proforma_id } = this.req.params;
if (!proforma_id) {
return this.invalidInputError("Proforma ID missing");
}
const result = await this.useCase.execute({ proforma_id, companyId });

View File

@ -1,11 +1,11 @@
import { ExpressController, authGuard, forbidQueryFieldGuard, tenantGuard } from "@erp/core/api";
import type { UpdateProformaByIdRequestDTO } from "../../../../../common/dto";
import type { UpdateCustomerInvoiceUseCase } from "../../../../application";
import type { UpdateProformaUseCase } from "../../../../application";
import { customerInvoicesApiErrorMapper } from "../../customer-invoices-api-error-mapper";
export class UpdateProformaController extends ExpressController {
public constructor(private readonly useCase: UpdateCustomerInvoiceUseCase) {
public constructor(private readonly useCase: UpdateProformaUseCase) {
super();
this.errorMapper = customerInvoicesApiErrorMapper;

View File

@ -15,6 +15,7 @@ import {
isCustomerInvoiceIdAlreadyExistsError,
isEntityIsNotProformaError,
isProformaCannotBeConvertedToInvoiceError,
isProformaCannotBeDeletedError,
} from "../../domain";
// Crea una regla específica (prioridad alta para sobreescribir mensajes)
@ -47,8 +48,18 @@ const proformaConversionRule: ErrorToApiRule = {
),
};
const proformaCannotBeDeletedRule: ErrorToApiRule = {
priority: 120,
matches: (e) => isProformaCannotBeDeletedError(e),
build: (e) =>
new ValidationApiError(
(e as ProformaCannotBeConvertedToInvoiceError).message || "Proforma cannot be deleted."
),
};
// Cómo aplicarla: crea una nueva instancia del mapper con la regla extra
export const customerInvoicesApiErrorMapper: ApiErrorMapper = ApiErrorMapper.default()
.register(invoiceDuplicateRule)
.register(entityIsNotProformaError)
.register(proformaConversionRule);
.register(proformaConversionRule)
.register(proformaCannotBeDeletedRule);

View File

@ -4,7 +4,9 @@ import {
ChangeStatusProformaByIdParamsRequestSchema,
ChangeStatusProformaByIdRequestSchema,
CreateProformaRequestSchema,
DeleteProformaByIdParamsRequestSchema,
GetProformaByIdRequestSchema,
IssueProformaByIdParamsRequestSchema,
ListProformasRequestSchema,
ReportProformaByIdRequestSchema,
UpdateProformaByIdParamsRequestSchema,
@ -19,12 +21,13 @@ import { buildCustomerInvoiceDependencies } from "../dependencies";
import {
ChangeStatusProformaController,
CreateProformaController,
DeleteProformaController,
GetProformaController,
IssueProformaController,
ListProformasController,
ReportProformaController,
UpdateProformaController,
} from "./controllers/proformas";
import { IssueProformaController } from "./controllers/proformas/issue-proforma.controller";
export const proformasRouter = (params: ModuleParams) => {
const { app, baseRoutePath, logger } = params as {
@ -60,7 +63,7 @@ export const proformasRouter = (params: ModuleParams) => {
//checkTabContext,
validateRequest(ListProformasRequestSchema, "params"),
async (req: Request, res: Response, next: NextFunction) => {
const useCase = deps.useCases.list();
const useCase = deps.useCases.list_proformas();
const controller = new ListProformasController(useCase /*, deps.presenters.list */);
return controller.execute(req, res, next);
}
@ -71,7 +74,7 @@ export const proformasRouter = (params: ModuleParams) => {
//checkTabContext,
validateRequest(GetProformaByIdRequestSchema, "params"),
(req: Request, res: Response, next: NextFunction) => {
const useCase = deps.useCases.get();
const useCase = deps.useCases.get_proforma();
const controller = new GetProformaController(useCase);
return controller.execute(req, res, next);
}
@ -83,7 +86,7 @@ export const proformasRouter = (params: ModuleParams) => {
validateRequest(CreateProformaRequestSchema, "body"),
(req: Request, res: Response, next: NextFunction) => {
const useCase = deps.useCases.create();
const useCase = deps.useCases.create_proforma();
const controller = new CreateProformaController(useCase);
return controller.execute(req, res, next);
}
@ -96,30 +99,30 @@ export const proformasRouter = (params: ModuleParams) => {
validateRequest(UpdateProformaByIdParamsRequestSchema, "params"),
validateRequest(UpdateProformaByIdRequestSchema, "body"),
(req: Request, res: Response, next: NextFunction) => {
const useCase = deps.useCases.update();
const useCase = deps.useCases.update_proforma();
const controller = new UpdateProformaController(useCase);
return controller.execute(req, res, next);
}
);
/*router.delete(
router.delete(
"/:proforma_id",
//checkTabContext,
validateRequest(DeleteCustomerInvoiceByIdRequestSchema, "params"),
validateRequest(DeleteProformaByIdParamsRequestSchema, "params"),
(req: Request, res: Response, next: NextFunction) => {
const useCase = deps.useCases.delete();
const controller = new DeleteCustomerInvoiceController(useCase);
const useCase = deps.useCases.delete_proforma();
const controller = new DeleteProformaController(useCase);
return controller.execute(req, res, next);
}
);*/
);
router.get(
"/:proforma_id/report",
//checkTabContext,
validateRequest(ReportProformaByIdRequestSchema, "params"),
(req: Request, res: Response, next: NextFunction) => {
const useCase = deps.useCases.report();
const useCase = deps.useCases.report_proforma();
const controller = new ReportProformaController(useCase);
return controller.execute(req, res, next);
}
@ -133,7 +136,7 @@ export const proformasRouter = (params: ModuleParams) => {
validateRequest(ChangeStatusProformaByIdRequestSchema, "body"),
(req: Request, res: Response, next: NextFunction) => {
const useCase = deps.useCases.changeStatus();
const useCase = deps.useCases.changeStatus_proforma();
const controller = new ChangeStatusProformaController(useCase);
return controller.execute(req, res, next);
}
@ -143,11 +146,10 @@ export const proformasRouter = (params: ModuleParams) => {
"/:proforma_id/issue",
//checkTabContext,
/*validateRequest(XXX, "params"),
validateRequest(XXX, "body"),*/
validateRequest(IssueProformaByIdParamsRequestSchema, "params"),
(req: Request, res: Response, next: NextFunction) => {
const useCase = deps.useCases.issue();
const useCase = deps.useCases.issue_proforma();
const controller = new IssueProformaController(useCase);
return controller.execute(req, res, next);
}

View File

@ -166,16 +166,23 @@ export class CustomerInvoiceRepository
* @param companyId - Identificador UUID de la empresa a la que pertenece la factura.
* @param id - Identificador UUID de la factura.
* @param transaction - Transacción activa para la operación.
* @param options - Opciones adicionales para la consulta (Sequelize FindOptions)
* @returns Result<boolean, Error>
*/
async existsByIdInCompany(
companyId: UniqueID,
id: UniqueID,
transaction?: Transaction
transaction: Transaction,
options: FindOptions<InferAttributes<CustomerInvoiceModel>> = {}
): Promise<Result<boolean, Error>> {
try {
const count = await CustomerInvoiceModel.count({
where: { id: id.toString(), company_id: companyId.toString() },
...options,
where: {
id: id.toString(),
company_id: companyId.toString(),
...(options.where ?? {}),
},
transaction,
});
return Result.ok(Boolean(count > 0));
@ -191,7 +198,7 @@ export class CustomerInvoiceRepository
* @param companyId - Identificador UUID de la empresa a la que pertenece la factura.
* @param id - UUID de la factura.
* @param transaction - Transacción activa para la operación.
* @params options - Opciones adicionales para la consulta (Sequelize FindOptions)
* @param options - Opciones adicionales para la consulta (Sequelize FindOptions)
* @returns Result<CustomerInvoice, Error>
*/
async getByIdInCompany(
@ -367,21 +374,25 @@ export class CustomerInvoiceRepository
/**
*
* Elimina o marca como eliminada una factura.
* Elimina o marca como eliminada una proforma dentro de una empresa.
*
* @param companyId - Identificador UUID de la empresa a la que pertenece el cliente.
* @param id - UUID de la factura a eliminar.
* @param companyId - ID de la empresa.
* @param id - UUID de la proforma a eliminar.
* @param transaction - Transacción activa para la operación.
* @returns Result<boolean, Error>
* @returns Result<void, Error>
*/
async deleteByIdInCompany(
async deleteProformaByIdInCompany(
companyId: UniqueID,
id: UniqueID,
transaction: Transaction
): Promise<Result<boolean, Error>> {
try {
const deleted = await CustomerInvoiceModel.destroy({
where: { id: id.toString(), company_id: companyId.toString() },
where: {
id: id.toString(),
company_id: companyId.toString(),
is_proforma: true,
},
transaction,
});
@ -424,8 +435,6 @@ export class CustomerInvoiceRepository
}
);
console.log(affected);
if (affected === 0) {
return Result.fail(
new InfrastructureRepositoryError(

View File

@ -6,8 +6,8 @@ import { z } from "zod/v4";
*
*/
export const DeleteProformaByIdRequestSchema = z.object({
id: z.string(),
export const DeleteProformaByIdParamsRequestSchema = z.object({
proforma_id: z.string(),
});
export type DeleteProformaByIdRequestDTO = z.infer<typeof DeleteProformaByIdRequestSchema>;
export type DeleteProformaByIdRequestDTO = z.infer<typeof DeleteProformaByIdParamsRequestSchema>;

View File

@ -2,6 +2,7 @@ export * from "./change-status-proforma-by-id.request.dto";
export * from "./create-proforma.request.dto";
export * from "./delete-proforma-by-id.request.dto";
export * from "./get-proforma-by-id.request.dto";
export * from "./issue-proforma-by-id.request.dto";
export * from "./list-proformas.request.dto";
export * from "./report-proforma-by-id.request.dto";
export * from "./update-proforma-by-id.request.dto";

View File

@ -0,0 +1,5 @@
import { z } from "zod/v4";
export const IssueProformaByIdParamsRequestSchema = z.object({
proforma_id: z.string(),
});