Peueños errores

.
2026-04-15 12:23:59 +02:00 · 2026-04-15 11:30:55 +02:00
17 changed files with 112 additions and 62 deletions
--- a/apps/server/package.json
+++ b/apps/server/package.json
@ -17,7 +17,7 @@
    "@types/bcrypt": "^6.0.0",
    "@types/cors": "^2.8.19",
    "@types/dinero.js": "^2.0.0",
-    "@types/express": "^5.0.6",
+    "@types/express": "^4.17.21",
    "@types/glob": "^9.0.0",
    "@types/jsonwebtoken": "^9.0.10",
    "@types/luxon": "^3.7.1",
--- a/modules/auth/package.json
+++ b/modules/auth/package.json
@ -19,7 +19,7 @@
  },
  "devDependencies": {
    "@biomejs/biome": "^2.4.11",
-    "@types/express": "^5.0.6",
+    "@types/express": "^4.17.21",
    "@types/react": "^19.2.14",
    "@types/react-dom": "^19.2.3",
    "react": "^19.2.5",
--- a/modules/core/package.json
+++ b/modules/core/package.json
@ -24,7 +24,7 @@
  "devDependencies": {
    "@hookform/devtools": "^4.4.0",
    "@types/dinero.js": "^2.0.0",
-    "@types/express": "^5.0.6",
+    "@types/express": "^4.17.21",
    "@types/mime-types": "^3.0.1",
    "@types/react": "^19.2.14",
    "react": "^19.2.5",
--- a/modules/customer-invoices/package.json
+++ b/modules/customer-invoices/package.json
@ -23,7 +23,7 @@
  "devDependencies": {
    "@hookform/devtools": "^4.4.0",
    "@types/dinero.js": "^2.0.0",
-    "@types/express": "^5.0.6",
+    "@types/express": "^4.17.21",
    "@types/react": "^19.2.14",
    "@types/react-dom": "^19.2.3",
    "@types/react-router-dom": "^5.3.3",
@ -39,6 +39,7 @@
    "@erp/core": "workspace:*",
    "@erp/customers": "workspace:*",
    "@hookform/resolvers": "^5.2.2",
+    "@lglab/react-qr-code": "^1.4.10",
    "@repo/i18next": "workspace:*",
    "@repo/rdx-criteria": "workspace:*",
    "@repo/rdx-ddd": "workspace:*",
--- a/modules/customer-invoices/src/api/application/issued-invoices/services/proforma-to-issued-invoice-props-converter.ts
+++ b/modules/customer-invoices/src/api/application/issued-invoices/services/proforma-to-issued-invoice-props-converter.ts
@ -1,3 +1,4 @@
+import { UtcDate } from "@repo/rdx-ddd";
 import { Maybe, Result } from "@repo/rdx-utils";

 import {
@ -102,7 +103,7 @@ export class ProformaToIssuedInvoiceConverter implements IProformaToIssuedInvoic

      invoiceNumber: proforma.invoiceNumber,

-      invoiceDate: proforma.invoiceDate,
+      invoiceDate: UtcDate.today(), // La fecha de la factura es la fecha de emisión, no la de la proforma
      operationDate: proforma.operationDate,

      description: proforma.description,
--- a/modules/customer-invoices/src/api/domain/proformas/value-objects/proforma-item-taxes.vo.ts
+++ b/modules/customer-invoices/src/api/domain/proformas/value-objects/proforma-item-taxes.vo.ts
@ -1,6 +1,6 @@
 import type { Tax } from "@erp/core/api";
 import { ValueObject } from "@repo/rdx-ddd";
-import { type Maybe, Result } from "@repo/rdx-utils";
+import { Maybe, Result } from "@repo/rdx-utils";

 import { ItemAmount } from "../../common/value-objects";

@ -32,6 +32,19 @@ export class ProformaItemTaxes
    return Result.ok(new ProformaItemTaxes(props));
  }

+  /**
+   * Crea una instancia "vacía" (sin impuestos)
+   * - Evita duplicación de lógica de construcción
+   * - Centraliza el concepto de "sin impuestos"
+   */
+  static empty(): ProformaItemTaxes {
+    return new ProformaItemTaxes({
+      iva: Maybe.none(),
+      rec: Maybe.none(),
+      retention: Maybe.none(),
+    });
+  }
+
  toKey(): string {
    const ivaCode = this.props.iva.match(
      (iva) => iva.code,
--- a/modules/customer-invoices/src/api/infrastructure/issued-invoices/express/issued-invoices.routes.ts
+++ b/modules/customer-invoices/src/api/infrastructure/issued-invoices/express/issued-invoices.routes.ts
@ -68,8 +68,8 @@ export const issuedInvoicesRouter = (params: StartParams) => {
  router.get(
    "/:invoice_id/report",
    //checkTabContext,
-    validateRequest(ReportIssueInvoiceByIdParamsRequestSchema, "params"),
    validateRequest(ReportIssueInvoiceByIdQueryRequestSchema, "query"),
+    validateRequest(ReportIssueInvoiceByIdParamsRequestSchema, "params"),

    (req: Request, res: Response, next: NextFunction) => {
      const useCase = deps.useCases.reportIssuedInvoice();
--- a/modules/customer-invoices/src/api/infrastructure/issued-invoices/persistence/sequelize/repositories/issued-invoice.repository.ts
+++ b/modules/customer-invoices/src/api/infrastructure/issued-invoices/persistence/sequelize/repositories/issued-invoice.repository.ts
@ -283,12 +283,6 @@ export class IssuedInvoiceRepository
        },
      ];

-      // Reemplazar findAndCountAll por findAll + count (más control y mejor rendimiento)
-      /*const { rows, count } = await CustomerInvoiceModel.findAndCountAll({
-            ...query,
-            transaction,
-          });*/
-
      const [rows, count] = await Promise.all([
        CustomerInvoiceModel.findAll({
          ...query,
--- a/modules/customer-invoices/src/api/infrastructure/proformas/express/proformas.routes.ts
+++ b/modules/customer-invoices/src/api/infrastructure/proformas/express/proformas.routes.ts
@ -13,7 +13,7 @@ import {
 import {
  CreateProformaRequestSchema,
  GetProformaByIdRequestSchema,
-  IssueProformaByIdResponseSchema,
+  IssueProformaByIdParamsRequestSchema,
  ListProformasRequestSchema,
  ReportProformaByIdParamsRequestSchema,
  ReportProformaByIdQueryRequestSchema,
@ -150,7 +150,7 @@ export const proformasRouter = (params: StartParams) => {
    "/:proforma_id/issue",
    //checkTabContext,

-    validateRequest(IssueProformaByIdResponseSchema, "params"),
+    validateRequest(IssueProformaByIdParamsRequestSchema, "params"),

    (req: Request, res: Response, next: NextFunction) => {
      const useCase = deps.useCases.issueProforma(publicServices);
--- a/modules/customer-invoices/src/web/issued-invoices/list/controllers/use-issued-invoice-list.controller.ts
+++ b/modules/customer-invoices/src/web/issued-invoices/list/controllers/use-issued-invoice-list.controller.ts
@ -3,12 +3,12 @@ import { useMemo, useState } from "react";

 import type {
  IssuedInvoiceList,
-  IssuedInvoiceStatus,
  ListIssuedInvoicesByCriteriaParams,
+  VerifactuRecordStatus,
 } from "../../shared";
 import { useIssuedInvoiceListQuery } from "../../shared/";

-type IssuedInvoiceListStatusFilter = "all" | IssuedInvoiceStatus;
+type VerifactuRecordListStatusFilter = "all" | VerifactuRecordStatus;

 const EMPTY_ISSUED_INVOICES_LIST: IssuedInvoiceList = {
  items: [],
@ -22,7 +22,8 @@ export const useIssuedInvoiceListController = () => {
  const [pageIndex, setPageIndex] = useState(0);
  const [pageSize, setPageSize] = useState(5);
  const [search, setSearch] = useState("");
-  const [statusFilter, setStatusFilter] = useState<IssuedInvoiceListStatusFilter>("all");
+  const [verifactuStatusFilter, setVerifactuStatusFilter] =
+    useState<VerifactuRecordListStatusFilter>("all");

  const debouncedSearch = useDebounce(search, 300);

@ -33,17 +34,20 @@ export const useIssuedInvoiceListController = () => {
      pageSize,
      order: "desc",
      orderBy: "invoice_date",
-      filters: status === "all" ? [] : [{ field: "status", operator: "eq", value: status }],
+      filters:
+        verifactuStatusFilter === "all"
+          ? []
+          : [{ field: "verifactu.status", operator: "eq", value: verifactuStatusFilter }],
    }),
-    [debouncedSearch, pageIndex, pageSize, status]
+    [debouncedSearch, pageIndex, pageSize, verifactuStatusFilter]
  );

  const query = useIssuedInvoiceListQuery({ criteria });

  const setStatusFilterValue = (value: string) => {
-    const nextValue = (value || "all") as IssuedInvoiceListStatusFilter;
+    const nextValue = (value || "all") as VerifactuRecordListStatusFilter;

-    setStatusFilter((prev) => {
+    setVerifactuStatusFilter((prev) => {
      if (prev === nextValue) return prev;

      // Sólo si la búsqueda realmente cambia,
@ -95,7 +99,7 @@ export const useIssuedInvoiceListController = () => {
    search,
    setSearchValue,

-    statusFilter,
+    statusFilter: verifactuStatusFilter,
    setStatusFilter: setStatusFilterValue,
  };
 };
--- a/modules/customer-invoices/src/web/issued-invoices/list/ui/blocks/issued-invoices-grid/use-issued-invoices-grid-columns.tsx
+++ b/modules/customer-invoices/src/web/issued-invoices/list/ui/blocks/issued-invoices-grid/use-issued-invoices-grid-columns.tsx
@ -1,4 +1,5 @@
 import { formatDate } from "@erp/core/client";
+import { ReactQRCode } from "@lglab/react-qr-code";
 import { DataTableColumnHeader } from "@repo/rdx-ui/components";
 import {
  Button,
@ -16,7 +17,6 @@ import {
 import type { ColumnDef } from "@tanstack/react-table";
 import { DownloadIcon, FileDownIcon, MailIcon, MoreVerticalIcon, QrCodeIcon } from "lucide-react";
 import * as React from "react";
-import QrCode from "react-qr-code";

 import { useTranslation } from "../../../../../i18n";
 import type { IssuedInvoiceListRow } from "../../../../shared";
@ -115,7 +115,17 @@ export function useIssuedInvoicesGridColumns(
                    }
                  />
                  <TooltipContent className="m-0 p-3">
-                    <QrCode className="bg-white p-8" value={verifactu.url} />
+                    <div className="border-2 border-black">
+                      <ReactQRCode
+                        background="#fff"
+                        dataModulesSettings={{ color: "#000" }}
+                        finderPatternInnerSettings={{ color: "#000" }}
+                        finderPatternOuterSettings={{ color: "#000" }}
+                        marginSize={8}
+                        size={256}
+                        value={verifactu.url}
+                      />
+                    </div>
                  </TooltipContent>
                </Tooltip>
              )}
--- a/modules/customers/package.json
+++ b/modules/customers/package.json
@ -23,7 +23,7 @@
    "react-dom": "^19.2.5"
  },
  "devDependencies": {
-    "@types/express": "^5.0.6",
+    "@types/express": "^4.17.21",
    "@types/react": "^19.2.14",
    "@types/react-router-dom": "^5.3.3",
    "react": "^19.2.5",
--- a/modules/customers/src/api/infrastructure/express/controllers/get-customer.controller.ts
+++ b/modules/customers/src/api/infrastructure/express/controllers/get-customer.controller.ts
@ -4,12 +4,12 @@ import {
  requireAuthenticatedGuard,
  requireCompanyContextGuard,
 } from "@erp/core/api";
+import type { GetCustomerByIdUseCase } from "@erp/customers/api/application";

-import type { GetCustomerUseCase } from "../../../application";
 import { customersApiErrorMapper } from "../customer-api-error-mapper";

 export class GetCustomerController extends ExpressController {
-  public constructor(private readonly useCase: GetCustomerUseCase) {
+  public constructor(private readonly useCase: GetCustomerByIdUseCase) {
    super();
    this.errorMapper = customersApiErrorMapper;

--- a/modules/factuges/package.json
+++ b/modules/factuges/package.json
@ -14,7 +14,7 @@
    "./api": "./src/api/index.ts"
  },
  "devDependencies": {
-    "@types/express": "^5.0.6",
+    "@types/express": "^4.17.21",
    "typescript": "^6.0.2"
  },
  "dependencies": {
--- a/modules/supplier-invoices/package.json
+++ b/modules/supplier-invoices/package.json
@ -15,7 +15,7 @@
    "./api": "./src/api/index.ts"
  },
  "devDependencies": {
-    "@types/express": "^5.0.6",
+    "@types/express": "^4.17.21",
    "typescript": "^6.0.2"
  },
  "dependencies": {
--- a/modules/supplier/package.json
+++ b/modules/supplier/package.json
@ -23,7 +23,7 @@
    "react-dom": "^19.2.5"
  },
  "devDependencies": {
-    "@types/express": "^5.0.6",
+    "@types/express": "^4.17.21",
    "@types/react": "^19.2.14",
    "@types/react-router-dom": "^5.3.3",
    "react": "^19.2.5",
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@ -175,8 +175,8 @@ importers:
        specifier: ^2.0.0
        version: 2.0.0
      '@types/express':
-        specifier: ^5.0.6
-        version: 5.0.6
+        specifier: ^4.17.21
+        version: 4.17.25
      '@types/glob':
        specifier: ^9.0.0
        version: 9.0.0
@ -360,8 +360,8 @@ importers:
        specifier: ^2.4.11
        version: 2.4.11
      '@types/express':
-        specifier: ^5.0.6
-        version: 5.0.6
+        specifier: ^4.17.21
+        version: 4.17.25
      '@types/react':
        specifier: ^19.2.14
        version: 19.2.14
@ -448,8 +448,8 @@ importers:
        specifier: ^2.0.0
        version: 2.0.0
      '@types/express':
-        specifier: ^5.0.6
-        version: 5.0.6
+        specifier: ^4.17.21
+        version: 4.17.25
      '@types/mime-types':
        specifier: ^3.0.1
        version: 3.0.1
@ -489,6 +489,9 @@ importers:
      '@hookform/resolvers':
        specifier: ^5.2.2
        version: 5.2.2(react-hook-form@7.72.1(react@19.2.5))
+      '@lglab/react-qr-code':
+        specifier: ^1.4.10
+        version: 1.4.10(react@19.2.5)
      '@repo/i18next':
        specifier: workspace:*
        version: link:../../packages/i18n
@ -563,8 +566,8 @@ importers:
        specifier: ^2.0.0
        version: 2.0.0
      '@types/express':
-        specifier: ^5.0.6
-        version: 5.0.6
+        specifier: ^4.17.21
+        version: 4.17.25
      '@types/react':
        specifier: ^19.2.14
        version: 19.2.14
@ -651,8 +654,8 @@ importers:
        version: 4.3.6
    devDependencies:
      '@types/express':
-        specifier: ^5.0.6
-        version: 5.0.6
+        specifier: ^4.17.21
+        version: 4.17.25
      '@types/react':
        specifier: ^19.2.14
        version: 19.2.14
@ -709,8 +712,8 @@ importers:
        version: 4.3.6
    devDependencies:
      '@types/express':
-        specifier: ^5.0.6
-        version: 5.0.6
+        specifier: ^4.17.21
+        version: 4.17.25
      typescript:
        specifier: ^6.0.2
        version: 6.0.2
@ -782,8 +785,8 @@ importers:
        version: 4.3.6
    devDependencies:
      '@types/express':
-        specifier: ^5.0.6
-        version: 5.0.6
+        specifier: ^4.17.21
+        version: 4.17.25
      '@types/react':
        specifier: ^19.2.14
        version: 19.2.14
@ -834,8 +837,8 @@ importers:
        version: 4.3.6
    devDependencies:
      '@types/express':
-        specifier: ^5.0.6
-        version: 5.0.6
+        specifier: ^4.17.21
+        version: 4.17.25
      typescript:
        specifier: ^6.0.2
        version: 6.0.2
@ -2226,6 +2229,11 @@ packages:
  '@jridgewell/trace-mapping@0.3.9':
    resolution: {integrity: sha512-3Belt6tdc8bPgAtbcmdtNJlirVoTmEb5e2gC94PnkwEW9jI6CAHUeoG85tjWP5WquqfavoMtMwiG4P926ZKKuQ==}

+  '@lglab/react-qr-code@1.4.10':
+    resolution: {integrity: sha512-B+VOFfvnx+NqVaJqDbh1glHEU/rJR/3XtINcvM3qC9DW292GbaLNoa2OvRlXHYUQdsWcdzNzOcPzT39P1O8uJg==}
+    peerDependencies:
+      react: ^18 || ^19
+
  '@modelcontextprotocol/sdk@1.29.0':
    resolution: {integrity: sha512-zo37mZA9hJWpULgkRpowewez1y6ML5GsXJPY8FI0tBBCd77HEvza4jDqRKOXgHNn867PVGCyTdzqpz0izu5ZjQ==}
    engines: {node: '>=18'}
@ -3589,11 +3597,11 @@ packages:
  '@types/estree@1.0.8':
    resolution: {integrity: sha512-dWHzHa2WqEXI/O1E9OjrocMTKJl2mSrEolh1Iomrv6U+JuNwaHXsXx9bLu5gG7BUWFIN0skIQJQ/L1rIex4X6w==}

-  '@types/express-serve-static-core@5.1.1':
-    resolution: {integrity: sha512-v4zIMr/cX7/d2BpAEX3KNKL/JrT1s43s96lLvvdTmza1oEvDudCqK9aF/djc/SWgy8Yh0h30TZx5VpzqFCxk5A==}
+  '@types/express-serve-static-core@4.19.8':
+    resolution: {integrity: sha512-02S5fmqeoKzVZCHPZid4b8JH2eM5HzQLZWN2FohQEy/0eXTq8VXZfSN6Pcr3F6N9R/vNrj7cpgbhjie6m/1tCA==}

-  '@types/express@5.0.6':
-    resolution: {integrity: sha512-sKYVuV7Sv9fbPIt/442koC7+IIwK5olP1KWeD88e/idgoJqDm3JV/YUiPwkoKK92ylff2MGxSz1CSjsXelx0YA==}
+  '@types/express@4.17.25':
+    resolution: {integrity: sha512-dVd04UKsfpINUnK0yBoYHDF3xu7xVH4BuDotC/xGuycx4CgbP48X/KF/586bcObxT0HENHXEU8Nqtu6NR+eKhw==}

  '@types/fined@1.1.5':
    resolution: {integrity: sha512-2N93vadEGDFhASTIRbizbl4bNqpMOId5zZfj6hHqYZfEzEfO9onnU4Im8xvzo8uudySDveDHBOOSlTWf38ErfQ==}
@ -3629,6 +3637,9 @@ packages:
  '@types/mime-types@3.0.1':
    resolution: {integrity: sha512-xRMsfuQbnRq1Ef+C+RKaENOxXX87Ygl38W1vDfPHRku02TgQr+Qd8iivLtAMcR0KF5/29xlnFihkTlbqFrGOVQ==}

+  '@types/mime@1.3.5':
+    resolution: {integrity: sha512-/pyBZWSLD2n0dcHE3hq8s8ZvcETHtEuF+3E7XVt0Ig2nvsVQXdghHVcEkIWjy9A0wKfTn97a/PSDYohKIlnP/w==}
+
  '@types/ms@2.1.0':
    resolution: {integrity: sha512-GsCCIZDE/p3i96vtEqx+7dBUGXrc7zeSK3wwPHIaRThS+9OhWIXRqzs4d6k1SVU8g91DrNRWxWUGhp5KXQb2VA==}

@ -3682,11 +3693,14 @@ packages:
  '@types/response-time@2.3.9':
    resolution: {integrity: sha512-w5i5/y/1N3hkSBru1dat7Pf/YzdFLAANbKR78i2VIPnKw1Ub2ZNXE/n3K4v1BBMIIbAccgxpGZT8lIuLW284Dw==}

+  '@types/send@0.17.6':
+    resolution: {integrity: sha512-Uqt8rPBE8SY0RK8JB1EzVOIZ32uqy8HwdxCnoCOsYrvnswqmFZ/k+9Ikidlk/ImhsdvBsloHbAlewb2IEBV/Og==}
+
  '@types/send@1.2.1':
    resolution: {integrity: sha512-arsCikDvlU99zl1g69TcAB3mzZPpxgw0UQnaHeC1Nwb015xp8bknZv5rIfri9xTOcMuaVgvabfIRA7PSZVuZIQ==}

-  '@types/serve-static@2.2.0':
-    resolution: {integrity: sha512-8mam4H1NHLtu7nmtalF7eyBH14QyOASmcxHhSfEoRyr0nP/YdoesEtU+uSRvMe96TW/HPTtkoKqQLl53N7UXMQ==}
+  '@types/serve-static@1.15.10':
+    resolution: {integrity: sha512-tRs1dB+g8Itk72rlSI2ZrW6vZg0YrLI81iQSTkMmOqnqCaNr/8Ek4VwWcN5vZgCYWbg/JJSGBlUaYGAOP73qBw==}

  '@types/statuses@2.0.6':
    resolution: {integrity: sha512-xMAgYwceFhRA2zY+XbEA7mxYbA093wdiW8Vu6gZPGWy9cmOyU9XesH1tNcEWsKFd5Vzrqx5T3D38PWx1FIIXkA==}
@ -8015,6 +8029,10 @@ snapshots:
      '@jridgewell/resolve-uri': 3.1.2
      '@jridgewell/sourcemap-codec': 1.5.5

+  '@lglab/react-qr-code@1.4.10(react@19.2.5)':
+    dependencies:
+      react: 19.2.5
+
  '@modelcontextprotocol/sdk@1.29.0(zod@3.25.76)':
    dependencies:
      '@hono/node-server': 1.19.13(hono@4.12.12)
@ -9273,18 +9291,19 @@ snapshots:

  '@types/estree@1.0.8': {}

-  '@types/express-serve-static-core@5.1.1':
+  '@types/express-serve-static-core@4.19.8':
    dependencies:
      '@types/node': 25.6.0
      '@types/qs': 6.15.0
      '@types/range-parser': 1.2.7
      '@types/send': 1.2.1

-  '@types/express@5.0.6':
+  '@types/express@4.17.25':
    dependencies:
      '@types/body-parser': 1.19.6
-      '@types/express-serve-static-core': 5.1.1
-      '@types/serve-static': 2.2.0
+      '@types/express-serve-static-core': 4.19.8
+      '@types/qs': 6.15.0
+      '@types/serve-static': 1.15.10

  '@types/fined@1.1.5': {}

@ -9319,6 +9338,8 @@ snapshots:

  '@types/mime-types@3.0.1': {}

+  '@types/mime@1.3.5': {}
+
  '@types/ms@2.1.0': {}

  '@types/node@25.6.0':
@ -9334,18 +9355,18 @@ snapshots:

  '@types/passport-local@1.0.38':
    dependencies:
-      '@types/express': 5.0.6
+      '@types/express': 4.17.25
      '@types/passport': 1.0.17
      '@types/passport-strategy': 0.2.38

  '@types/passport-strategy@0.2.38':
    dependencies:
-      '@types/express': 5.0.6
+      '@types/express': 4.17.25
      '@types/passport': 1.0.17

  '@types/passport@1.0.17':
    dependencies:
-      '@types/express': 5.0.6
+      '@types/express': 4.17.25

  '@types/picomatch@4.0.3': {}

@ -9382,17 +9403,23 @@ snapshots:

  '@types/response-time@2.3.9':
    dependencies:
-      '@types/express': 5.0.6
+      '@types/express': 4.17.25
+      '@types/node': 25.6.0
+
+  '@types/send@0.17.6':
+    dependencies:
+      '@types/mime': 1.3.5
      '@types/node': 25.6.0

  '@types/send@1.2.1':
    dependencies:
      '@types/node': 25.6.0

-  '@types/serve-static@2.2.0':
+  '@types/serve-static@1.15.10':
    dependencies:
      '@types/http-errors': 2.0.5
      '@types/node': 25.6.0
+      '@types/send': 0.17.6

  '@types/statuses@2.0.6': {}
Author	SHA1	Message	Date
david	7555d3f1ff	Peueños errores	2026-04-15 12:23:59 +02:00
david	71b4dc1d06	.	2026-04-15 11:30:55 +02:00