modules/customer-invoices/src/common/locales/en.json

@@ -128,9 +128,9 @@
         "title": "Customer invoices",
         "description": "List all customer invoices",
         "grid_columns": {
-          "series_invoice_number": "#",
+          "series_invoice_number": "Serie & #",
           "verifactu_status": "Status",
-          "verifactu_qr_code": "QR",
+          "verifactu_qr_code": "QR Code",
           "verifactu_url": "URL",
           "invoice_number": "Inv. number",
           "series": "Serie",

modules/customer-invoices/src/common/locales/es.json

@@ -128,9 +128,9 @@
         "title": "Facturas de cliente",
         "description": "Lista todas las facturas de cliente",
         "grid_columns": {
-          "series_invoice_number": "#",
+          "series_invoice_number": "Serie & #",
           "verifactu_status": "Estado",
-          "verifactu_qr_code": "QR",
+          "verifactu_qr_code": "Código QR",
           "verifactu_url": "URL",
           "invoice_number": "Nº factura",
           "series": "Serie",

modules/customer-invoices/src/web/issued-invoices/pages/list/hooks/use-issued-invoices-grid-columns.tsx

@@ -50,9 +50,9 @@ export function useIssuedInvoicesGridColumns(
         ),
         enableHiding: false,
         enableSorting: false,
-        maxSize: 96,
+        maxSize: 64,
-        size: 96,
+        size: 64,
-        minSize: 96,
+        minSize: 64,
         meta: {
           title: t("pages.issued_invoices.list.grid_columns.series_invoice_number"),
         },

modules/customer-invoices/src/web/proformas/change-status/controllers/use-change-status-dialog-controller.ts

@@ -11,7 +11,7 @@ interface ChangeStatusDialogState {
 }
 
 export function useChangeStatusDialogController() {
-  const { changeStatus, isPending } = useChangeProformaStatus();
+  const { changeStatus } = useChangeProformaStatus();
 
   const [state, setState] = React.useState<ChangeStatusDialogState>({
     open: false,
@@ -31,6 +31,10 @@ export function useChangeStatusDialogController() {
     setState((s) => ({ ...s, open: false }));
   };
 
+  const setTargetStatus = (status: string | null) => {
+    setState((s) => ({ ...s, targetStatus: status }));
+  };
+
   const confirmChangeStatus = async (status: PROFORMA_STATUS) => {
     if (!state.proformas.length) return;
 

modules/customer-invoices/src/web/proformas/issue-proforma/api/issue-proforma-invoice.api.ts

@@ -1,6 +1,6 @@
 import type { IDataSource } from "@erp/core/client";
 
-export interface IssueProformaInvoiceResponse {
+export interface IssueInvoiceResponse {
   invoiceId: string;
   proformaId: string;
   customerId: string;
@@ -9,8 +9,8 @@ export interface IssueProformaInvoiceResponse {
 export async function issueProformaInvoiceApi(
   dataSource: IDataSource,
   proformaId: string
-): Promise<IssueProformaInvoiceResponse> {
+): Promise<IssueInvoiceResponse> {
-  return dataSource.custom<IssueProformaInvoiceResponse>({
+  return dataSource.custom<IssueInvoiceResponse>({
     path: `proformas/${proformaId}/issue`,
     method: "put",
     data: {},

modules/customer-invoices/src/web/proformas/issue-proforma/controllers/use-issue-proforma-dialog.controller.ts

@@ -1,4 +1,3 @@
-import { showErrorToast, showSuccessToast } from "@repo/rdx-ui/helpers";
 import * as React from "react";
 
 import type { ProformaSummaryData } from "../../types";
@@ -7,21 +6,19 @@ import { useIssueProformaMutation } from "../hooks/use-issue-proforma-mutation";
 interface State {
   open: boolean;
   proforma: ProformaSummaryData | null;
-  loading: boolean;
 }
 
 export function useProformaIssueDialogController() {
-  const { issueProforma, isPending } = useIssueProformaMutation();
+  const { mutate, isPending } = useIssueProformaMutation();
 
   const [state, setState] = React.useState<State>({
     open: false,
     proforma: null,
-    loading: false,
   });
 
   // abrir diálogo
-  const openDialog = (proforma: ProformaSummaryData) => {
+  const openDialog = (p: ProformaSummaryData) => {
-    setState({ open: true, proforma: proforma, loading: false });
+    setState({ open: true, proforma: p });
   };
 
   // cerrar diálogo
@@ -30,23 +27,17 @@ export function useProformaIssueDialogController() {
   };
 
   // confirmar emisión
-  const confirmIssue = async () => {
+  const confirmIssue = () => {
     if (!state.proforma) return;
 
-    setState((s) => ({ ...s, loading: true }));
+    mutate(
-
+      { proformaId: state.proforma.id },
-    await issueProforma(state.proforma.id, {
+      {
-      onSuccess: () => {
+        onSuccess() {
-        showSuccessToast("Proforma emitida a factura");
+          closeDialog();
-      },
+        },
-      onError: (err: unknown) => {
+      }
-        const error = err as Error;
+    );
-        showErrorToast("Error al emitir la proforma a factura", error.message);
-      },
-    });
-
-    setState((s) => ({ ...s, loading: false }));
-    closeDialog();
   };
 
   return {

modules/customer-invoices/src/web/proformas/issue-proforma/hooks/index.ts

@@ -1 +0,0 @@
-export * from "./use-issue-proforma-mutation";

modules/customer-invoices/src/web/proformas/issue-proforma/hooks/use-issue-proforma-mutation.ts

@@ -1,24 +1,24 @@
 import { useDataSource } from "@erp/core/hooks";
-import { type DefaultError, useMutation, useQueryClient } from "@tanstack/react-query";
+import { useMutation, useQueryClient } from "@tanstack/react-query";
 
-import { type IssueProformaInvoiceResponse, issueProformaInvoiceApi } from "../api";
+import { issueProformaInvoiceApi } from "../api";
 
 interface IssueProformaPayload {
   proformaId: string;
 }
 
-interface IssueProformaOptions {
+interface IssueProformaResponse {
-  onSuccess?: () => void;
+  proformaId: string;
-  onError?: (err: unknown) => void;
+  success: boolean;
-  onLoadingChange?: (loading: boolean) => void;
 }
 
 export function useIssueProformaMutation() {
   const dataSource = useDataSource();
   const queryClient = useQueryClient();
 
-  const mutation = useMutation<IssueProformaInvoiceResponse, DefaultError, IssueProformaPayload>({
+  return useMutation({
-    mutationFn: ({ proformaId }) => issueProformaInvoiceApi(dataSource, proformaId),
+    mutationFn: ({ proformaId }: IssueProformaPayload) =>
+      issueProformaInvoiceApi(dataSource, proformaId),
 
     onSuccess(_data, _vars, _ctx) {
       // Refresca el listado de proformas
@@ -28,21 +28,4 @@ export function useIssueProformaMutation() {
       queryClient.invalidateQueries({ queryKey: ["invoices"] });
     },
   });
-
-  async function issueProforma(proformaId: string, opts?: IssueProformaOptions) {
-    try {
-      opts?.onLoadingChange?.(true);
-      await mutation.mutateAsync({ proformaId });
-      opts?.onSuccess?.();
-    } catch (err) {
-      opts?.onError?.(err);
-    } finally {
-      opts?.onLoadingChange?.(false);
-    }
-  }
-
-  return {
-    issueProforma,
-    isPending: mutation.isPending,
-  };
 }

modules/customer-invoices/src/web/proformas/issue-proforma/ui/issue-proforma-dialog.tsx

@@ -9,40 +9,31 @@ import {
   Spinner,
 } from "@repo/shadcn-ui/components";
 
-import { useTranslation } from "../../../i18n";
+import { useProformaIssueDialogController } from "../controllers";
-import type { ProformaSummaryData } from "../../types";
 
 interface ProformaIssueDialogProps {
   open: boolean;
   onOpenChange: (open: boolean) => void;
-  proforma: ProformaSummaryData | null;
+  proformaId: string;
-  isSubmitting: boolean;
+  proformaReference: string;
-  onConfirm: (proforma?: ProformaSummaryData) => void;
 }
 
 export function ProformaIssueDialog({
   open,
   onOpenChange,
-  proforma,
+  proformaId,
-  isSubmitting,
+  proformaReference,
-  onConfirm,
 }: ProformaIssueDialogProps) {
-  const { t } = useTranslation();
+  const { issue, isSubmitting } = useProformaIssueDialogController();
 
   return (
     <AlertDialog onOpenChange={onOpenChange} open={open}>
       <AlertDialogContent>
         <AlertDialogHeader>
-          <AlertDialogTitle>Emitir a factura</AlertDialogTitle>
+          <AlertDialogTitle>Emitir factura</AlertDialogTitle>
-          <AlertDialogDescription className="space-y-4">
+          <AlertDialogDescription>
-            <p>
+            ¿Seguro que quieres emitir la factura desde la proforma{" "}
-              ¿Seguro que quieres emitir la factura desde la proforma{" "}
+            <strong>{proformaReference}</strong>? Esta acción es irreversible.
-              <strong>{proforma?.reference}</strong>?
-            </p>
-            <p>
-              Esta acción creará una nueva factura definitiva y la proforma pasará al estado
-              "Emitida", no pudiendo modificarse ni eliminarse posteriormente.
-            </p>
           </AlertDialogDescription>
         </AlertDialogHeader>
 
@@ -51,14 +42,17 @@ export function ProformaIssueDialog({
             Cancelar
           </Button>
 
-          <Button disabled={isSubmitting} onClick={() => onConfirm(proforma)}>
+          <Button
+            disabled={isSubmitting}
+            onClick={() => issue(proformaId, () => onOpenChange(false))}
+          >
             {isSubmitting ? (
               <>
                 <Spinner className="mr-2 size-4" />
                 Emitiendo...
               </>
             ) : (
-              <>Emitir factura</>
+              "Emitir factura"
             )}
           </Button>
         </AlertDialogFooter>

modules/customer-invoices/src/web/proformas/list/ui/blocks/proformas-grid/use-proforma-grid-columns.tsx

@@ -93,18 +93,13 @@ export function useProformasGridColumns(
               <ProformaStatusBadge status={proforma.status} />
 
               {/* Enlace discreto a factura real */}
-              {isIssued && (
+              {isIssued && invoiceId && (
                 <TooltipProvider>
                   <Tooltip>
                     <TooltipTrigger asChild>
-                      <Button
+                      <Button asChild className="size-6" size="icon" variant="ghost">
-                        asChild
-                        className="size-6 text-foreground hover:text-primary"
-                        size="icon"
-                        variant="ghost"
-                      >
                         <a href={`/facturas/${invoiceId}`}>
-                          <ExternalLinkIcon />
+                          <ExternalLinkIcon className="size-3 text-muted-foreground" />
                           <span className="sr-only">Ver factura {invoiceId}</span>
                         </a>
                       </Button>

modules/customer-invoices/src/web/proformas/list/ui/pages/proforma-list-page.tsx

@@ -121,7 +121,8 @@ export const ProformaListPage = () => {
           onConfirm={issueDialogCtrl.confirmIssue}
           onOpenChange={(open) => !open && issueDialogCtrl.closeDialog()}
           open={issueDialogCtrl.open}
-          proforma={issueDialogCtrl.proforma}
+          proformaId={issueDialogCtrl.proforma?.id ?? 0}
+          proformaReference={issueDialogCtrl.proforma?.reference ?? ""}
         />
 
         {/* Cambiar estado */}
@@ -140,7 +141,6 @@ export const ProformaListPage = () => {
           onOpenChange={(open) => !open && deleteDialogCtrl.closeDialog()}
           open={deleteDialogCtrl.open}
           proformas={deleteDialogCtrl.proformas}
-          requireSecondConfirm={true}
         />
       </AppContent>
     </>