modules/catalogs/src/api/application/payment-methods/models/payment-method-detail.model.ts

@@ -1,11 +1,8 @@
-import type { Name, TextValue, UniqueID } from "@repo/rdx-ddd";
-import type { Maybe } from "@repo/rdx-utils";
-
 export type PaymentMethodDetail = {
-  id: UniqueID;
-  companyId: UniqueID;
-  name: Name;
-  description: Maybe<TextValue>;
+  id: string;
+  name: string;
+  type: string;
   is_active: boolean;
-  is_system: boolean;
+  created_at: string;
+  updated_at: string;
 };

modules/catalogs/src/api/application/payment-methods/snapshot-builders/full/payment-method-full-snapshot-builder.ts

@@ -1,23 +1,19 @@
 import type { GetPaymentMethodByIdResponseDTO } from "@erp/catalogs/common";
 import type { ISnapshotBuilder } from "@erp/core/api";
-import { maybeToNullable } from "@repo/rdx-ddd";
+import { toNullable } from "@repo/rdx-ddd";
 
 import type { PaymentMethod } from "../../../../domain";
 
-export type PaymentMethodFullSnapshot = GetPaymentMethodByIdResponseDTO;
-
 export interface IPaymentMethodFullSnapshotBuilder
-  extends ISnapshotBuilder<PaymentMethod, PaymentMethodFullSnapshot> {}
+  extends ISnapshotBuilder<PaymentMethod, GetPaymentMethodByIdResponseDTO> {}
 
 export class PaymentMethodFullSnapshotBuilder implements IPaymentMethodFullSnapshotBuilder {
-  public toOutput(paymentMethod: PaymentMethod): PaymentMethodFullSnapshot {
+  public toOutput(paymentMethod: PaymentMethod): GetPaymentMethodByIdResponseDTO {
     return {
       id: paymentMethod.id.toPrimitive(),
       company_id: paymentMethod.companyId.toPrimitive(),
-
       name: paymentMethod.name.toPrimitive(),
-      description: maybeToNullable(paymentMethod.description, (value) => value.toPrimitive()),
-
+      description: toNullable(paymentMethod.description, (value) => value.toPrimitive()),
       is_active: paymentMethod.isActive,
       is_system: paymentMethod.isSystem,
     };

modules/catalogs/src/api/application/payment-methods/snapshot-builders/summary/payment-method-summary-snapshot-builder.ts

@@ -11,9 +11,7 @@ export class PaymentMethodSummarySnapshotBuilder implements IPaymentMethodSummar
     return {
       id: paymentMethod.id.toString(),
       company_id: paymentMethod.companyId.toString(),
-
       name: paymentMethod.name.toString(),
-
       is_system: paymentMethod.isSystem,
       is_active: paymentMethod.isActive,
     };

modules/catalogs/src/common/dto/payment-methods/index.ts

@@ -1,3 +1,2 @@
 export * from "./request";
 export * from "./response";
-export * from "./shared";

modules/customer-invoices/src/web/proformas/update/ui/pages/proforma-update-page.tsx

@@ -1,3 +1,4 @@
+import { SpainTaxCatalogProvider } from "@erp/core";
 import { ErrorAlert, NotFoundCard, PageHeader } from "@erp/core/components";
 import {
   FormCommitButtonGroup,
@@ -6,6 +7,7 @@ import {
 } from "@erp/core/hooks";
 import { SelectCustomerDialog } from "@erp/customers";
 import { AppContent, AppHeader, BackHistoryButton } from "@repo/rdx-ui/components";
+import { useMemo } from "react";
 import { FormProvider } from "react-hook-form";
 
 import { useTranslation } from "../../../../i18n";
@@ -15,6 +17,7 @@ import { ProformaUpdateEditorForm } from "../editors";
 
 export const ProformaUpdatePage = () => {
   const { t } = useTranslation();
+  const taxCatalog = useMemo(() => SpainTaxCatalogProvider(), []);
 
   const { updateCtrl, selectCustomerCtrl, returnTo } = useUpdateProformaPageController();
 

modules/customers/src/web/create/ui/pages/customer-create-page.tsx

@@ -16,44 +16,44 @@ export const CustomerCreatePage = () => {
   const { form, formId, onSubmit, resetForm, isCreating, isCreateError, createError } = createCtrl;
 
   return (
-    <FormProvider {...form}>
-      <UnsavedChangesProvider isDirty={form.formState.isDirty}>
-        <AppHeader className="mx-auto max-w-7xl space-y-4">
-          <PageHeader
-            description={t("pages.create.description")}
-            onBackClick={() => navigate("/customers/list")}
-            rightSlot={
-              <FormCommitButtonGroup
-                cancel={{
-                  to: "/customers/list",
-                }}
-                disabled={createCtrl.isCreating}
-                isLoading={createCtrl.isCreating}
-                onReset={createCtrl.form.formState.isDirty ? createCtrl.resetForm : undefined}
-                submit={{
-                  formId: createCtrl.formId,
-                }}
-              />
-            }
-            title={t("pages.create.title")}
-          />
-        </AppHeader>
-
-        <AppContent className="mx-auto max-w-7xl space-y-4">
-          {isCreateError && (
-            <ErrorAlert
-              message={(createError as Error)?.message ?? t("pages.create.errorMsg")}
-              title={t("pages.create.errorTitle")}
+    <UnsavedChangesProvider isDirty={form.formState.isDirty}>
+      <AppHeader>
+        <PageHeader
+          description={t("pages.create.description")}
+          onBackClick={() => navigate("/customers/list")}
+          rightSlot={
+            <FormCommitButtonGroup
+              cancel={{
+                to: "/customers/list",
+              }}
+              disabled={createCtrl.isCreating}
+              isLoading={createCtrl.isCreating}
+              onReset={createCtrl.form.formState.isDirty ? createCtrl.resetForm : undefined}
+              submit={{
+                formId: createCtrl.formId,
+              }}
             />
-          )}
+          }
+          title={t("pages.create.title")}
+        />
+      </AppHeader>
 
+      <AppContent>
+        {isCreateError && (
+          <ErrorAlert
+            message={(createError as Error)?.message ?? t("pages.create.errorMsg")}
+            title={t("pages.create.errorTitle")}
+          />
+        )}
+
+        <FormProvider {...form}>
           <CustomerCreateEditorForm
             className="bg-white rounded-xl border shadow-xl max-w-7xl mx-auto mt-6"
             formId={formId}
             onSubmit={onSubmit}
           />
-        </AppContent>
-      </UnsavedChangesProvider>
-    </FormProvider>
+        </FormProvider>
+      </AppContent>
+    </UnsavedChangesProvider>
   );
 };