modules/customer-invoices/src/api/application/proformas/di/proforma-use-cases.di.ts

@@ -98,7 +98,6 @@ export function buildPreviewProformaReportUseCase(deps: {
 
 export function buildCreateProformaUseCase(deps: {
   creator: IProformaCreator;
-  finder: IProformaFinder;
   dtoMapper: ICreateProformaInputMapper;
   fullReadModelAssembler: IProformaFullReadModelAssembler;
   fullSnapshotBuilder: IProformaFullSnapshotBuilder;
@@ -107,7 +106,6 @@ export function buildCreateProformaUseCase(deps: {
   return new CreateProformaUseCase({
     dtoMapper: deps.dtoMapper,
     creator: deps.creator,
-    finder: deps.finder,
     fullReadModelAssembler: deps.fullReadModelAssembler,
     fullSnapshotBuilder: deps.fullSnapshotBuilder,
     transactionManager: deps.transactionManager,

modules/customer-invoices/src/api/application/proformas/use-cases/create-proforma.use-case.ts

@@ -4,11 +4,7 @@ import { Result } from "@repo/rdx-utils";
 
 import type { CreateProformaRequestDTO } from "../../../../common";
 import type { ICreateProformaInputMapper } from "../mappers";
-import type {
+import type { IProformaCreator, IProformaFullReadModelAssembler } from "../services";
-  IProformaCreator,
-  IProformaFinder,
-  IProformaFullReadModelAssembler,
-} from "../services";
 import type { IProformaFullSnapshotBuilder } from "../snapshot-builders";
 
 type CreateProformaUseCaseInput = {
@@ -21,7 +17,6 @@ export class CreateProformaUseCase {
     private readonly deps: {
       dtoMapper: ICreateProformaInputMapper;
       creator: IProformaCreator;
-      finder: IProformaFinder;
       fullReadModelAssembler: IProformaFullReadModelAssembler;
       fullSnapshotBuilder: IProformaFullSnapshotBuilder;
       transactionManager: ITransactionManager;
@@ -47,19 +42,9 @@ export class CreateProformaUseCase {
           return Result.fail(createResult.error);
         }
 
-        const proformaResult = await this.deps.finder.findProformaById(
-          companyId,
-          createResult.data.id,
-          transaction
-        );
-
-        if (proformaResult.isFailure) {
-          return Result.fail(proformaResult.error);
-        }
-
         const readModelResult = await this.deps.fullReadModelAssembler.assemble({
           companyId,
-          proforma: proformaResult.data,
+          proforma: createResult.data,
           transaction,
         });
 

modules/customer-invoices/src/api/infrastructure/proformas/di/proformas.di.ts

@@ -1,6 +1,6 @@
 import { type ModuleParams, buildTransactionManager } from "@erp/core/api";
-
 import type { ICompanyPublicServices } from "../../../../../../companies/src/api";
+
 import {
   type ChangeStatusProformaUseCase,
   type CreateProformaUseCase,
@@ -31,8 +31,8 @@ import {
   buildReportProformaPdfUseCase,
   buildUpdateProformaUseCase,
 } from "../../../application";
-import { CompanyReportProfileFinder } from "../adapters/company-report-profile-finder";
 
+import { CompanyReportProfileFinder } from "../adapters/company-report-profile-finder";
 import { buildProformaDocumentServices } from "./proforma-documents.di";
 import { buildProformaNumberGenerator } from "./proforma-number-generator.di";
 import { buildProformaPersistenceMappers } from "./proforma-persistence-mappers.di";
@@ -144,7 +144,6 @@ export function buildProformasDependencies(params: ModuleParams): ProformasInter
       createProforma: () =>
         buildCreateProformaUseCase({
           creator,
-          finder,
           dtoMapper: inputMappers.createInputMapper,
           fullReadModelAssembler: readModelAssemblers.full,
           fullSnapshotBuilder: snapshotBuilders.full,

modules/customer-invoices/src/web/proformas/update/ui/editors/proforma-update-header-editor.tsx

@@ -68,7 +68,6 @@ export const ProformaUpdateHeaderEditor = ({
           name="series"
           placeholder={t("form_fields.proformas.series.placeholder")}
           readOnly={readOnly}
-          required
         />
 
         <DatePickerField