modules/core/src/common/helpers/number-helper.ts

@@ -1,5 +1,5 @@
-const toSafeNumber = (value: string | number | null | undefined): number => {
+const toSafeNumber = (value: number | null | undefined): number => {
-  return Number(value ?? 0);
+  return value ?? 0;
 };
 
 export const NumberHelper = {

modules/core/src/web/lib/helpers/form-utils.ts

@@ -1,54 +1,28 @@
-type PickFormDirtyValuesOptions<T extends Record<string, any>> = {
-  replaceTopLevelArrayKeys?: Array<keyof T>;
-};
-
 /**
  * Extrae solo los valores marcados como "dirty" por react-hook-form,
  * respetando la estructura anidada de dirtyFields.
- *
- * Regla especial opcional: Si una key de primer nivel
- * está configurada en `replaceTopLevelArrayKeys` y tiene
- * cualquier dirty anidado, se incluye el array completo
- * en lugar de intentar hacer patch recursivo
  */
 export function pickFormDirtyValues<T extends Record<string, any>>(
   values: T,
-  dirtyFields: Partial<Record<keyof T, any>>,
+  dirtyFields: Partial<Record<keyof T, any>>
-  options?: PickFormDirtyValuesOptions<T>
 ): Partial<T> {
   const result: Partial<T> = {};
-  const replaceTopLevelArrayKeys = options?.replaceTopLevelArrayKeys ?? [];
 
   for (const key in dirtyFields) {
     if (!Object.hasOwn(dirtyFields, key)) continue;
 
-    const typedKey = key as keyof T;
+    const isDirty = dirtyFields[key];
-    const isDirty = dirtyFields[typedKey];
+    const value = values[key];
-    const value = values[typedKey];
 
     if (isDirty === true) {
-      result[typedKey] = value;
+      // 🔹 Campo "leaf": se ha tocado → copiar valor
-      continue;
+      result[key] = value;
-    }
+    } else if (typeof isDirty === "object" && isDirty !== null) {
-
+      // 🔹 Campo anidado: recursión
-    if (typeof isDirty !== "object" || isDirty === null) {
+      const nested = pickFormDirtyValues(value, isDirty);
-      continue;
-    }
-
-    const shouldReplaceTopLevelArray =
-      replaceTopLevelArrayKeys.includes(typedKey) &&
-      Array.isArray(value) &&
-      formHasAnyDirty(isDirty);
-
-    if (shouldReplaceTopLevelArray) {
-      result[typedKey] = value;
-      continue;
-    }
-
-    const nested = pickFormDirtyValues(value, isDirty as Partial<Record<keyof typeof value, any>>);
-
       if (Object.keys(nested).length > 0) {
-      result[typedKey] = nested as T[keyof T];
+        result[key] = nested as any;
+      }
     }
   }
 
@@ -63,7 +37,7 @@ export function formHasAnyDirty(dirtyFields: Partial<Record<string, any>> | bool
   if (dirtyFields === false || dirtyFields == null) return false;
 
   if (typeof dirtyFields === "object") {
-    return Object.values(dirtyFields).some((value) => formHasAnyDirty(value));
+    return Object.values(dirtyFields).some((v) => formHasAnyDirty(v));
   }
 
   return false;

modules/customer-invoices/src/api/application/proformas/di/proforma-input-mappers.di.ts

@@ -3,12 +3,13 @@ import type { ICatalogs } from "@erp/core/api";
 import {
   CreateProformaInputMapper,
   type ICreateProformaInputMapper,
+  type IUpdateProformaInputMapper,
   UpdateProformaInputMapper,
 } from "../mappers";
 
 export interface IProformaInputMappers {
   createInputMapper: ICreateProformaInputMapper;
-  updateInputMapper: UpdateProformaInputMapper;
+  updateInputMapper: IUpdateProformaInputMapper;
 }
 
 export const buildProformaInputMappers = (catalogs: ICatalogs): IProformaInputMappers => {

modules/customer-invoices/src/api/application/proformas/di/proforma-use-cases.di.ts

@@ -1,7 +1,7 @@
 import type { ITransactionManager } from "@erp/core/api";
 
 import type { IIssuedInvoicePublicServices } from "../../issued-invoices";
-import type { ICreateProformaInputMapper, UpdateProformaInputMapper } from "../mappers";
+import type { ICreateProformaInputMapper, IUpdateProformaInputMapper } from "../mappers";
 import type {
   IProformaCreator,
   IProformaFinder,
@@ -97,7 +97,7 @@ export function buildIssueProformaUseCase(deps: {
 
 export function buildUpdateProformaUseCase(deps: {
   updater: IProformaUpdater;
-  dtoMapper: UpdateProformaInputMapper;
+  dtoMapper: IUpdateProformaInputMapper;
   fullSnapshotBuilder: IProformaFullSnapshotBuilder;
   transactionManager: ITransactionManager;
 }) {

modules/customer-invoices/src/api/application/proformas/mappers/update-proforma-input.mapper.ts

@@ -1,5 +1,3 @@
-import { NumberHelper } from "@erp/core";
-import { DiscountPercentage } from "@erp/core/api";
 import {
   CurrencyCode,
   DomainError,
@@ -15,14 +13,7 @@ import {
 import { Result, isNullishOrEmpty, toPatchField } from "@repo/rdx-utils";
 
 import type { UpdateProformaByIdRequestDTO } from "../../../../common/dto";
-import {
+import { InvoiceSerie, type ProformaPatchProps } from "../../../domain";
-  InvoiceSerie,
-  ItemAmount,
-  ItemDescription,
-  ItemQuantity,
-  type ProformaItemPatchProps,
-  type ProformaPatchProps,
-} from "../../../domain";
 
 /**
  * UpdateProformaPropsMapper
@@ -46,10 +37,7 @@ export interface IUpdateProformaInputMapper {
 }
 
 export class UpdateProformaInputMapper implements IUpdateProformaInputMapper {
-  public map(
+  public map(dto: UpdateProformaByIdRequestDTO, params: { companyId: UniqueID }) {
-    dto: UpdateProformaByIdRequestDTO,
-    params: { companyId: UniqueID }
-  ): Result<ProformaPatchProps> {
     try {
       const errors: ValidationErrorDetail[] = [];
       const props: ProformaPatchProps = {};
@@ -140,149 +128,15 @@ export class UpdateProformaInputMapper implements IUpdateProformaInputMapper {
         );
       });
 
-      if (dto.items) {
+      if (errors.length > 0) {
-        const itemsProps = this.mapItemsProps(dto, { errors });
+        return Result.fail(
-        props.items = itemsProps;
+          new ValidationErrorCollection("Proforma invoice props mapping failed (update)", errors)
+        );
       }
 
-      this.throwIfValidationErrors(errors);
-
       return Result.ok(props);
     } catch (err: unknown) {
-      return Result.fail(new DomainError("Proforma proforma props mapping failed", { cause: err }));
+      return Result.fail(new DomainError("Proforma invoice props mapping failed", { cause: err }));
     }
   }
-
-  private throwIfValidationErrors(errors: ValidationErrorDetail[]): void {
-    if (errors.length > 0) {
-      throw new ValidationErrorCollection("Customer proforma props mapping failed", errors);
-    }
-  }
-
-  private mapItemsProps(
-    dto: UpdateProformaByIdRequestDTO,
-    params: {
-      errors: ValidationErrorDetail[];
-    }
-  ): ProformaItemPatchProps[] {
-    const itemsProps: ProformaItemPatchProps[] = [];
-
-    dto.items?.forEach((item, index) => {
-      const description = extractOrPushError(
-        maybeFromNullableResult(item.description, (v) => ItemDescription.create(v)),
-        `items[${index}].description`,
-        params.errors
-      );
-
-      const quantity = extractOrPushError(
-        maybeFromNullableResult(item.quantity, (v) =>
-          ItemQuantity.create({ value: NumberHelper.toSafeNumber(v) })
-        ),
-        `items[${index}].quantity`,
-        params.errors
-      );
-
-      const unitAmount = extractOrPushError(
-        maybeFromNullableResult(item.unit_amount, (v) =>
-          ItemAmount.create({ value: NumberHelper.toSafeNumber(v) })
-        ),
-        `items[${index}].unit_amount`,
-        params.errors
-      );
-
-      const discountPercentage = extractOrPushError(
-        maybeFromNullableResult(item.item_discount_percentage, (v) =>
-          DiscountPercentage.create({ value: NumberHelper.toSafeNumber(v.value) })
-        ),
-        `items[${index}].discount_percentage`,
-        params.errors
-      );
-
-      /*const taxes = this.mapTaxesProps(item.taxes, {
-        itemIndex: index,
-        errors: params.errors,
-      });*/
-
-      this.throwIfValidationErrors(params.errors);
-
-      itemsProps.push({
-        description: description!,
-        quantity: quantity!,
-        unitAmount: unitAmount!,
-        itemDiscountPercentage: discountPercentage!,
-        //taxes,
-      });
-    });
-
-    return itemsProps;
-  }
-
-  /* Devuelve las propiedades de los impustos de una línea de detalle */
-
-  /*private mapTaxesProps(
-    taxesDTO: Pick<ProformaItemRequestDTO, "taxes">["taxes"],
-    params: { itemIndex: number; errors: ValidationErrorDetail[] }
-  ): ProformaItemTaxesProps {
-    const { itemIndex, errors } = params;
-
-    const taxesProps: ProformaItemTaxesProps = {
-      iva: Maybe.none(),
-      retention: Maybe.none(),
-      rec: Maybe.none(),
-    };
-
-    // Normaliza: "" -> []
-    const taxStrCodes = taxesDTO
-      .split(",")
-      .map((s) => s.trim())
-      .filter((s) => s.length > 0);
-
-    taxStrCodes.forEach((strCode, taxIndex) => {
-      const taxResult = Tax.createFromCode(strCode, this.taxCatalog);
-
-      if (!taxResult.isSuccess) {
-        errors.push({
-          path: `items[${itemIndex}].taxes[${taxIndex}]`,
-          message: taxResult.error.message,
-        });
-        return;
-      }
-
-      const tax = taxResult.data;
-
-      if (tax.isVATLike()) {
-        if (taxesProps.iva.isSome()) {
-          errors.push({
-            path: `items[${itemIndex}].taxes`,
-            message: "Multiple taxes for group VAT are not allowed",
-          });
-        }
-        taxesProps.iva = Maybe.some(tax);
-      }
-
-      if (tax.isRetention()) {
-        if (taxesProps.retention.isSome()) {
-          errors.push({
-            path: `items[${itemIndex}].taxes`,
-            message: "Multiple taxes for group retention are not allowed",
-          });
-        }
-        taxesProps.retention = Maybe.some(tax);
-      }
-
-      if (tax.isRec()) {
-        if (taxesProps.rec.isSome()) {
-          errors.push({
-            path: `items[${itemIndex}].taxes`,
-            message: "Multiple taxes for group rec are not allowed",
-          });
-        }
-        taxesProps.rec = Maybe.some(tax);
-      }
-    });
-
-    this.throwIfValidationErrors(errors);
-
-    return taxesProps;
-  }*/
 }

modules/customer-invoices/src/api/application/proformas/services/proforma-creator.ts

@@ -1,7 +1,7 @@
 import type { UniqueID } from "@repo/rdx-ddd";
 import { Result } from "@repo/rdx-utils";
 
-import { Proforma, type ProformaCreateProps } from "../../../domain";
+import { type IProformaCreateProps, Proforma } from "../../../domain";
 import type { IProformaRepository } from "../repositories";
 
 import type { IProformaNumberGenerator } from "./proforma-number-generator.interface";
@@ -9,7 +9,7 @@ import type { IProformaNumberGenerator } from "./proforma-number-generator.inter
 export interface IProformaCreatorParams {
   companyId: UniqueID;
   id: UniqueID;
-  props: Omit<ProformaCreateProps, "invoiceNumber">;
+  props: Omit<IProformaCreateProps, "invoiceNumber">;
   transaction: unknown;
 }
 

modules/customer-invoices/src/api/application/proformas/services/proforma-updater.ts

@@ -8,7 +8,7 @@ export interface IProformaUpdater {
   update(params: {
     companyId: UniqueID;
     id: UniqueID;
-    patchProps: ProformaPatchProps;
+    props: ProformaPatchProps;
     transaction: unknown;
   }): Promise<Result<Proforma, Error>>;
 }
@@ -27,12 +27,12 @@ export class ProformaUpdater implements IProformaUpdater {
   async update(params: {
     companyId: UniqueID;
     id: UniqueID;
-    patchProps: ProformaPatchProps;
+    props: ProformaPatchProps;
     transaction: unknown;
   }): Promise<Result<Proforma, Error>> {
-    const { companyId, id, patchProps, transaction } = params;
+    const { companyId, id, props, transaction } = params;
 
-    console.log("patchProps => ", patchProps);
+    console.log("props => ", props);
 
     // Recuperar agregado existente
     const existingResult = await this.repository.getByIdInCompany(companyId, id, transaction);
@@ -44,12 +44,14 @@ export class ProformaUpdater implements IProformaUpdater {
     const proforma = existingResult.data;
 
     // Aplicar cambios en el agregado
-    const updateResult = proforma.update(patchProps);
+    const updateResult = proforma.update(props);
 
     if (updateResult.isFailure) {
       return Result.fail(updateResult.error);
     }
 
+    console.log(proforma.operationDate);
+
     // Persistir cambios
     const saveResult = await this.repository.update(proforma, transaction);
 

modules/customer-invoices/src/api/application/proformas/use-cases/update-proforma.use-case.ts

@@ -4,7 +4,7 @@ import { Result } from "@repo/rdx-utils";
 
 import type { UpdateProformaByIdRequestDTO } from "../../../../common";
 import type { ProformaPatchProps } from "../../../domain";
-import type { UpdateProformaInputMapper } from "../mappers";
+import type { IUpdateProformaInputMapper } from "../mappers";
 import type { IProformaUpdater } from "../services";
 import type { IProformaFullSnapshotBuilder } from "../snapshot-builders";
 
@@ -15,14 +15,14 @@ type UpdateProformaUseCaseInput = {
 };
 
 type UpdateProformaUseCaseDeps = {
-  dtoMapper: UpdateProformaInputMapper;
+  dtoMapper: IUpdateProformaInputMapper;
   updater: IProformaUpdater;
   fullSnapshotBuilder: IProformaFullSnapshotBuilder;
   transactionManager: ITransactionManager;
 };
 
 export class UpdateProformaUseCase {
-  private readonly dtoMapper: UpdateProformaInputMapper;
+  private readonly dtoMapper: IUpdateProformaInputMapper;
   private readonly updater: IProformaUpdater;
   private readonly fullSnapshotBuilder: IProformaFullSnapshotBuilder;
   private readonly transactionManager: ITransactionManager;
@@ -60,7 +60,7 @@ export class UpdateProformaUseCase {
         const updateResult = await this.updater.update({
           companyId,
           id: proformaId,
-          patchProps,
+          props: patchProps,
           transaction,
         });
 

modules/customer-invoices/src/api/domain/proformas/aggregates/proforma.aggregate.ts

@@ -24,7 +24,6 @@ import {
   type IProformaItemCreateProps,
   type IProformaItems,
   ProformaItem,
-  type ProformaItemPatchProps,
   ProformaItems,
 } from "../entities";
 import { ProformaItemMismatch } from "../errors";
@@ -57,10 +56,6 @@ export interface IProformaCreateProps {
   globalDiscountPercentage: DiscountPercentage;
 }
 
-export type ProformaPatchProps = Partial<Omit<IProformaCreateProps, "companyId" | "items">> & {
-  items?: ProformaItemPatchProps[];
-};
-
 export interface IProformaTotals {
   subtotalAmount: InvoiceAmount;
 
@@ -105,6 +100,10 @@ export interface IProforma {
   totals(): IProformaTotals;
 }
 
+export type ProformaPatchProps = Partial<Omit<IProformaCreateProps, "companyId" | "items">> & {
+  //items?: ProformaItems;
+};
+
 export type InternalProformaProps = Omit<IProformaCreateProps, "items">;
 
 export class Proforma extends AggregateRoot<InternalProformaProps> implements IProforma {
@@ -157,47 +156,9 @@ export class Proforma extends AggregateRoot<InternalProformaProps> implements IP
     return new Proforma(props, items, id);
   }
 
-  // Mutabilidad
+  private initializeItems(itemsProps: IProformaItemCreateProps[]): Result<void, Error> {
-  public update(patchProps: ProformaPatchProps): Result<Proforma, Error> {
-    const { items, ...otherProps } = patchProps;
-
-    const candidateProps: InternalProformaProps = {
-      ...this.props,
-      ...otherProps,
-    };
-
-    // Validacciones
-
-    // Aplicar cambios
-    Object.assign(this.props, candidateProps);
-
-    // Reemplazo de items (si se proporciona)
-    if (items) {
-      this.initializeItems(items);
-    }
-
-    return Result.ok();
-  }
-
-  private initializeItems(
-    itemsProps: IProformaItemCreateProps[] | ProformaItemPatchProps[]
-  ): Result<void, Error> {
-    this._items.reset();
-
     for (const [index, itemProps] of itemsProps.entries()) {
-      const { languageCode, currencyCode, globalDiscountPercentage, ...restProps } = {
+      const itemResult = ProformaItem.create(itemProps);
-        languageCode: this.languageCode,
-        currencyCode: this.currencyCode,
-        globalDiscountPercentage: this.globalDiscountPercentage,
-        ...itemProps,
-      };
-
-      const itemResult = ProformaItem.create({
-        ...restProps,
-        languageCode,
-        currencyCode,
-        globalDiscountPercentage,
-      });
 
       if (itemResult.isFailure) {
         return Result.fail(itemResult.error);
@@ -285,6 +246,20 @@ export class Proforma extends AggregateRoot<InternalProformaProps> implements IP
     return this.paymentMethod.isSome();
   }
 
+  // Mutabilidad
+  public update(patch: ProformaPatchProps): Result<Proforma, Error> {
+    const candidateProps: InternalProformaProps = {
+      ...this.props,
+      ...patch,
+    };
+
+    // Validacciones
+
+    Object.assign(this.props, candidateProps);
+
+    return Result.ok();
+  }
+
   public issue(): Result<void, Error> {
     if (!this.props.status.canTransitionTo("issued")) {
       return Result.fail(
@@ -299,6 +274,7 @@ export class Proforma extends AggregateRoot<InternalProformaProps> implements IP
     this.props.status = InvoiceStatus.issued();
     return Result.ok();
   }
+
   // Cálculos
 
   /**
@@ -350,6 +326,25 @@ export class Proforma extends AggregateRoot<InternalProformaProps> implements IP
     return Result.ok();
   }
 
+  /*public updateItem(itemId: UniqueID, props: IProformaItemProps): Result<void, Error> {
+    const item = this._items.find((i) => i.id.equals(itemId));
+    if (!item) {
+      return Result.fail(new Error("Item not found"));
+    }
+
+    return item.update(props);
+  }*/
+
+  /*public removeItem(itemId: UniqueID): Result<void, Error> {
+    const removed = this._items.removeWhere(i => i.id.equals(itemId));
+
+    if (!removed) {
+      return Result.fail(new Error("Item not found"));
+    }
+
+    return Result.ok();
+  }*/
+
   // Helpers
 
   /**

modules/customer-invoices/src/api/domain/proformas/entities/proforma-items/proforma-item.entity.ts

@@ -42,11 +42,6 @@ export interface IProformaItemCreateProps {
   currencyCode: CurrencyCode; // Para cálculos y formateos de moneda
 }
 
-export type ProformaItemPatchProps = Omit<
-  IProformaItemCreateProps,
-  "globalDiscountPercentage" | "languageCode" | "currencyCode"
->;
-
 export interface IProformaItemTotals {
   subtotalAmount: ItemAmount;
 

modules/customer-invoices/src/api/infrastructure/common/persistence/sequelize/mappers/domain/customer-invoice-item.mapper.ts

@@ -17,12 +17,12 @@ import {
 import { Result } from "@repo/rdx-utils";
 
 import {
+  type IProformaCreateProps,
   IssuedInvoiceItem,
   ItemAmount,
   ItemDescription,
   ItemQuantity,
   type Proforma,
-  type ProformaCreateProps,
 } from "../../../../../../domain";
 
 export interface ICustomerInvoiceItemDomainMapper
@@ -62,7 +62,7 @@ export class CustomerInvoiceItemDomainMapper
     const { errors, index, attributes } = params as {
       index: number;
       errors: ValidationErrorDetail[];
-      attributes: Partial<ProformaCreateProps>;
+      attributes: Partial<IProformaCreateProps>;
     };
 
     const itemId = extractOrPushError(
@@ -157,7 +157,7 @@ export class CustomerInvoiceItemDomainMapper
     const { errors, index } = params as {
       index: number;
       errors: ValidationErrorDetail[];
-      attributes: Partial<ProformaCreateProps>;
+      attributes: Partial<IProformaCreateProps>;
     };
 
     // 1) Valores escalares (atributos generales)

modules/customer-invoices/src/api/infrastructure/common/persistence/sequelize/mappers/domain/customer-invoice.mapper.ts

@@ -20,12 +20,12 @@ import { Maybe, Result, isNullishOrEmpty } from "@repo/rdx-utils";
 
 import {
   CustomerInvoiceItems,
+  type IProformaCreateProps,
   InvoiceNumber,
   InvoicePaymentMethod,
   InvoiceSerie,
   InvoiceStatus,
   Proforma,
-  type ProformaCreateProps,
 } from "../../../../../../domain";
 import type {
   CustomerInvoiceCreationAttributes,
@@ -249,7 +249,7 @@ export class CustomerInvoiceDomainMapper
         items: itemsResults.data.getAll(),
       });
 
-      const invoiceProps: ProformaCreateProps = {
+      const invoiceProps: IProformaCreateProps = {
         companyId: attributes.companyId!,
 
         isProforma: attributes.isProforma,

modules/customer-invoices/src/api/infrastructure/common/persistence/sequelize/mappers/domain/invoice-recipient.mapper.ts

@@ -16,9 +16,9 @@ import {
 import { Maybe, Result } from "@repo/rdx-utils";
 
 import {
+  type IProformaCreateProps,
   InvoiceRecipient,
   type Proforma,
-  type ProformaCreateProps,
 } from "../../../../../../domain";
 import type { CustomerInvoiceModel } from "../../../../sequelize";
 
@@ -34,7 +34,7 @@ export class InvoiceRecipientDomainMapper {
 
     const { errors, attributes } = params as {
       errors: ValidationErrorDetail[];
-      attributes: Partial<ProformaCreateProps>;
+      attributes: Partial<IProformaCreateProps>;
     };
 
     const { isProforma } = attributes;

modules/customer-invoices/src/api/infrastructure/common/persistence/sequelize/mappers/domain/invoice-verifactu.mapper.ts

@@ -12,8 +12,8 @@ import {
 import { Maybe, Result } from "@repo/rdx-utils";
 
 import {
+  type IProformaCreateProps,
   type Proforma,
-  type ProformaCreateProps,
   VerifactuRecord,
   VerifactuRecordEstado,
 } from "../../../../../../domain";
@@ -43,7 +43,7 @@ export class CustomerInvoiceVerifactuDomainMapper
   ): Result<Maybe<VerifactuRecord>, Error> {
     const { errors, attributes } = params as {
       errors: ValidationErrorDetail[];
-      attributes: Partial<ProformaCreateProps>;
+      attributes: Partial<IProformaCreateProps>;
     };
 
     if (!source) {

modules/customer-invoices/src/api/infrastructure/proformas/express/mappers/create-proforma-request-mapper.ts

@@ -17,6 +17,7 @@ import { Maybe, Result } from "@repo/rdx-utils";
 
 import type { CreateProformaItemRequestDTO, CreateProformaRequestDTO } from "../../../../../common";
 import {
+  type IProformaCreateProps,
   type IProformaItemCreateProps,
   InvoiceNumber,
   InvoicePaymentMethod,
@@ -28,7 +29,6 @@ import {
   ItemAmount,
   ItemDescription,
   ItemQuantity,
-  type ProformaCreateProps,
 } from "../../../../domain";
 
 /**
@@ -149,7 +149,7 @@ export class CreateProformaRequestMapper {
         );
       }
 
-      const proformaProps: Omit<ProformaCreateProps, "items"> & { items: IProformaItemCreateProps[] } = {
+      const proformaProps: Omit<IProformaCreateProps, "items"> & { items: IProformaItemCreateProps[] } = {
         companyId,
         status: defaultStatus!,
 

modules/customer-invoices/src/api/infrastructure/proformas/persistence/sequelize/mappers/domain/sequelize-proforma-item-domain.mapper.ts

@@ -16,12 +16,12 @@ import {
 import { Result } from "@repo/rdx-utils";
 
 import {
+  type IProformaCreateProps,
   type IProformaItemCreateProps,
   ItemAmount,
   ItemDescription,
   ItemQuantity,
   type Proforma,
-  type ProformaCreateProps,
   ProformaItem,
   ProformaItemTaxes,
   type ProformaItemTaxesProps,
@@ -58,7 +58,7 @@ export class SequelizeProformaItemDomainMapper extends SequelizeDomainMapper<
     const { errors, index, parent } = params as {
       index: number;
       errors: ValidationErrorDetail[];
-      parent: Partial<ProformaCreateProps>;
+      parent: Partial<IProformaCreateProps>;
     };
 
     const itemId = extractOrPushError(
@@ -139,7 +139,7 @@ export class SequelizeProformaItemDomainMapper extends SequelizeDomainMapper<
     const { errors, index } = params as {
       index: number;
       errors: ValidationErrorDetail[];
-      parent: Partial<ProformaCreateProps>;
+      parent: Partial<IProformaCreateProps>;
     };
 
     // 1) Valores escalares (atributos generales)

modules/customer-invoices/src/api/infrastructure/proformas/persistence/sequelize/mappers/domain/sequelize-proforma-recipient-domain.mapper.ts

@@ -14,7 +14,7 @@ import {
 } from "@repo/rdx-ddd";
 import { Maybe, Result } from "@repo/rdx-utils";
 
-import { InvoiceRecipient, type ProformaCreateProps } from "../../../../../../domain";
+import { type IProformaCreateProps, InvoiceRecipient } from "../../../../../../domain";
 import type { CustomerInvoiceModel } from "../../../../../common";
 
 export class SequelizeProformaRecipientDomainMapper {
@@ -28,7 +28,7 @@ export class SequelizeProformaRecipientDomainMapper {
 
     const { errors, parent } = params as {
       errors: ValidationErrorDetail[];
-      parent: Partial<ProformaCreateProps>;
+      parent: Partial<IProformaCreateProps>;
     };
 
     const _name = source.current_customer.name;

modules/customer-invoices/src/common/dto/request/proformas/update-proforma-by-id.request.dto.ts

@@ -4,14 +4,11 @@ import { z } from "zod/v4";
 export const UpdateProformaItemRequestSchema = z.object({
   id: z.uuid(),
   position: z.string(),
-  description: z.string().default(""),
+  description: z.string().optional(),
-  quantity: NumericStringSchema.default(""),
+  quantity: NumericStringSchema.optional(),
-  unit_amount: NumericStringSchema.default(""),
+  unit_amount: NumericStringSchema.optional(),
-  item_discount_percentage: PercentageSchema.default({
+  item_discount_percentage: PercentageSchema.optional(),
-    value: "0",
+  taxes: z.string().optional(),
-    scale: "2",
-  }),
-  taxes: z.string().default(""),
 });
 
 export const UpdateProformaByIdParamsRequestSchema = z.object({

modules/customer-invoices/src/web/proformas/update/controllers/use-proforma-update-page.controller.ts.bak

@@ -0,0 +1,142 @@
+import { formHasAnyDirty, pickFormDirtyValues } from "@erp/core/client";
+import { useHookForm } from "@erp/core/hooks";
+import { showErrorToast, showSuccessToast, showWarningToast } from "@repo/rdx-ui/helpers";
+import { useEffect, useId, useMemo } from "react";
+import { type FieldErrors, FormProvider } from "react-hook-form";
+
+import { useTranslation } from "../../../i18n";
+import type { Proforma } from "../../api";
+import { type ProformaFormData, ProformaFormSchema, defaultProformaFormData } from "../types";
+
+export interface UseProformaUpdateControllerOptions {
+  onUpdated?(updated: Proforma): void;
+  successToasts?: boolean; // mostrar o no toast automáticcamente
+
+  onError?(error: Error, patchData: ReturnType<typeof pickFormDirtyValues>): void;
+  errorToasts?: boolean; // mostrar o no toast automáticcamente
+}
+
+export const useProformaUpdateController = (
+  proformaId?: string,
+  options?: UseProformaUpdateControllerOptions
+) => {
+  const { t } = useTranslation();
+  const formId = useId(); // id único por instancia
+
+  // 1) Estado de carga del cliente (query)
+  const {
+    data: proformaData,
+    isLoading,
+    isError: isLoadError,
+    error: loadError,
+  } = useProformaGetQuery(proformaId, { enabled: Boolean(proformaId) });
+
+  // 2) Estado de creación (mutación)
+  const {
+    mutateAsync,
+    isPending: isUpdating,
+    isError: isUpdateError,
+    error: updateError,
+  } = useProformaUpdateMutation();
+
+  const initialValues = useMemo(() => proformaData ?? defaultProformaFormData, [proformaData]);
+
+  // 3) Form hook
+  const form = useHookForm<ProformaFormData>({
+    resolverSchema: ProformaFormSchema,
+    initialValues,
+    disabled: isLoading || isUpdating,
+  });
+
+  /** Reiniciar el form al recibir datos */
+  useEffect(() => {
+    // keepDirty = false -> deja el formulario sin cambios sin tener que esperar al siguiente render.
+    if (proformaData) form.reset(proformaData, { keepDirty: false });
+  }, [proformaData, form]);
+
+  /** Handlers */
+
+  const resetForm = () => form.reset(proformaData ?? defaultProformaFormData);
+
+  // Versión sincronizada
+  const submitHandler = form.handleSubmit(
+    async (formData) => {
+      if (!proformaId) {
+        showErrorToast(t("pages.update.error.title"), "Falta el ID de la proforma");
+        return;
+      }
+
+      const { dirtyFields } = form.formState;
+      if (!formHasAnyDirty(dirtyFields)) {
+        showWarningToast(t("pages.update.error.no_changes"), "No hay cambios para guardar");
+        return;
+      }
+
+      const patchData = pickFormDirtyValues(formData, dirtyFields);
+      const previousData = proformaData;
+
+      try {
+        // Enviamos cambios al servidor
+        const updated = await mutateAsync({ id: proformaId, data: patchData });
+
+        // Ha ido bien -> actualizamos form con datos reales
+        // keepDirty = false -> deja el formulario sin cambios sin tener que esperar al siguiente render.
+        form.reset(updated, { keepDirty: false });
+
+        if (options?.successToasts !== false) {
+          showSuccessToast(
+            t("pages.update.success.title", "Proforma modificada"),
+            t("pages.update.success.message", "Se ha modificado correctamente.")
+          );
+        }
+        options?.onUpdated?.(updated);
+      } catch (error: any) {
+        // Algo ha fallado -> revertimos cambios
+        form.reset(previousData ?? defaultProformaFormData);
+        if (options?.errorToasts !== false) {
+          showErrorToast(t("pages.update.error.title"), error.message);
+        }
+        options?.onError?.(error, patchData);
+      }
+    },
+    (errors: FieldErrors<ProformaFormData>) => {
+      const firstKey = Object.keys(errors)[0] as keyof ProformaFormData | undefined;
+      if (firstKey) document.querySelector<HTMLElement>(`[name="${String(firstKey)}"]`)?.focus();
+
+      showWarningToast(
+        t("forms.validation.title", "Revisa los campos"),
+        t("forms.validation.message", "Hay errores de validación en el formulario.")
+      );
+    }
+  );
+
+  // Evento onSubmit ya preparado para el <form>
+  const onSubmit = (event: React.FormEvent<HTMLFormElement>) => {
+    event.stopPropagation(); // <-- evita que el submit se propage por los padre en el árbol DOM
+    submitHandler(event);
+  };
+
+  return {
+    // form
+    form,
+    formId,
+
+    // handlers del form
+    onSubmit,
+    resetForm,
+
+    // carga de datos
+    proformaData,
+    isLoading,
+    isLoadError,
+    loadError,
+
+    // mutation
+    isUpdating,
+    isUpdateError,
+    updateError,
+
+    // Por comodidad
+    FormProvider,
+  };
+};

modules/customer-invoices/src/web/proformas/update/controllers/use-update-proforma-controller.ts

@@ -1,4 +1,3 @@
-import { formHasAnyDirty } from "@erp/core/client";
 import { useHookForm } from "@erp/core/hooks";
 import type { CustomerSelectionOption } from "@erp/customers";
 import { showErrorToast, showSuccessToast, showWarningToast } from "@repo/rdx-ui/helpers";
@@ -115,19 +114,12 @@ export const useUpdateProformaController = (
         return;
       }
 
-      console.log(form.formState.dirtyFields);
-
-      if (!formHasAnyDirty(form.formState.dirtyFields)) {
-        showWarningToast(
-          t("proformas.update.no_changes.title"),
-          t("proformas.update.no_changes.message")
-        );
-        return;
-      }
-
       const previousData = proformaData;
 
       const patchData = buildProformaUpdatePatch(formData, form.formState.dirtyFields);
+
+      console.log(patchData);
+
       const params = buildUpdateProformaByIdParams(proformaId, patchData);
 
       try {
@@ -140,7 +132,7 @@ export const useUpdateProformaController = (
           keepDirty: false,
         });
 
-        setSelectedCustomer(mapProformaToSelectedCustomer(updated));
+        setSelectedCustomer(mapProformaToSelectedCustomer(proformaData));
 
         if (options?.successToasts !== false) {
           showSuccessToast(
@@ -161,8 +153,6 @@ export const useUpdateProformaController = (
           { keepDirty: false }
         );
 
-        setSelectedCustomer(previousData ? mapProformaToSelectedCustomer(previousData) : null);
-
         if (options?.errorToasts !== false) {
           showErrorToast(t("proformas.update.error.title"), normalizedError.message);
         }

modules/customer-invoices/src/web/proformas/update/utils/build-proforma-items-update-patch.ts

@@ -0,0 +1,14 @@
+import type { ProformaItemUpdateForm, ProformaItemUpdatePatch } from "../entities";
+
+export const buildProformaItemsUpdatePatch = (
+  items: ProformaItemUpdateForm[]
+): ProformaItemUpdatePatch[] => {
+  return items.map((item, index) => ({
+    id: item.id,
+    position: index,
+    description: item.description.trim(),
+    quantity: item.quantity,
+    unitAmount: item.unitAmount,
+    itemDiscountPercentage: item.itemDiscountPercentage,
+  }));
+};

modules/customer-invoices/src/web/proformas/update/utils/build-proforma-update-patch.ts

@@ -3,6 +3,8 @@ import type { FieldNamesMarkedBoolean } from "react-hook-form";
 
 import type { ProformaUpdateForm, ProformaUpdatePatch } from "../entities";
 
+import { buildProformaItemsUpdatePatch } from "./build-proforma-items-update-patch";
+
 export const buildProformaUpdatePatch = (
   formData: ProformaUpdateForm,
   dirtyFields: FieldNamesMarkedBoolean<ProformaUpdateForm>
@@ -11,7 +13,10 @@ export const buildProformaUpdatePatch = (
     return {};
   }
 
-  return pickFormDirtyValues(formData, dirtyFields, {
+  const itemsPatch = buildProformaItemsUpdatePatch(formData.items);
-    replaceTopLevelArrayKeys: ["items"],
+
-  }) satisfies ProformaUpdatePatch;
+  return {
+    ...pickFormDirtyValues(formData, dirtyFields),
+    items: itemsPatch,
+  } as ProformaUpdatePatch;
 };

modules/customer-invoices/src/web/proformas/update/utils/build-update-proforma-by-id-params.ts

@@ -23,24 +23,12 @@ export const buildUpdateProformaByIdParams = (
 
     language_code: patch.languageCode,
     currency_code: patch.currencyCode,
-
-    items: patch.items?.map((item) => ({
-      id: item.id,
-      position: String(item.position),
-      description: item.description,
-      quantity: item.quantity === null ? undefined : String(item.quantity),
-      unit_amount: item.unitAmount === null ? undefined : String(item.unitAmount),
-      item_discount_percentage:
-        item.itemDiscountPercentage === null
-          ? undefined
-          : { value: String(item.itemDiscountPercentage), scale: "2" },
-    })),
   };
 
   return {
     id,
-    data: Object.fromEntries(
+    data: {
-      Object.entries(data).filter(([, value]) => value !== undefined)
+      ...Object.fromEntries(Object.entries(data).filter(([, value]) => value !== undefined)),
-    ) satisfies UpdateProformaByIdParams["data"],
+    },
   };
 };