apps/server/package.json

@@ -8,7 +8,8 @@
     "dev": "node --import=tsx --watch src/index.ts",
     "clean": "rimraf .turbo node_modules dist",
     "typecheck": "tsc --noEmit",
-    "lint": "biome lint --fix",
+    "lint": "biome check . && eslint .",
+    "lint:fix": "biome check --write . && eslint . --fix",
     "format": "biome format --write"
   },
   "devDependencies": {

apps/web/src/routes/app-routes.tsx

@@ -1,9 +1,7 @@
-import type { IModuleClient } from "@erp/core/client";
+import { IModuleClient } from "@erp/core/client";
 import { AppLayout } from "@repo/rdx-ui/components";
-import { Navigate, Route, createBrowserRouter, createRoutesFromElements } from "react-router-dom";
+import { createBrowserRouter, createRoutesFromElements, Navigate, Route } from "react-router-dom";
-
 import { ModuleRoutes } from "@/components/module-routes";
-
 import { ErrorPage, LoginForm } from "../pages";
 import { modules } from "../register-modules"; // Aquí ca
 
@@ -35,24 +33,24 @@ export const getAppRouter = () => {
 
   return createBrowserRouter(
     createRoutesFromElements(
-      <Route path="/">
+      <Route path='/'>
         {/* Auth Layout */}
-        <Route path="/auth">
+        <Route path='/auth'>
-          <Route element={<Navigate to="login" />} index />
+          <Route index element={<Navigate to='login' />} />
-          <Route element={<LoginForm />} path="login" />
+          <Route path='login' element={<LoginForm />} />
-          <Route element={<ModuleRoutes modules={grouped.auth} params={params} />} path="*" />
+          <Route path='*' element={<ModuleRoutes modules={grouped.auth} params={params} />} />
         </Route>
 
         {/* App Layout */}
         <Route element={<AppLayout />}>
           {/* Dynamic Module Routes */}
-          <Route element={<ModuleRoutes modules={grouped.app} params={params} />} path="*" />
+          <Route path='*' element={<ModuleRoutes modules={grouped.app} params={params} />} />
 
           {/* Main Layout */}
-          <Route element={<ErrorPage />} path="/dashboard" />
+          <Route path='/dashboard' element={<ErrorPage />} />
-          <Route element={<ErrorPage />} path="/settings" />
+          <Route path='/settings' element={<ErrorPage />} />
-          <Route element={<ErrorPage />} path="/catalog" />
+          <Route path='/catalog' element={<ErrorPage />} />
-          <Route element={<ErrorPage />} path="/quotes" />
+          <Route path='/quotes' element={<ErrorPage />} />
         </Route>
       </Route>
     )

modules/core/src/api/application/index.ts

@@ -1,5 +1,4 @@
 export * from "./documents";
-export * from "./mappers";
 export * from "./presenters";
 export * from "./renderers";
 export * from "./snapshot-builders";

modules/core/src/api/application/mappers/index.ts

@@ -1 +0,0 @@
-export * from "./mapper.interface";

modules/core/src/api/domain/index.ts

@@ -1,2 +1,3 @@
 export * from "./errors";
+export * from "./repositories";
 export * from "./value-objects";

modules/core/src/api/domain/repositories/index.ts

@@ -0,0 +1 @@
+export * from "./repository.interface";

modules/core/src/api/domain/repositories/repository.interface.ts

@@ -56,21 +56,23 @@ export type DomainMapperWithBulk<TPersistence, TDomain> = IDomainMapper<TPersist
   Partial<IBulkDomainMapper<TPersistence, TDomain>>;
 
 /**
- * 👓 Mapper de Read Model (Persistencia → Read Model/Proyección de Lectura)
+ *
- * - Responsabilidad: transformar registros de persistencia en read models para lectura (listados, resúmenes, informes).
+ * 👓 Mapper de Read Model (Persistencia ↔ DTO/Proyección de Lectura)
+ * - Responsabilidad: transformar registros de persistencia en DTOs para lectura (listados, resúmenes, informes).
  * - No intenta reconstruir agregados ni validar value objects de dominio.
  **/
-export interface IQueryMapperWithBulk<TPersistence, TReadModel> {
+export interface IQueryMapperWithBulk<TPersistence, TDTO> {
   /**
-   * Convierte un registro crudo en un read model de lectura.
+   * Convierte un registro crudo en un DTO de lectura.
    */
-  mapToReadModel(raw: TPersistence, params?: MapperParamsType): Result<TReadModel, Error>;
+  mapToDTO(raw: TPersistence, params?: MapperParamsType): Result<TDTO, Error>;
+
   /**
-   * Convierte múltiples registros crudos en una Collection de read models de lectura.
+   * Convierte múltiples registros crudos en una Collection de DTOs de lectura.
    */
-  mapToReadModelCollection(
+  mapToDTOCollection(
     raws: TPersistence[],
     totalCount: number,
     params?: MapperParamsType
-  ): Result<Collection<TReadModel>, Error>;
+  ): Result<Collection<TDTO>, Error>;
 }

modules/core/src/api/infrastructure/persistence/sequelize/mappers/sequelize-domain-mapper.ts

@@ -1,7 +1,7 @@
 import { Collection, Result, ResultCollection } from "@repo/rdx-utils";
 import type { Model } from "sequelize";
 
-import type { MapperParamsType } from "../../../../application";
+import type { MapperParamsType } from "../../../../domain";
 
 import type { ISequelizeDomainMapper } from "./sequelize-mapper.interface";
 

modules/core/src/api/infrastructure/persistence/sequelize/mappers/sequelize-mapper.interface.ts

@@ -1,4 +1,4 @@
-import type { DomainMapperWithBulk, IQueryMapperWithBulk } from "@erp/core/api/application";
+import type { DomainMapperWithBulk, IQueryMapperWithBulk } from "../../../../domain";
 
 export interface ISequelizeDomainMapper<TModel, TModelAttributes, TEntity>
   extends DomainMapperWithBulk<TModel | TModelAttributes, TEntity> {}

modules/core/src/api/infrastructure/persistence/sequelize/mappers/sequelize-read-model-mapper.ts

@@ -1,16 +1,16 @@
 import { Collection, Result } from "@repo/rdx-utils";
 import type { Model } from "sequelize";
 
-import type { MapperParamsType } from "../../../../application";
+import type { MapperParamsType } from "../../../../domain";
 
 import type { ISequelizeQueryMapper } from "./sequelize-mapper.interface";
 
 export abstract class SequelizeQueryMapper<TModel extends Model, TEntity>
   implements ISequelizeQueryMapper<TModel, TEntity>
 {
-  public abstract mapToReadModel(raw: TModel, params?: MapperParamsType): Result<TEntity, Error>;
+  public abstract mapToDTO(raw: TModel, params?: MapperParamsType): Result<TEntity, Error>;
 
-  public mapToReadModelCollection(
+  public mapToDTOCollection(
     raws: TModel[],
     totalCount: number,
     params?: MapperParamsType
@@ -23,7 +23,7 @@ export abstract class SequelizeQueryMapper<TModel extends Model, TEntity>
       }
 
       const items = _source.map((value, index) => {
-        const result = this.mapToReadModel(value as TModel, { index, ...params });
+        const result = this.mapToDTO(value as TModel, { index, ...params });
         if (result.isFailure) {
           throw result.error;
         }

modules/customer-invoices/src/api/application/issued-invoices/dtos/index.ts

@@ -0,0 +1 @@
+export * from "./issued-invoice-list.dto";

modules/customer-invoices/src/api/application/issued-invoices/dtos/issued-invoice-list.dto.ts

@@ -10,7 +10,7 @@ import type {
   VerifactuRecord,
 } from "../../../domain";
 
-export type IssuedInvoiceSummary = {
+export type IssuedInvoiceListDTO = {
   id: UniqueID;
   companyId: UniqueID;
 

modules/customer-invoices/src/api/application/issued-invoices/index.ts

@@ -1,6 +1,7 @@
+export * from "./application-models";
 export * from "./di";
+export * from "./dtos";
 export * from "./mappers";
-export * from "./models";
 export * from "./repositories";
 export * from "./services";
 export * from "./snapshot-builders";

modules/customer-invoices/src/api/application/issued-invoices/mappers/issued-invoice-list-mapper.interface.ts

@@ -1,8 +1,8 @@
 import type { MapperParamsType } from "@erp/core/api";
 import type { Result } from "@repo/rdx-utils";
 
-import type { IssuedInvoiceSummary } from "../models";
+import type { IssuedInvoiceListDTO } from "../dtos";
 
-export interface IIssuedInvoiceSummaryMapper {
+export interface IIssuedInvoiceListMapper {
-  mapToDTO(raw: unknown, params?: MapperParamsType): Result<IssuedInvoiceSummary, Error>;
+  mapToDTO(raw: unknown, params?: MapperParamsType): Result<IssuedInvoiceListDTO, Error>;
 }

modules/customer-invoices/src/api/application/issued-invoices/models/index.ts

@@ -1 +0,0 @@
-export * from "./issued-invoice-summary";

modules/customer-invoices/src/api/application/issued-invoices/repositories/issued-invoice-repository.interface.ts

@@ -3,7 +3,7 @@ import type { UniqueID } from "@repo/rdx-ddd";
 import type { Collection, Result } from "@repo/rdx-utils";
 
 import type { IssuedInvoice } from "../../../domain";
-import type { IssuedInvoiceSummary } from "../models";
+import type { IssuedInvoiceListDTO } from "../dtos";
 
 export interface IIssuedInvoiceRepository {
   create(invoice: IssuedInvoice, transaction?: unknown): Promise<Result<void, Error>>;
@@ -24,5 +24,5 @@ export interface IIssuedInvoiceRepository {
     companyId: UniqueID,
     criteria: Criteria,
     transaction: unknown
-  ): Promise<Result<Collection<IssuedInvoiceSummary>, Error>>;
+  ): Promise<Result<Collection<IssuedInvoiceListDTO>, Error>>;
 }

modules/customer-invoices/src/api/application/issued-invoices/services/issued-invoice-finder.ts

@@ -4,7 +4,7 @@ import type { Collection, Result } from "@repo/rdx-utils";
 import type { Transaction } from "sequelize";
 
 import type { IssuedInvoice } from "../../../domain";
-import type { IssuedInvoiceSummary } from "../models";
+import type { IssuedInvoiceListDTO } from "../dtos";
 import type { IIssuedInvoiceRepository } from "../repositories";
 
 export interface IIssuedInvoiceFinder {
@@ -24,7 +24,7 @@ export interface IIssuedInvoiceFinder {
     companyId: UniqueID,
     criteria: Criteria,
     transaction?: Transaction
-  ): Promise<Result<Collection<IssuedInvoiceSummary>, Error>>;
+  ): Promise<Result<Collection<IssuedInvoiceListDTO>, Error>>;
 }
 
 export class IssuedInvoiceFinder implements IIssuedInvoiceFinder {
@@ -50,7 +50,7 @@ export class IssuedInvoiceFinder implements IIssuedInvoiceFinder {
     companyId: UniqueID,
     criteria: Criteria,
     transaction?: Transaction
-  ): Promise<Result<Collection<IssuedInvoiceSummary>, Error>> {
+  ): Promise<Result<Collection<IssuedInvoiceListDTO>, Error>> {
     return this.repository.findByCriteriaInCompany(companyId, criteria, transaction);
   }
 }

modules/customer-invoices/src/api/application/issued-invoices/snapshot-builders/list/issued-invoice-list-item-snapshot-builder.ts

@@ -1,15 +1,15 @@
 import type { ISnapshotBuilder } from "@erp/core/api";
 import { maybeToEmptyString } from "@repo/rdx-ddd";
 
-import type { IssuedInvoiceSummary } from "../../models";
+import type { IssuedInvoiceListDTO } from "../../dtos";
 
 import type { IIssuedInvoiceListItemSnapshot } from "./issued-invoice-list-item-snapshot.interface";
 
 export interface IIssuedInvoiceListItemSnapshotBuilder
-  extends ISnapshotBuilder<IssuedInvoiceSummary, IIssuedInvoiceListItemSnapshot> {}
+  extends ISnapshotBuilder<IssuedInvoiceListDTO, IIssuedInvoiceListItemSnapshot> {}
 
 export class IssuedInvoiceListItemSnapshotBuilder implements IIssuedInvoiceListItemSnapshotBuilder {
-  toOutput(invoice: IssuedInvoiceSummary): IIssuedInvoiceListItemSnapshot {
+  toOutput(invoice: IssuedInvoiceListDTO): IIssuedInvoiceListItemSnapshot {
     const recipient = invoice.recipient.toObjectString();
 
     const verifactu = invoice.verifactu.match(

modules/customer-invoices/src/api/application/proformas/dtos/index.ts

@@ -0,0 +1 @@
+export * from "./proforma-list.dto";

modules/customer-invoices/src/api/application/proformas/index.ts

@@ -1,6 +1,7 @@
+export * from "./application-models";
 export * from "./di";
+export * from "./dtos";
 export * from "./mappers";
-export * from "./models";
 export * from "./repositories";
 export * from "./services";
 export * from "./snapshot-builders";

modules/customer-invoices/src/api/application/proformas/mappers/inputs/create-proforma-input.mapper.ts

@@ -41,20 +41,13 @@ import {
  *
  */
 
-/*export interface ICreateProformaInputMapper
+export interface ICreateProformaInputMapper
   extends IDTOInputToPropsMapper<
     CreateProformaRequestDTO,
     { id: UniqueID; props: Omit<IProformaProps, "items"> & { items: IProformaItemProps[] } }
-  > {}*/
+  > {}
 
-export interface ICreateProformaInputMapper {
+export class CreateProformaInputMapper implements ICreateProformaInputMapper {
-  map(
-    dto: CreateProformaRequestDTO,
-    params: { companyId: UniqueID }
-  ): Result<{ id: UniqueID; props: IProformaProps }>;
-}
-
-export class CreateProformaInputMapper /*implements ICreateProformaInputMapper*/ {
   private readonly taxCatalog: JsonTaxCatalogProvider;
 
   constructor(params: { taxCatalog: JsonTaxCatalogProvider }) {
@@ -145,14 +138,14 @@ export class CreateProformaInputMapper /*implements ICreateProformaInputMapper*/
 
       const globalDiscountPercentage = extractOrPushError(
         Percentage.create({
-          value: Number(dto.global_discount_percentage.value),
+          value: Number(dto.discount_percentage.value),
-          scale: Number(dto.global_discount_percentage.scale),
+          scale: Number(dto.discount_percentage.scale),
         }),
         "discount_percentage",
         errors
       );
 
-      const itemsProps = this.mapItemsProps(dto, {
+      const items = this.mapItems(dto, {
         languageCode: languageCode!,
         currencyCode: currencyCode!,
         globalDiscountPercentage: globalDiscountPercentage!,
@@ -165,7 +158,7 @@ export class CreateProformaInputMapper /*implements ICreateProformaInputMapper*/
         );
       }
 
-      const props: IProformaProps = {
+      const props: Omit<IProformaProps, "items"> & { items: IProformaItemProps[] } = {
         companyId,
         status: defaultStatus,
 
@@ -188,7 +181,7 @@ export class CreateProformaInputMapper /*implements ICreateProformaInputMapper*/
         paymentMethod: paymentMethod!,
         globalDiscountPercentage: globalDiscountPercentage!,
 
-        items: itemsProps, // ←  IProformaItemProps[]
+        items, // ←  IProformaItemProps[]
       };
 
       return Result.ok({
@@ -200,7 +193,7 @@ export class CreateProformaInputMapper /*implements ICreateProformaInputMapper*/
     }
   }
 
-  private mapItemsProps(
+  private mapItems(
     dto: CreateProformaRequestDTO,
     params: {
       languageCode: LanguageCode;
@@ -231,12 +224,12 @@ export class CreateProformaInputMapper /*implements ICreateProformaInputMapper*/
       );
 
       const discountPercentage = extractOrPushError(
-        maybeFromNullableResult(item.item_discount_percentage, (v) => DiscountPercentage.create(v)),
+        maybeFromNullableResult(item.discount_percentage, (v) => DiscountPercentage.create(v)),
         `items[${index}].discount_percentage`,
         params.errors
       );
 
-      const taxes = this.mapTaxesProps(item.taxes, {
+      const taxes = this.mapTaxes(item.taxes, {
         itemIndex: index,
         errors: params.errors,
       });
@@ -259,7 +252,7 @@ export class CreateProformaInputMapper /*implements ICreateProformaInputMapper*/
 
   /* Devuelve las propiedades de los impustos de una línea de detalle */
 
-  private mapTaxesProps(
+  private mapTaxes(
     taxesDTO: Pick<CreateProformaItemRequestDTO, "taxes">["taxes"],
     params: { itemIndex: number; errors: ValidationErrorDetail[] }
   ): ProformaItemTaxesProps {

modules/customer-invoices/src/api/application/proformas/mappers/inputs/update-proforma-input.mapper.ts

@@ -1,3 +1,4 @@
+import { InvoiceSerie, type ProformaPatchProps } from "@erp/customer-invoices/api/domain";
 import {
   CurrencyCode,
   DomainError,
@@ -13,7 +14,6 @@ import {
 import { Result, isNullishOrEmpty, toPatchField } from "@repo/rdx-utils";
 
 import type { UpdateProformaByIdRequestDTO } from "../../../../../common/dto";
-import type { ProformaPatchProps } from "../../../../domain";
 
 /**
  * UpdateProformaPropsMapper

modules/customer-invoices/src/api/application/proformas/mappers/proforma-list-mapper.interface.ts

@@ -1,7 +1,7 @@
 import type { MapperParamsType } from "@erp/core/api";
 import type { Result } from "@repo/rdx-utils";
 
-import type { ProformaListDTO } from "../models";
+import type { ProformaListDTO } from "../dtos";
 
 export interface IProformaListMapper {
   mapToDTO(raw: unknown, params?: MapperParamsType): Result<ProformaListDTO, Error>;

modules/customer-invoices/src/api/application/proformas/models/index.ts

@@ -1 +0,0 @@
-export * from "./proforma-resume";

modules/customer-invoices/src/api/application/proformas/repositories/proforma-repository.interface.ts

@@ -3,7 +3,7 @@ import type { UniqueID } from "@repo/rdx-ddd";
 import type { Collection, Result } from "@repo/rdx-utils";
 
 import type { InvoiceStatus, Proforma } from "../../../domain";
-import type { ProformaListDTO } from "../models";
+import type { ProformaListDTO } from "../dtos";
 
 export interface IProformaRepository {
   create(proforma: Proforma, transaction?: unknown): Promise<Result<void, Error>>;

modules/customer-invoices/src/api/application/proformas/services/proforma-creator.ts

@@ -2,31 +2,31 @@ import type { UniqueID } from "@repo/rdx-ddd";
 import { Result } from "@repo/rdx-utils";
 import type { Transaction } from "sequelize";
 
-import type { IProformaProps, Proforma } from "../../../domain";
+import type { ICustomerInvoiceRepository } from "../../../domain";
+import type { CustomerInvoice, CustomerInvoiceProps } from "../../../domain/aggregates";
 import type { IProformaFactory } from "../factories";
-import type { IProformaRepository } from "../repositories";
 
 import type { IProformaNumberGenerator } from "./proforma-number-generator.interface";
 
 export interface IProformaCreator {
-  create(params: {
+  create(
-    companyId: UniqueID;
+    companyId: UniqueID,
-    id: UniqueID;
+    id: UniqueID,
-    props: IProformaProps;
+    props: CustomerInvoiceProps,
-    transaction: Transaction;
+    transaction: Transaction
-  }): Promise<Result<Proforma, Error>>;
+  ): Promise<Result<CustomerInvoice, Error>>;
 }
 
 type ProformaCreatorDeps = {
   numberService: IProformaNumberGenerator;
   factory: IProformaFactory;
-  repository: IProformaRepository;
+  repository: ICustomerInvoiceRepository;
 };
 
 export class ProformaCreator implements IProformaCreator {
   private readonly numberService: IProformaNumberGenerator;
   private readonly factory: IProformaFactory;
-  private readonly repository: IProformaRepository;
+  private readonly repository: ICustomerInvoiceRepository;
 
   constructor(deps: ProformaCreatorDeps) {
     this.numberService = deps.numberService;
@@ -34,14 +34,12 @@ export class ProformaCreator implements IProformaCreator {
     this.repository = deps.repository;
   }
 
-  async create(params: {
+  async create(
-    companyId: UniqueID;
+    companyId: UniqueID,
-    id: UniqueID;
+    id: UniqueID,
-    props: IProformaProps;
+    props: CustomerInvoiceProps,
-    transaction: Transaction;
+    transaction: Transaction
-  }): Promise<Result<Proforma, Error>> {
+  ): Promise<Result<CustomerInvoice, Error>> {
-    const { companyId, id, props, transaction } = params;
-
     // 1. Obtener siguiente número
     const { series } = props;
     const numberResult = await this.numberService.getNextForCompany(companyId, series, transaction);

modules/customer-invoices/src/api/application/proformas/services/proforma-finder.ts

@@ -4,7 +4,7 @@ import type { Collection, Result } from "@repo/rdx-utils";
 import type { Transaction } from "sequelize";
 
 import type { Proforma } from "../../../domain";
-import type { ProformaListDTO } from "../models";
+import type { ProformaListDTO } from "../dtos";
 import type { IProformaRepository } from "../repositories";
 
 export interface IProformaFinder {

modules/customer-invoices/src/api/application/proformas/snapshot-builders/list/proforma-list-item-snapshot-builder.ts

@@ -1,7 +1,7 @@
 import type { ISnapshotBuilder } from "@erp/core/api";
 import { maybeToEmptyString } from "@repo/rdx-ddd";
 
-import type { ProformaListDTO } from "../../models";
+import type { ProformaListDTO } from "../../dtos";
 
 import type { IProformaListItemSnapshot } from "./proforma-list-item-snapshot.interface";
 

modules/customer-invoices/src/api/application/proformas/use-cases/create-proforma/create-proforma.use-case.ts

@@ -36,16 +36,16 @@ export class CreateProformaUseCase {
     const { dto, companyId } = params;
 
     // 1) Mapear DTO → props de dominio
-    const mappedPropsResult = this.dtoMapper.map(dto, { companyId });
+    const mappedResult = this.dtoMapper.map(dto, companyId);
-    if (mappedPropsResult.isFailure) {
+    if (mappedResult.isFailure) {
-      return Result.fail(mappedPropsResult.error);
+      return Result.fail(mappedResult.error);
     }
 
-    const { props, id } = mappedPropsResult.data;
+    const { props, id } = mappedResult.data;
 
     return this.transactionManager.complete(async (transaction) => {
       try {
-        const createResult = await this.creator.create({ companyId, id, props, transaction });
+        const createResult = await this.creator.create(companyId, id, props, transaction);
 
         if (createResult.isFailure) {
           return Result.fail(createResult.error);

modules/customer-invoices/src/api/domain/aggregates/customer-invoice.aggregate.ts

@@ -192,7 +192,6 @@ export class CustomerInvoice
   }
 
   // Method to get the complete list of line items
-
   public get items(): CustomerInvoiceItems {
     return this._items;
   }

modules/customer-invoices/src/api/domain/proformas/aggregates/proforma.aggregate.ts

@@ -23,9 +23,10 @@ import {
 import {
   type IProformaItemProps,
   type IProformaItems,
+  type IProformaItemsProps,
   ProformaItem,
   ProformaItems,
-} from "../entities";
+} from "../entities/proforma-items";
 import { ProformaItemMismatch } from "../errors";
 import { type IProformaTaxTotals, ProformaTaxesCalculator } from "../services";
 import { ProformaItemTaxes } from "../value-objects";
@@ -52,7 +53,7 @@ export interface IProformaProps {
 
   paymentMethod: Maybe<InvoicePaymentMethod>;
 
-  items: IProformaItemProps[];
+  items: IProformaItemsProps[];
   globalDiscountPercentage: DiscountPercentage;
 }
 
@@ -95,19 +96,21 @@ export interface IProforma {
 
   paymentMethod: Maybe<InvoicePaymentMethod>;
 
-  items: IProformaItems; // <- Colección
+  items: IProformaItems;
   taxes(): Collection<IProformaTaxTotals>;
   totals(): IProformaTotals;
 }
 
 export type ProformaPatchProps = Partial<Omit<IProformaProps, "companyId" | "items">> & {
-  //items?: ProformaItems;
+  items?: ProformaItems;
 };
 
 type CreateProformaProps = IProformaProps;
 type InternalProformaProps = Omit<IProformaProps, "items">;
 
 export class Proforma extends AggregateRoot<InternalProformaProps> implements IProforma {
+  private readonly _items: ProformaItems;
+
   // Creación funcional
   static create(props: CreateProformaProps, id?: UniqueID): Result<Proforma, Error> {
     const { items, ...internalProps } = props;
@@ -133,8 +136,6 @@ export class Proforma extends AggregateRoot<InternalProformaProps> implements IP
     return new Proforma(props, id);
   }
 
-  private readonly _items: ProformaItems;
-
   protected constructor(props: InternalProformaProps, id?: UniqueID) {
     super(props, id);
 
@@ -146,7 +147,36 @@ export class Proforma extends AggregateRoot<InternalProformaProps> implements IP
     });
   }
 
+  // Mutabilidad
+  public update(
+    partialProforma: Partial<Omit<IProformaProps, "companyId">>
+  ): Result<Proforma, Error> {
+    const updatedProps = {
+      ...this.props,
+      ...partialProforma,
+    } as IProformaProps;
+
+    return Proforma.create(updatedProps, this.id);
+  }
+
+  public issue(): Result<void, Error> {
+    if (!this.props.status.canTransitionTo("ISSUED")) {
+      return Result.fail(
+        new DomainValidationError(
+          "INVALID_STATE",
+          "status",
+          "Proforma cannot be issued from current state"
+        )
+      );
+    }
+
+    // Falta
+    //this.props.status = this.props.status.canTransitionTo("ISSUED");
+    return Result.ok();
+  }
+
   // Getters
+
   public get companyId(): UniqueID {
     return this.props.companyId;
   }
@@ -219,34 +249,6 @@ export class Proforma extends AggregateRoot<InternalProformaProps> implements IP
     return this.paymentMethod.isSome();
   }
 
-  // Mutabilidad
-  public update(
-    partialProforma: Partial<Omit<IProformaProps, "companyId">>
-  ): Result<Proforma, Error> {
-    const updatedProps = {
-      ...this.props,
-      ...partialProforma,
-    } as IProformaProps;
-
-    return Proforma.create(updatedProps, this.id);
-  }
-
-  public issue(): Result<void, Error> {
-    if (!this.props.status.canTransitionTo("ISSUED")) {
-      return Result.fail(
-        new DomainValidationError(
-          "INVALID_STATE",
-          "status",
-          "Proforma cannot be issued from current state"
-        )
-      );
-    }
-
-    // Falta
-    //this.props.status = this.props.status.canTransitionTo("ISSUED");
-    return Result.ok();
-  }
-
   // Cálculos
 
   /**

modules/customer-invoices/src/api/domain/proformas/entities/proforma-items/proforma-item.entity.ts

@@ -217,60 +217,6 @@ export class ProformaItem extends DomainEntity<InternalProformaItemProps> implem
     return this.taxes.retention.map((tax) => tax.percentage);
   }
 
-  /**
-   * @summary Cálculo centralizado de todos los valores intermedios.
-   * @returns Devuelve un objeto inmutable con todos los valores necesarios:
-   * - subtotal
-   * - itemDiscount
-   * - globalDiscount
-   * - totalDiscount
-   * - taxableAmount
-   * - ivaAmount
-   * - recAmount
-   * - retentionAmount
-   * - taxesAmount
-   * - totalAmount
-   *
-   */
-  public totals(): IProformaItemTotals {
-    const subtotalAmount = this._calculateSubtotalAmount();
-
-    const itemDiscountAmount = this._calculateItemDiscountAmount(subtotalAmount);
-    const globalDiscountAmount = this._calculateGlobalDiscountAmount(
-      subtotalAmount,
-      itemDiscountAmount
-    );
-    const totalDiscountAmount = this._calculateTotalDiscountAmount(
-      itemDiscountAmount,
-      globalDiscountAmount
-    );
-
-    const taxableAmount = subtotalAmount.subtract(totalDiscountAmount);
-
-    // Calcular impuestos individuales a partir de la base imponible
-    const { ivaAmount, recAmount, retentionAmount } = this.taxes.totals(taxableAmount);
-
-    const taxesAmount = ivaAmount.add(recAmount).add(retentionAmount);
-    const totalAmount = taxableAmount.add(taxesAmount);
-
-    return {
-      subtotalAmount,
-
-      itemDiscountAmount,
-      globalDiscountAmount,
-      totalDiscountAmount,
-
-      taxableAmount,
-
-      ivaAmount,
-      recAmount,
-      retentionAmount,
-
-      taxesAmount,
-      totalAmount,
-    };
-  }
-
   // Cálculos / Ayudantes
 
   /**
@@ -330,4 +276,58 @@ export class ProformaItem extends DomainEntity<InternalProformaItemProps> implem
   ) {
     return itemDiscountAmount.add(globalDiscountAmount);
   }
+
+  /**
+   * @summary Cálculo centralizado de todos los valores intermedios.
+   * @returns Devuelve un objeto inmutable con todos los valores necesarios:
+   * - subtotal
+   * - itemDiscount
+   * - globalDiscount
+   * - totalDiscount
+   * - taxableAmount
+   * - ivaAmount
+   * - recAmount
+   * - retentionAmount
+   * - taxesAmount
+   * - totalAmount
+   *
+   */
+  public totals(): IProformaItemTotals {
+    const subtotalAmount = this._calculateSubtotalAmount();
+
+    const itemDiscountAmount = this._calculateItemDiscountAmount(subtotalAmount);
+    const globalDiscountAmount = this._calculateGlobalDiscountAmount(
+      subtotalAmount,
+      itemDiscountAmount
+    );
+    const totalDiscountAmount = this._calculateTotalDiscountAmount(
+      itemDiscountAmount,
+      globalDiscountAmount
+    );
+
+    const taxableAmount = subtotalAmount.subtract(totalDiscountAmount);
+
+    // Calcular impuestos individuales a partir de la base imponible
+    const { ivaAmount, recAmount, retentionAmount } = this.taxes.totals(taxableAmount);
+
+    const taxesAmount = ivaAmount.add(recAmount).add(retentionAmount);
+    const totalAmount = taxableAmount.add(taxesAmount);
+
+    return {
+      subtotalAmount,
+
+      itemDiscountAmount,
+      globalDiscountAmount,
+      totalDiscountAmount,
+
+      taxableAmount,
+
+      ivaAmount,
+      recAmount,
+      retentionAmount,
+
+      taxesAmount,
+      totalAmount,
+    };
+  }
 }

modules/customer-invoices/src/api/domain/proformas/entities/proforma-items/proforma-items.collection.ts

@@ -6,14 +6,14 @@ import { ProformaItemMismatch } from "../../errors";
 import { ProformaItemsTotalsCalculator } from "../../services/proforma-items-totals-calculator";
 
 import type {
+  ICreateProformaItemProps,
   IProformaItem,
-  IProformaItemProps,
   IProformaItemTotals,
   ProformaItem,
 } from "./proforma-item.entity";
 
 export interface IProformaItemsProps {
-  items: IProformaItemProps[];
+  items?: ICreateProformaItemProps[];
 
   // Estos campos vienen de la cabecera,
   // pero se necesitan para cálculos y representaciones de la línea.
@@ -22,9 +22,6 @@ export interface IProformaItemsProps {
   currencyCode: CurrencyCode; // Para cálculos y formateos de moneda
 }
 
-type CreateProformaProps = IProformaItemsProps;
-type InternalProformaProps = Omit<IProformaItemsProps, "items">;
-
 export interface IProformaItems {
   // OJO, no extendemos de  Collection<IProformaItem> para no exponer
   // públicamente métodos para manipular la colección.
@@ -38,16 +35,12 @@ export interface IProformaItems {
 }
 
 export class ProformaItems extends Collection<ProformaItem> implements IProformaItems {
-  static create(props: CreateProformaProps): ProformaItems {
-    return new ProformaItems(props);
-  }
-
   public readonly languageCode!: LanguageCode;
   public readonly currencyCode!: CurrencyCode;
   public readonly globalDiscountPercentage!: DiscountPercentage;
 
-  protected constructor(props: InternalProformaProps) {
+  constructor(props: IProformaItemsProps) {
-    super([]);
+    super(props.items ?? []);
     this.languageCode = props.languageCode;
     this.currencyCode = props.currencyCode;
     this.globalDiscountPercentage = props.globalDiscountPercentage;
@@ -55,15 +48,8 @@ export class ProformaItems extends Collection<ProformaItem> implements IProforma
     this.ensureSameCurrencyAndLanguage(this.items);
   }
 
-  public add(item: ProformaItem): boolean {
+  public static create(props: IProformaItemsProps): ProformaItems {
-    const same =
+    return new ProformaItems(props);
-      this.languageCode.equals(item.languageCode) &&
-      this.currencyCode.equals(item.currencyCode) &&
-      this.globalDiscountPercentage.equals(item.globalDiscountPercentage);
-
-    if (!same) return false;
-
-    return super.add(item);
   }
 
   public valued(): IProformaItem[] {

modules/customer-invoices/src/api/index.ts

@@ -7,10 +7,9 @@ import {
   buildIssuedInvoicesDependencies,
   buildProformaServices,
   buildProformasDependencies,
-  issuedInvoicesRouter,
   models,
-  proformasRouter,
 } from "./infrastructure";
+import { issuedInvoicesRouter, proformasRouter } from "./infrastructure/express";
 
 export const customerInvoicesAPIModule: IModuleServer = {
   name: "customer-invoices",

modules/customer-invoices/src/api/infrastructure/express/index.ts

@@ -0,0 +1,2 @@
+export * from "./issued-invoices";
+export * from "./proformas";

modules/customer-invoices/src/api/infrastructure/express/issued-invoices/index.ts

@@ -0,0 +1,2 @@
+export * from "../../issued-invoices/express/controllers";
+export * from "../../issued-invoices/express/issued-invoices.routes";

modules/customer-invoices/src/api/infrastructure/express/issued-invoices/issued-invoices-api-error-mapper.ts

@@ -18,7 +18,7 @@ import {
   isInvalidProformaTransitionError,
   isProformaCannotBeConvertedToInvoiceError,
   isProformaCannotBeDeletedError,
-} from "../../../domain";
+} from "../../domain";
 
 // Crea una regla específica (prioridad alta para sobreescribir mensajes)
 const invoiceDuplicateRule: ErrorToApiRule = {

modules/customer-invoices/src/api/infrastructure/express/proformas/index.ts

@@ -0,0 +1,4 @@
+export * from "../../proformas/express/controllers";
+
+export * from "./proformas.routes";
+export * from "./proformas-api-error-mapper";

modules/customer-invoices/src/api/infrastructure/express/proformas/proformas-api-error-mapper.ts

@@ -1,3 +1,6 @@
+// Ejemplo: regla específica para Billing → InvoiceIdAlreadyExistsError
+// (si defines un error más ubicuo dentro del BC con su propia clase)
+
 import {
   ApiErrorMapper,
   ConflictApiError,
@@ -20,7 +23,7 @@ import {
 } from "../../../domain";
 
 // Crea una regla específica (prioridad alta para sobreescribir mensajes)
-const proformaDuplicateRule: ErrorToApiRule = {
+const invoiceDuplicateRule: ErrorToApiRule = {
   priority: 120,
   matches: (e) => isCustomerInvoiceIdAlreadyExistsError(e),
   build: (e) =>
@@ -78,8 +81,8 @@ const proformaCannotBeDeletedRule: ErrorToApiRule = {
 };
 
 // Cómo aplicarla: crea una nueva instancia del mapper con la regla extra
-export const proformasApiErrorMapper: ApiErrorMapper = ApiErrorMapper.default()
+export const customerInvoicesApiErrorMapper: ApiErrorMapper = ApiErrorMapper.default()
-  .register(proformaDuplicateRule)
+  .register(invoiceDuplicateRule)
   .register(proformaItemMismatchError)
   .register(entityIsNotProformaError)
   .register(proformaConversionRule)

modules/customer-invoices/src/api/infrastructure/express/proformas/proformas.routes.ts

@@ -3,21 +3,17 @@ import { type ModuleParams, type RequestWithAuth, validateRequest } from "@erp/c
 import { type NextFunction, type Request, type Response, Router } from "express";
 
 import {
-  GetProformaController,
-  ListProformasController,
-  type ProformasInternalDeps,
-  ReportProformaController,
-} from "..";
-
-import {
-  CreateProformaRequestSchema,
   GetProformaByIdRequestSchema,
   ListProformasRequestSchema,
   ReportProformaByIdParamsRequestSchema,
   ReportProformaByIdQueryRequestSchema,
 } from "../../../../common";
-
+import {
-import { CreateProformaController } from "./controllers/create-proforma.controller";
+  GetProformaController,
+  ListProformasController,
+  type ProformasInternalDeps,
+  ReportProformaController,
+} from "../../proformas";
 
 export const proformasRouter = (params: ModuleParams, deps: ProformasInternalDeps) => {
   const { app, config } = params;
@@ -77,19 +73,18 @@ export const proformasRouter = (params: ModuleParams, deps: ProformasInternalDep
     }
   );
 
-  router.post(
+  /*router.post(
     "/",
     //checkTabContext,
 
     validateRequest(CreateProformaRequestSchema, "body"),
     (req: Request, res: Response, next: NextFunction) => {
-      const useCase = deps.useCases.createProforma();
+      const useCase = deps.useCases.create_proforma();
       const controller = new CreateProformaController(useCase);
       return controller.execute(req, res, next);
     }
   );
 
-  /*
   router.put(
     "/:proforma_id",
     //checkTabContext,

modules/customer-invoices/src/api/infrastructure/issued-invoices/express/controllers/get-issued-invoice-by-id.controller.ts

@@ -7,12 +7,12 @@ import {
 
 import { GetIssuedInvoiceByIdResponseSchema } from "../../../../../common/index.ts";
 import type { GetIssuedInvoiceByIdUseCase } from "../../../../application/issued-invoices/index.ts";
-import { proformasApiErrorMapper } from "../../../proformas/express/proformas-api-error-mapper.ts";
+import { customerInvoicesApiErrorMapper } from "../../../express/proformas/proformas-api-error-mapper.ts";
 
 export class GetIssuedInvoiceByIdController extends ExpressController {
   public constructor(private readonly useCase: GetIssuedInvoiceByIdUseCase) {
     super();
-    this.errorMapper = proformasApiErrorMapper;
+    this.errorMapper = customerInvoicesApiErrorMapper;
 
     // 🔐 Reutiliza guards de auth/tenant y prohíbe 'companyId' en query
     this.registerGuards(

modules/customer-invoices/src/api/infrastructure/issued-invoices/express/controllers/list-issued-invoices.controller.ts

@@ -8,12 +8,12 @@ import { Criteria } from "@repo/rdx-criteria/server";
 
 import { ListIssuedInvoicesResponseSchema } from "../../../../../common/index.ts";
 import type { ListIssuedInvoicesUseCase } from "../../../../application/issued-invoices/index.ts";
-import { proformasApiErrorMapper } from "../../../proformas/express/proformas-api-error-mapper.ts";
+import { customerInvoicesApiErrorMapper } from "../../../express/proformas/proformas-api-error-mapper.ts";
 
 export class ListIssuedInvoicesController extends ExpressController {
   public constructor(private readonly useCase: ListIssuedInvoicesUseCase) {
     super();
-    this.errorMapper = proformasApiErrorMapper;
+    this.errorMapper = customerInvoicesApiErrorMapper;
 
     // 🔐 Reutiliza guards de auth/tenant y prohíbe 'companyId' en query
     this.registerGuards(

modules/customer-invoices/src/api/infrastructure/issued-invoices/express/controllers/report-issued-invoice.controller.ts

@@ -8,12 +8,12 @@ import {
 
 import type { ReportIssueInvoiceByIdQueryRequestDTO } from "../../../../../common";
 import type { ReportIssuedInvoiceUseCase } from "../../../../application/index.ts";
-import { proformasApiErrorMapper } from "../../../proformas/express/proformas-api-error-mapper.ts";
+import { customerInvoicesApiErrorMapper } from "../../../express/proformas/proformas-api-error-mapper.ts";
 
 export class ReportIssuedInvoiceController extends ExpressController {
   public constructor(private readonly useCase: ReportIssuedInvoiceUseCase) {
     super();
-    this.errorMapper = proformasApiErrorMapper;
+    this.errorMapper = customerInvoicesApiErrorMapper;
 
     // 🔐 Reutiliza guards de auth/tenant y prohíbe 'companyId' en query
     this.registerGuards(

modules/customer-invoices/src/api/infrastructure/issued-invoices/persistence/sequelize/mappers/list/sequelize-issued-invoice-recipient.list.mapper.ts

@@ -14,7 +14,7 @@ import {
 } from "@repo/rdx-ddd";
 import { Result } from "@repo/rdx-utils";
 
-import type { IssuedInvoiceSummary } from "../../../../../../application";
+import type { IssuedInvoiceListDTO } from "../../../../../../application";
 import { InvoiceRecipient } from "../../../../../../domain";
 import type { CustomerInvoiceModel } from "../../../../../common";
 
@@ -32,7 +32,7 @@ export class SequelizeIssuedInvoiceRecipientListMapper extends SequelizeQueryMap
 
     const { errors, attributes } = params as {
       errors: ValidationErrorDetail[];
-      attributes: Partial<IssuedInvoiceSummary>;
+      attributes: Partial<IssuedInvoiceListDTO>;
     };
 
     const { isProforma } = attributes;

modules/customer-invoices/src/api/infrastructure/issued-invoices/persistence/sequelize/mappers/list/sequelize-issued-invoice.list.mapper.ts

@@ -11,10 +11,7 @@ import {
 } from "@repo/rdx-ddd";
 import { Maybe, Result } from "@repo/rdx-utils";
 
-import type {
+import type { IIssuedInvoiceListMapper, IssuedInvoiceListDTO } from "../../../../../../application";
-  IIssuedInvoiceSummaryMapper,
-  IssuedInvoiceSummary,
-} from "../../../../../../application";
 import {
   InvoiceAmount,
   InvoiceNumber,
@@ -28,8 +25,8 @@ import { SequelizeIssuedInvoiceRecipientListMapper } from "./sequelize-issued-in
 import { SequelizeVerifactuRecordListMapper } from "./sequelize-verifactu-record.list.mapper";
 
 export class SequelizeIssuedInvoiceListMapper
-  extends SequelizeQueryMapper<CustomerInvoiceModel, IssuedInvoiceSummary>
+  extends SequelizeQueryMapper<CustomerInvoiceModel, IssuedInvoiceListDTO>
-  implements IIssuedInvoiceSummaryMapper
+  implements IIssuedInvoiceListMapper
 {
   private _recipientMapper: SequelizeIssuedInvoiceRecipientListMapper;
   private _verifactuMapper: SequelizeVerifactuRecordListMapper;
@@ -40,14 +37,14 @@ export class SequelizeIssuedInvoiceListMapper
     this._verifactuMapper = new SequelizeVerifactuRecordListMapper();
   }
 
-  public mapToReadModel(
+  public mapToDTO(
     raw: CustomerInvoiceModel,
     params?: MapperParamsType
-  ): Result<IssuedInvoiceSummary, Error> {
+  ): Result<IssuedInvoiceListDTO, Error> {
     const errors: ValidationErrorDetail[] = [];
 
     // 1) Valores escalares (atributos generales)
-    const attributes = this._mapAttributesToReadModel(raw, { errors, ...params });
+    const attributes = this.mapAttributesToDTO(raw, { errors, ...params });
 
     // 2) Recipient (snapshot en la factura o include)
     const recipientResult = this._recipientMapper.mapToDTO(raw, {
@@ -114,7 +111,7 @@ export class SequelizeIssuedInvoiceListMapper
     });
   }
 
-  private _mapAttributesToReadModel(raw: CustomerInvoiceModel, params?: MapperParamsType) {
+  private mapAttributesToDTO(raw: CustomerInvoiceModel, params?: MapperParamsType) {
     const { errors } = params as {
       errors: ValidationErrorDetail[];
     };

modules/customer-invoices/src/api/infrastructure/issued-invoices/persistence/sequelize/repositories/issued-invoice.repository.ts

@@ -4,7 +4,7 @@ import type { UniqueID } from "@repo/rdx-ddd";
 import { type Collection, Result } from "@repo/rdx-utils";
 import type { FindOptions, InferAttributes, OrderItem, Sequelize, Transaction } from "sequelize";
 
-import type { IIssuedInvoiceRepository, IssuedInvoiceSummary } from "../../../../../application";
+import type { IIssuedInvoiceRepository, IssuedInvoiceListDTO } from "../../../../../application";
 import type { IssuedInvoice } from "../../../../../domain";
 import {
   CustomerInvoiceItemModel,
@@ -212,7 +212,7 @@ export class IssuedInvoiceRepository
     criteria: Criteria,
     transaction: Transaction,
     options: FindOptions<InferAttributes<CustomerInvoiceModel>> = {}
-  ): Promise<Result<Collection<IssuedInvoiceSummary>, Error>> {
+  ): Promise<Result<Collection<IssuedInvoiceListDTO>, Error>> {
     const { CustomerModel } = this.database.models;
 
     try {
@@ -301,7 +301,7 @@ export class IssuedInvoiceRepository
         }),
       ]);
 
-      return this.listMapper.mapToReadModelCollection(rows, count);
+      return this.listMapper.mapToDTOCollection(rows, count);
     } catch (err: unknown) {
       return Result.fail(translateSequelizeError(err));
     }

modules/customer-invoices/src/api/infrastructure/proformas/di/proforma-persistence-mappers.di.ts

@@ -1,9 +1,4 @@
-import {
+import type { ICatalogs, IProformaDomainMapper, IProformaListMapper } from "../../../application";
-  CreateProformaInputMapper,
-  type ICatalogs,
-  type IProformaDomainMapper,
-  type IProformaListMapper,
-} from "../../../application";
 import { SequelizeProformaDomainMapper, SequelizeProformaListMapper } from "../persistence";
 
 export interface IProformaPersistenceMappers {

modules/customer-invoices/src/api/infrastructure/proformas/di/proforma-public-services.ts

@@ -2,23 +2,23 @@ import type { ProformasInternalDeps } from "./proformas.di";
 
 export type ProformasServicesDeps = {
   services: {
-    listProformas: (filters: unknown, context: unknown) => null;
+    listIssuedInvoices: (filters: unknown, context: unknown) => null;
-    getProformaById: (id: unknown, context: unknown) => null;
+    getIssuedInvoiceById: (id: unknown, context: unknown) => null;
-    generateProformaReport: (id: unknown, options: unknown, context: unknown) => null;
+    generateIssuedInvoiceReport: (id: unknown, options: unknown, context: unknown) => null;
   };
 };
 
 export function buildProformaServices(deps: ProformasInternalDeps): ProformasServicesDeps {
   return {
     services: {
-      listProformas: (filters, context) => null,
+      listIssuedInvoices: (filters, context) => null,
-      //internal.useCases.listProformas().execute(filters, context),
+      //internal.useCases.listIssuedInvoices().execute(filters, context),
 
-      getProformaById: (id, context) => null,
+      getIssuedInvoiceById: (id, context) => null,
-      //internal.useCases.getProformaById().execute(id, context),
+      //internal.useCases.getIssuedInvoiceById().execute(id, context),
 
-      generateProformaReport: (id, options, context) => null,
+      generateIssuedInvoiceReport: (id, options, context) => null,
-      //internal.useCases.reportProforma().execute(id, options, context),
+      //internal.useCases.reportIssuedInvoice().execute(id, options, context),
     },
   };
 }

modules/customer-invoices/src/api/infrastructure/proformas/express/controllers/create-proforma.controller.ts

@@ -7,12 +7,12 @@ import {
 
 import type { CreateProformaRequestDTO } from "../../../../../common/dto/index.ts";
 import type { CreateProformaUseCase } from "../../../../application/index.ts";
-import { proformasApiErrorMapper } from "../proformas-api-error-mapper.ts";
+import { customerInvoicesApiErrorMapper } from "../../../express/proformas/proformas-api-error-mapper.ts";
 
 export class CreateProformaController extends ExpressController {
   public constructor(private readonly useCase: CreateProformaUseCase) {
     super();
-    this.errorMapper = proformasApiErrorMapper;
+    this.errorMapper = customerInvoicesApiErrorMapper;
 
     // 🔐 Reutiliza guards de auth/tenant y prohíbe 'companyId' en query
     this.registerGuards(

modules/customer-invoices/src/api/infrastructure/proformas/express/controllers/delete-proforma.controller.ts

@@ -6,12 +6,12 @@ import {
 } from "@erp/core/api";
 
 import type { DeleteProformaUseCase } from "../../../../application/index.ts";
-import { proformasApiErrorMapper } from "../proformas-api-error-mapper.ts";
+import { customerInvoicesApiErrorMapper } from "../../../express/proformas/proformas-api-error-mapper.ts";
 
 export class DeleteProformaController extends ExpressController {
   public constructor(private readonly useCase: DeleteProformaUseCase) {
     super();
-    this.errorMapper = proformasApiErrorMapper;
+    this.errorMapper = customerInvoicesApiErrorMapper;
 
     // 🔐 Reutiliza guards de auth/tenant y prohíbe 'companyId' en query
     this.registerGuards(

modules/customer-invoices/src/api/infrastructure/proformas/express/controllers/get-proforma.controller.ts

@@ -5,13 +5,13 @@ import {
   requireCompanyContextGuard,
 } from "@erp/core/api";
 
-import type { GetProformaByIdUseCase } from "../../../../application";
+import type { GetProformaUseCase } from "../../../../application/index.ts";
-import { proformasApiErrorMapper } from "../proformas-api-error-mapper.ts";
+import { customerInvoicesApiErrorMapper } from "../../../express/proformas/proformas-api-error-mapper.ts";
 
 export class GetProformaController extends ExpressController {
-  public constructor(private readonly useCase: GetProformaByIdUseCase) {
+  public constructor(private readonly useCase: GetProformaUseCase) {
     super();
-    this.errorMapper = proformasApiErrorMapper;
+    this.errorMapper = customerInvoicesApiErrorMapper;
 
     // 🔐 Reutiliza guards de auth/tenant y prohíbe 'companyId' en query
     this.registerGuards(

modules/customer-invoices/src/api/infrastructure/proformas/express/controllers/issue-proforma.controller.ts

@@ -6,12 +6,12 @@ import {
 } from "@erp/core/api";
 
 import type { IssueProformaUseCase } from "../../../../application/index.ts";
-import { proformasApiErrorMapper } from "../proformas-api-error-mapper.ts";
+import { customerInvoicesApiErrorMapper } from "../../../express/proformas/proformas-api-error-mapper.ts";
 
 export class IssueProformaController extends ExpressController {
   public constructor(private readonly useCase: IssueProformaUseCase) {
     super();
-    this.errorMapper = proformasApiErrorMapper;
+    this.errorMapper = customerInvoicesApiErrorMapper;
 
     // 🔐 Reutiliza guards de auth/tenant y prohíbe 'companyId' en query
     this.registerGuards(

modules/customer-invoices/src/api/infrastructure/proformas/express/controllers/list-proformas.controller.ts

@@ -7,12 +7,12 @@ import {
 import { Criteria } from "@repo/rdx-criteria/server";
 
 import type { ListProformasUseCase } from "../../../../application/index.ts";
-import { proformasApiErrorMapper } from "../proformas-api-error-mapper.ts";
+import { customerInvoicesApiErrorMapper } from "../../../express/proformas/proformas-api-error-mapper.ts";
 
 export class ListProformasController extends ExpressController {
   public constructor(private readonly useCase: ListProformasUseCase) {
     super();
-    this.errorMapper = proformasApiErrorMapper;
+    this.errorMapper = customerInvoicesApiErrorMapper;
 
     // 🔐 Reutiliza guards de auth/tenant y prohíbe 'companyId' en query
     this.registerGuards(

modules/customer-invoices/src/api/infrastructure/proformas/express/controllers/report-proforma.controller.ts

@@ -8,12 +8,12 @@ import {
 
 import type { ReportProformaByIdQueryRequestDTO } from "../../../../../common";
 import type { ReportProformaUseCase } from "../../../../application/index.ts";
-import { proformasApiErrorMapper } from "../proformas-api-error-mapper.ts";
+import { customerInvoicesApiErrorMapper } from "../../../express/proformas/proformas-api-error-mapper.ts";
 
 export class ReportProformaController extends ExpressController {
   public constructor(private readonly useCase: ReportProformaUseCase) {
     super();
-    this.errorMapper = proformasApiErrorMapper;
+    this.errorMapper = customerInvoicesApiErrorMapper;
 
     // 🔐 Reutiliza guards de auth/tenant y prohíbe 'companyId' en query
     this.registerGuards(

modules/customer-invoices/src/api/infrastructure/proformas/express/controllers/update-proforma.controller.ts

@@ -7,12 +7,12 @@ import {
 
 import type { UpdateProformaByIdRequestDTO } from "../../../../../common/dto/index.ts";
 import type { UpdateProformaUseCase } from "../../../../application/index.ts";
-import { proformasApiErrorMapper } from "../proformas-api-error-mapper.ts";
+import { customerInvoicesApiErrorMapper } from "../../../express/proformas/proformas-api-error-mapper.ts";
 
 export class UpdateProformaController extends ExpressController {
   public constructor(private readonly useCase: UpdateProformaUseCase) {
     super();
-    this.errorMapper = proformasApiErrorMapper;
+    this.errorMapper = customerInvoicesApiErrorMapper;
 
     // 🔐 Reutiliza guards de auth/tenant y prohíbe 'companyId' en query
     this.registerGuards(

modules/customer-invoices/src/api/infrastructure/proformas/express/index.ts

@@ -1,2 +1 @@
 export * from "./controllers";
-export * from "./proformas.routes";

modules/customer-invoices/src/api/infrastructure/proformas/express/mappers/create-proforma-request-mapper.ts

@@ -134,8 +134,8 @@ export class CreateProformaRequestMapper {
 
       const globalDiscountPercentage = extractOrPushError(
         Percentage.create({
-          value: Number(dto.global_discount_percentage.value),
+          value: Number(dto.discount_percentage.value),
-          scale: Number(dto.global_discount_percentage.scale),
+          scale: Number(dto.discount_percentage.scale),
         }),
         "discount_percentage",
         this.errors
@@ -209,7 +209,7 @@ export class CreateProformaRequestMapper {
       );
 
       const discountPercentage = extractOrPushError(
-        maybeFromNullableResult(item.item_discount_percentage, (value) =>
+        maybeFromNullableResult(item.discount_percentage, (value) =>
           ItemDiscountPercentage.create(value)
         ),
         "discount_percentage",

modules/customer-invoices/src/api/infrastructure/proformas/persistence/sequelize/repositories/proforma.repository.ts

@@ -368,12 +368,10 @@ export class ProformaRepository
           ? [options.include]
           : [];
 
-      console.log(query.where);
-
       query.where = {
         ...query.where,
         ...(options.where ?? {}),
-        is_proforma: true,
+        is_proforma: false,
         company_id: companyId.toString(),
         deleted_at: null,
       };
@@ -424,7 +422,7 @@ export class ProformaRepository
         }),
       ]);
 
-      return this.listMapper.mapToReadModelCollection(rows, count);
+      return this.listMapper.mapToDTOCollection(rows, count);
     } catch (err: unknown) {
       return Result.fail(translateSequelizeError(err));
     }

modules/customer-invoices/src/common/dto/request/proformas/create-proforma.request.dto.ts

@@ -7,10 +7,7 @@ export const CreateProformaItemRequestSchema = z.object({
   description: z.string().default(""),
   quantity: NumericStringSchema.default(""),
   unit_amount: NumericStringSchema.default(""),
-  item_discount_percentage: PercentageSchema.default({
+  discount_percentage: NumericStringSchema.default(""),
-    value: "0",
-    scale: "2",
-  }),
   taxes: z.string().default(""),
 });
 export type CreateProformaItemRequestDTO = z.infer<typeof CreateProformaItemRequestSchema>;
@@ -32,7 +29,7 @@ export const CreateProformaRequestSchema = z.object({
   language_code: z.string().toLowerCase().default("es"),
   currency_code: z.string().toUpperCase().default("EUR"),
 
-  global_discount_percentage: PercentageSchema.default({
+  discount_percentage: PercentageSchema.default({
     value: "0",
     scale: "2",
   }),

modules/customer-invoices/src/web/customer-invoice-routes.tsx

@@ -2,32 +2,29 @@ import type { ModuleClientParams } from "@erp/core/client";
 import { lazy } from "react";
 import { Outlet, type RouteObject } from "react-router-dom";
 
-import { ProformaCreatePage } from "./proformas/create";
-
 const ProformaLayout = lazy(() =>
   import("./proformas/ui").then((m) => ({ default: m.ProformaLayout }))
 );
 
+const IssuedInvoicesLayout = lazy(() =>
+  import("./issued-invoices/ui").then((m) => ({ default: m.IssuedInvoicesLayout }))
+);
+
 const ProformasListPage = lazy(() =>
   import("./proformas/list").then((m) => ({ default: m.ProformaListPage }))
 );
 
-const ProformasCreatePage = lazy(() =>
-  import("./proformas/create").then((m) => ({ default: m.ProformaCreatePage }))
-);
-
-/*const InvoiceUpdatePage = lazy(() =>
-  import("./pages").then((m) => ({ default: m.InvoiceUpdatePage }))
-);*/
-
-const IssuedInvoicesLayout = lazy(() =>
-  import("./issued-invoices/ui").then((m) => ({ default: m.IssuedInvoicesLayout }))
-);
-
 const IssuedInvoiceListPage = lazy(() =>
   import("./issued-invoices/list").then((m) => ({ default: m.IssuedInvoiceListPage }))
 );
 
+/*const CustomerInvoiceAdd = lazy(() =>
+  import("./pages").then((m) => ({ default: m.CustomerInvoiceCreate }))
+);
+const InvoiceUpdatePage = lazy(() =>
+  import("./pages").then((m) => ({ default: m.InvoiceUpdatePage }))
+);*/
+
 export const CustomerInvoiceRoutes = (params: ModuleClientParams): RouteObject[] => {
   return [
     {
@@ -40,7 +37,7 @@ export const CustomerInvoiceRoutes = (params: ModuleClientParams): RouteObject[]
       children: [
         { path: "", index: true, element: <ProformasListPage /> }, // index
         { path: "list", element: <ProformasListPage /> },
-        { path: "create", element: <ProformaCreatePage /> },
+        //{ path: "create", element: <CustomerInvoiceAdd /> },
         //{ path: ":id/edit", element: <InvoiceUpdatePage /> },
       ],
     },

modules/customer-invoices/src/web/issued-invoices/list/adapters/issued-invoice-summary-dto.adapter.ts

@@ -1,4 +1,4 @@
-import { MoneyDTOHelper, formatCurrency } from "@erp/core";
+import { MoneyDTOHelper, PercentageDTOHelper, formatCurrency } from "@erp/core";
 
 import type {
   IssuedInvoiceSummaryData,
@@ -26,14 +26,14 @@ export const IssuedInvoiceSummaryDtoAdapter = {
               summaryDto.language_code
             ),
 
-            /*discount_percentage: PercentageDTOHelper.toNumber(summaryDto.discount_percentage),
+            discount_percentage: PercentageDTOHelper.toNumber(summaryDto.discount_percentage),
             discount_percentage_fmt: PercentageDTOHelper.toNumericString(
               summaryDto.discount_percentage
-            ),*/
+            ),
 
-            discount_amount: MoneyDTOHelper.toNumber(summaryDto.total_discount_amount),
+            discount_amount: MoneyDTOHelper.toNumber(summaryDto.discount_amount),
             discount_amount_fmt: formatCurrency(
-              MoneyDTOHelper.toNumber(summaryDto.total_discount_amount),
+              MoneyDTOHelper.toNumber(summaryDto.discount_amount),
               Number(summaryDto.total_amount.scale || 2),
               summaryDto.currency_code,
               summaryDto.language_code

modules/customer-invoices/src/web/proformas/create/index.ts

@@ -1 +0,0 @@
-export * from "./ui";

modules/customer-invoices/src/web/proformas/create/ui/index.ts

@@ -1 +0,0 @@
-export * from "./pages";

modules/customer-invoices/src/web/proformas/create/ui/pages/index.ts

@@ -1 +0,0 @@
-export * from "./proforma-create-page";

modules/customer-invoices/src/web/proformas/create/ui/pages/proforma-create-page.tsx

@@ -1,47 +0,0 @@
-import { PageHeader } from "@erp/core/components";
-import { AppContent, AppHeader } from "@repo/rdx-ui/components";
-import { Button } from "@repo/shadcn-ui/components";
-import { PlusIcon } from "lucide-react";
-import { useNavigate } from "react-router-dom";
-
-import { useTranslation } from "../../../../i18n";
-
-export const ProformaCreatePage = () => {
-  const { t } = useTranslation();
-  const navigate = useNavigate();
-
-  return (
-    <>
-      <AppHeader>
-        <PageHeader
-          description={t("pages.proformas.list.description")}
-          rightSlot={
-            <Button
-              aria-label={t("pages.proformas.create.title")}
-              onClick={() => navigate("/proformas/create")}
-            >
-              <PlusIcon aria-hidden className="mr-2 size-4" />
-              {t("pages.proformas.create.title")}
-            </Button>
-          }
-          title={t("pages.proformas.list.title")}
-        />
-      </AppHeader>
-
-      <AppContent>
-        <div className="flex items-center justify-between space-y-2">
-          <div>
-            <h2 className="text-2xl font-bold tracking-tight">{t("pages.create.title")}</h2>
-            <p className="text-muted-foreground">{t("pages.create.description")}</p>
-          </div>
-          <div className="flex items-center justify-end mb-4">
-            <Button className="cursor-pointer" onClick={() => navigate("/customer-invoices/list")}>
-              {t("pages.create.back_to_list")}
-            </Button>
-          </div>
-        </div>
-        <div className="flex flex-1 flex-col gap-4 p-4">hola</div>
-      </AppContent>
-    </>
-  );
-};

modules/customer-invoices/src/web/proformas/list/ui/pages/proforma-list-page.tsx

@@ -63,6 +63,7 @@ export const ProformaListPage = () => {
           rightSlot={
             <Button
               aria-label={t("pages.proformas.create.title")}
+              className="hidden"
               onClick={() => navigate("/proformas/create")}
             >
               <PlusIcon aria-hidden className="mr-2 size-4" />

modules/customers/src/api/application/customer-application.service.ts

@@ -3,7 +3,7 @@ import { Criteria } from "@repo/rdx-criteria/server";
 import { UniqueID } from "@repo/rdx-ddd";
 import { Collection, Result } from "@repo/rdx-utils";
 import { Transaction } from "sequelize";
-import { Customer, CustomerPatchProps, ICustomerProps, ICustomerRepository } from "../domain";
+import { Customer, CustomerPatchProps, CustomerProps, ICustomerRepository } from "../domain";
 import { CustomerListDTO } from "../infrastructure";
 
 export class CustomerApplicationService {
@@ -19,7 +19,7 @@ export class CustomerApplicationService {
    */
   buildCustomerInCompany(
     companyId: UniqueID,
-    props: Omit<ICustomerProps, "companyId">,
+    props: Omit<CustomerProps, "companyId">,
     customerId?: UniqueID
   ): Result<Customer, Error> {
     return Customer.create({ ...props, companyId }, customerId);

modules/customers/src/api/application/di/customer-finder.di.ts

@@ -1,6 +0,0 @@
-import type { IProformaRepository } from "../repositories";
-import { type IProformaFinder, ProformaFinder } from "../services";
-
-export function buildProformaFinder(repository: IProformaRepository): IProformaFinder {
-  return new ProformaFinder(repository);
-}

modules/customers/src/api/application/di/customer-snapshot-builders.di.ts

@@ -1,41 +0,0 @@
-// application/issued-invoices/di/snapshot-builders.di.ts
-
-import {
-  CustomerFullSnapshotBuilder,
-  CustomerItemReportSnapshotBuilder,
-  CustomerItemsFullSnapshotBuilder,
-  CustomerListItemSnapshotBuilder,
-  CustomerRecipientFullSnapshotBuilder,
-  CustomerReportSnapshotBuilder,
-  CustomerTaxReportSnapshotBuilder,
-  CustomerTaxesFullSnapshotBuilder,
-} from "../snapshot-builders";
-
-export function buildCustomerSnapshotBuilders() {
-  const itemsBuilder = new CustomerItemsFullSnapshotBuilder();
-
-  const taxesBuilder = new CustomerTaxesFullSnapshotBuilder();
-
-  const recipientBuilder = new CustomerRecipientFullSnapshotBuilder();
-
-  const fullSnapshotBuilder = new CustomerFullSnapshotBuilder(
-    itemsBuilder,
-    recipientBuilder,
-    taxesBuilder
-  );
-
-  const listSnapshotBuilder = new CustomerListItemSnapshotBuilder();
-
-  const itemsReportBuilder = new CustomerItemReportSnapshotBuilder();
-  const taxesReportBuilder = new CustomerTaxReportSnapshotBuilder();
-  const reportSnapshotBuilder = new CustomerReportSnapshotBuilder(
-    itemsReportBuilder,
-    taxesReportBuilder
-  );
-
-  return {
-    full: fullSnapshotBuilder,
-    list: listSnapshotBuilder,
-    report: reportSnapshotBuilder,
-  };
-}

modules/customers/src/api/application/di/customer-use-cases.di.ts

@@ -1,83 +0,0 @@
-import type { ITransactionManager } from "@erp/core/api";
-
-import type { ICreateCustomerInputMapper } from "../mappers";
-import type {
-  ICustomerCreator,
-  ICustomerFinder,
-  CustomerDocumentGeneratorService,
-} from "../services";
-import type {
-  ICustomerListItemSnapshotBuilder,
-  ICustomerReportSnapshotBuilder,
-} from "../snapshot-builders";
-import type { ICustomerFullSnapshotBuilder } from "../snapshot-builders/full";
-import { GetCustomerByIdUseCase, ListCustomersUseCase, ReportCustomerUseCase } from "../use-cases";
-import { CreateCustomerUseCase } from "../use-cases/create-customer";
-
-export function buildGetCustomerByIdUseCase(deps: {
-  finder: ICustomerFinder;
-  fullSnapshotBuilder: ICustomerFullSnapshotBuilder;
-  transactionManager: ITransactionManager;
-}) {
-  return new GetCustomerByIdUseCase(deps.finder, deps.fullSnapshotBuilder, deps.transactionManager);
-}
-
-export function buildListCustomersUseCase(deps: {
-  finder: ICustomerFinder;
-  itemSnapshotBuilder: ICustomerListItemSnapshotBuilder;
-  transactionManager: ITransactionManager;
-}) {
-  return new ListCustomersUseCase(deps.finder, deps.itemSnapshotBuilder, deps.transactionManager);
-}
-
-export function buildReportCustomerUseCase(deps: {
-  finder: ICustomerFinder;
-  fullSnapshotBuilder: ICustomerFullSnapshotBuilder;
-  reportSnapshotBuilder: ICustomerReportSnapshotBuilder;
-  documentService: CustomerDocumentGeneratorService;
-  transactionManager: ITransactionManager;
-}) {
-  return new ReportCustomerUseCase(
-    deps.finder,
-    deps.fullSnapshotBuilder,
-    deps.reportSnapshotBuilder,
-    deps.documentService,
-    deps.transactionManager
-  );
-}
-
-export function buildCreateCustomerUseCase(deps: {
-  creator: ICustomerCreator;
-  dtoMapper: ICreateCustomerInputMapper;
-  fullSnapshotBuilder: ICustomerFullSnapshotBuilder;
-  transactionManager: ITransactionManager;
-}) {
-  return new CreateCustomerUseCase({
-    dtoMapper: deps.dtoMapper,
-    creator: deps.creator,
-    fullSnapshotBuilder: deps.fullSnapshotBuilder,
-    transactionManager: deps.transactionManager,
-  });
-}
-
-/*export function buildUpdateCustomerUseCase(deps: {
-  finder: ICustomerFinder;
-  fullSnapshotBuilder: ICustomerFullSnapshotBuilder;
-}) {
-  return new UpdateCustomerUseCase(deps.finder, deps.fullSnapshotBuilder);
-}
-
-export function buildDeleteCustomerUseCase(deps: { finder: ICustomerFinder }) {
-  return new DeleteCustomerUseCase(deps.finder);
-}
-
-export function buildIssueCustomerUseCase(deps: { finder: ICustomerFinder }) {
-  return new IssueCustomerUseCase(deps.finder);
-}
-
-export function buildChangeStatusCustomerUseCase(deps: {
-  finder: ICustomerFinder;
-  transactionManager: ITransactionManager;
-}) {
-  return new ChangeStatusCustomerUseCase(deps.finder, deps.transactionManager);
-}*/

modules/customers/src/api/application/di/index.ts

@@ -1,5 +0,0 @@
-export * from "./customer-creator.di";
-export * from "./customer-finder.di";
-export * from "./customer-input-mappers.di";
-export * from "./customer-snapshot-builders.di";
-export * from "./customer-use-cases.di";

modules/customers/src/api/application/index.ts

@@ -1,7 +1,3 @@
-export * from "./di";
+//export * from "./customer-application.service";
-export * from "./mappers";
+//export * from "./presenters";
-export * from "./models";
-export * from "./repositories";
-export * from "./services";
-export * from "./snapshot-builders";
 export * from "./use-cases";

modules/customers/src/api/application/mappers/customer-domain-mapper.interface.ts

@@ -1,7 +0,0 @@
-import type { DomainMapperWithBulk } from "@erp/core/api";
-
-import type { Customer } from "../../domain";
-import type { CustomerCreationAttributes, CustomerModel } from "../../infrastructure";
-
-export interface ICustomerDomainMapper
-  extends DomainMapperWithBulk<CustomerModel | CustomerCreationAttributes, Customer> {}

modules/customers/src/api/application/mappers/customer-summary-mapper.interface.ts

@@ -1,7 +0,0 @@
-import type { IQueryMapperWithBulk } from "@erp/core/api";
-
-import type { CustomerModel } from "../../infrastructure";
-import type { CustomerSummary } from "../models";
-
-export interface ICustomerSummaryMapper
-  extends IQueryMapperWithBulk<CustomerModel, CustomerSummary> {}

modules/customers/src/api/application/mappers/index.ts

@@ -1,2 +0,0 @@
-export * from "./customer-domain-mapper.interface";
-export * from "./customer-summary-mapper.interface";

modules/customers/src/api/application/models/customer-summary.ts

@@ -1,41 +0,0 @@
-import type {
-  CurrencyCode,
-  EmailAddress,
-  LanguageCode,
-  Name,
-  PhoneNumber,
-  PostalAddress,
-  TINNumber,
-  URLAddress,
-  UniqueID,
-} from "@repo/rdx-ddd";
-import type { Maybe } from "@repo/rdx-utils";
-
-import type { CustomerStatus } from "../../domain";
-
-export type CustomerSummary = {
-  id: UniqueID;
-  companyId: UniqueID;
-  status: CustomerStatus;
-  reference: Maybe<Name>;
-
-  isCompany: boolean;
-  name: Name;
-  tradeName: Maybe<Name>;
-  tin: Maybe<TINNumber>;
-
-  address: PostalAddress;
-
-  emailPrimary: Maybe<EmailAddress>;
-  emailSecondary: Maybe<EmailAddress>;
-  phonePrimary: Maybe<PhoneNumber>;
-  phoneSecondary: Maybe<PhoneNumber>;
-  mobilePrimary: Maybe<PhoneNumber>;
-  mobileSecondary: Maybe<PhoneNumber>;
-
-  fax: Maybe<PhoneNumber>;
-  website: Maybe<URLAddress>;
-
-  languageCode: LanguageCode;
-  currencyCode: CurrencyCode;
-};

modules/customers/src/api/application/models/index.ts

@@ -1 +0,0 @@
-export * from "./customer-summary";

modules/customers/src/api/application/services/customer-finder.ts

@@ -1,56 +0,0 @@
-import type { Criteria } from "@repo/rdx-criteria/server";
-import type { UniqueID } from "@repo/rdx-ddd";
-import type { Collection, Result } from "@repo/rdx-utils";
-import type { Transaction } from "sequelize";
-
-import type { Customer } from "../../domain";
-import type { CustomerListDTO } from "../dtos";
-import type { ICustomerRepository } from "../repositories";
-
-export interface ICustomerFinder {
-  findCustomerById(
-    companyId: UniqueID,
-    invoiceId: UniqueID,
-    transaction?: Transaction
-  ): Promise<Result<Customer, Error>>;
-
-  customerExists(
-    companyId: UniqueID,
-    invoiceId: UniqueID,
-    transaction?: Transaction
-  ): Promise<Result<boolean, Error>>;
-
-  findCustomersByCriteria(
-    companyId: UniqueID,
-    criteria: Criteria,
-    transaction?: Transaction
-  ): Promise<Result<Collection<CustomerListDTO>, Error>>;
-}
-
-export class CustomerFinder implements ICustomerFinder {
-  constructor(private readonly repository: ICustomerRepository) {}
-
-  async findCustomerById(
-    companyId: UniqueID,
-    customerId: UniqueID,
-    transaction?: Transaction
-  ): Promise<Result<Customer, Error>> {
-    return this.repository.getByIdInCompany(companyId, customerId, transaction);
-  }
-
-  async customerExists(
-    companyId: UniqueID,
-    customerId: UniqueID,
-    transaction?: Transaction
-  ): Promise<Result<boolean, Error>> {
-    return this.repository.existsByIdInCompany(companyId, customerId, transaction);
-  }
-
-  async findCustomersByCriteria(
-    companyId: UniqueID,
-    criteria: Criteria,
-    transaction?: Transaction
-  ): Promise<Result<Collection<CustomerListDTO>, Error>> {
-    return this.repository.findByCriteriaInCompany(companyId, criteria, transaction);
-  }
-}

modules/customers/src/api/application/services/index.ts

@@ -1 +0,0 @@
-export * from "./customer-finder";

modules/customers/src/api/application/snapshot-builders/index.ts

@@ -1,3 +0,0 @@
-//export * from "./full";
-export * from "./list";
-//export * from "./report";

modules/customers/src/api/application/snapshot-builders/list/customer-list-item-snapshot-builder.ts

@@ -1,14 +0,0 @@
-import type { ISnapshotBuilder } from "@erp/core/api";
-
-import type { CustomerListDTO } from "../../dtos";
-
-import type { ICustomerListItemSnapshot } from "./customer-list-item-snapshot.interface";
-
-export interface ICustomerListItemSnapshotBuilder
-  extends ISnapshotBuilder<CustomerListDTO, ICustomerListItemSnapshot> {}
-
-export class CustomerListItemSnapshotBuilder implements ICustomerListItemSnapshotBuilder {
-  toOutput(customer: CustomerListDTO): ICustomerListItemSnapshot {
-    return {};
-  }
-}

modules/customers/src/api/application/snapshot-builders/list/customer-list-item-snapshot.interface.ts

@@ -1 +0,0 @@
-export type ICustomerListItemSnapshot = {};

modules/customers/src/api/application/snapshot-builders/list/index.ts

@@ -1,2 +0,0 @@
-export * from "./customer-list-item-snapshot.interface";
-export * from "./customer-list-item-snapshot-builder";

modules/customers/src/api/application/use-cases/create/map-dto-to-create-customer-props.ts

@@ -24,7 +24,7 @@ import {
 import { Collection, Result, isNullishOrEmpty } from "@repo/rdx-utils";
 
 import type { CreateCustomerRequestDTO } from "../../../../common";
-import { type ICustomerProps, CustomerStatus } from "../../../domain";
+import { type CustomerProps, CustomerStatus } from "../../../domain";
 
 /**
  * Convierte el DTO a las props validadas (CustomerProps).
@@ -197,7 +197,7 @@ export function mapDTOToCreateCustomerProps(dto: CreateCustomerRequestDTO) {
       errors
     );
 
-    const customerProps: Omit<ICustomerProps, "companyId"> = {
+    const customerProps: Omit<CustomerProps, "companyId"> = {
       status: status!,
       reference: reference!,
 

modules/customers/src/api/application/use-cases/list-customers.use-case.ts

@@ -1,12 +1,11 @@
-import type { ITransactionManager } from "@erp/core/api";
+import { IPresenterRegistry, ITransactionManager } from "@erp/core/api";
-import type { Criteria } from "@repo/rdx-criteria/server";
+import { Criteria } from "@repo/rdx-criteria/server";
-import type { UniqueID } from "@repo/rdx-ddd";
+import { UniqueID } from "@repo/rdx-ddd";
 import { Result } from "@repo/rdx-utils";
-import type { Transaction } from "sequelize";
+import { Transaction } from "sequelize";
-
+import { ListCustomersResponseDTO } from "../../../common/dto";
-import type { ListCustomersResponseDTO } from "../../../common/dto";
+import { CustomerApplicationService } from "../../application";
-import type { ICustomerFinder } from "../services";
+import { ListCustomersPresenter } from "../presenters";
-import type { ICustomerListItemSnapshotBuilder } from "../snapshot-builders/list";
 
 type ListCustomersUseCaseInput = {
   companyId: UniqueID;
@@ -15,42 +14,39 @@ type ListCustomersUseCaseInput = {
 
 export class ListCustomersUseCase {
   constructor(
-    private readonly finder: ICustomerFinder,
+    private readonly service: CustomerApplicationService,
-    private readonly listItemSnapshotBuilder: ICustomerListItemSnapshotBuilder,
+    private readonly transactionManager: ITransactionManager,
-    private readonly transactionManager: ITransactionManager
+    private readonly presenterRegistry: IPresenterRegistry
   ) {}
 
   public execute(
     params: ListCustomersUseCaseInput
   ): Promise<Result<ListCustomersResponseDTO, Error>> {
     const { criteria, companyId } = params;
+    const presenter = this.presenterRegistry.getPresenter({
+      resource: "customer",
+      projection: "LIST",
+    }) as ListCustomersPresenter;
 
     return this.transactionManager.complete(async (transaction: Transaction) => {
       try {
-        const result = await this.finder.findCustomersByCriteria(companyId, criteria, transaction);
+        const result = await this.service.findCustomerByCriteriaInCompany(
+          companyId,
+          criteria,
+          transaction
+        );
 
         if (result.isFailure) {
           return Result.fail(result.error);
         }
 
         const customers = result.data;
-        const totalCustomers = customers.total();
+        const dto = presenter.toOutput({
+          customers,
+          criteria,
+        });
 
-        const items = customers.map((item) => this.listItemSnapshotBuilder.toOutput(item));
+        return Result.ok(dto);
-
-        const snapshot = {
-          page: criteria.pageNumber,
-          per_page: criteria.pageSize,
-          total_pages: Math.ceil(totalCustomers / criteria.pageSize),
-          total_items: totalCustomers,
-          items: items,
-          metadata: {
-            entity: "customers",
-            criteria: criteria.toJSON(),
-          },
-        };
-
-        return Result.ok(snapshot);
       } catch (error: unknown) {
         return Result.fail(error as Error);
       }

modules/customers/src/api/domain/aggregates/customer.ts

@@ -17,7 +17,7 @@ import { type Collection, type Maybe, Result } from "@repo/rdx-utils";
 
 import type { CustomerStatus } from "../value-objects";
 
-export interface ICustomerProps {
+export interface CustomerProps {
   companyId: UniqueID;
   status: CustomerStatus;
   reference: Maybe<Name>;
@@ -49,7 +49,7 @@ export interface ICustomerProps {
   currencyCode: CurrencyCode;
 }
 
-export type CustomerPatchProps = Partial<Omit<ICustomerProps, "companyId" | "address">> & {
+export type CustomerPatchProps = Partial<Omit<CustomerProps, "companyId" | "address">> & {
   address?: PostalAddressPatchProps;
 };
 
@@ -90,12 +90,8 @@ export interface ICustomer {
   readonly currencyCode: CurrencyCode;
 }
 
-type CreateCustomerProps = ICustomerProps;
+export class Customer extends AggregateRoot<CustomerProps> implements ICustomer {
-type InternalCustomerProps = ICustomerProps;
+  static create(props: CustomerProps, id?: UniqueID): Result<Customer, Error> {
-
-export class Customer extends AggregateRoot<InternalCustomerProps> implements ICustomer {
-
-  static create(props: CreateCustomerProps, id?: UniqueID): Result<Customer, Error> {
     const contact = new Customer(props, id);
 
     // Reglas de negocio / validaciones
@@ -109,18 +105,12 @@ export class Customer extends AggregateRoot<InternalCustomerProps> implements IC
     return Result.ok(contact);
   }
 
-  // Rehidratación desde persistencia
-  static rehydrate(props: InternalCustomerProps, id: UniqueID): Customer {
-    return new Customer(props, id);
-  }
-
-
   public update(partialCustomer: CustomerPatchProps): Result<Customer, Error> {
     const { address: partialAddress, ...rest } = partialCustomer;
     const updatedProps = {
       ...this.props,
       ...rest,
-    } as ICustomerProps;
+    } as CustomerProps;
 
     if (partialAddress) {
       const updatedAddressOrError = this.address.update(partialAddress);
@@ -134,8 +124,6 @@ export class Customer extends AggregateRoot<InternalCustomerProps> implements IC
     return Customer.create(updatedProps, this.id);
   }
 
-  // Getters
-
   public get isIndividual(): boolean {
     return !this.props.isCompany;
   }

modules/customers/src/api/domain/aggregates/index.ts

@@ -1 +1 @@
-export * from "./customer.aggregate";
+export * from "./customer";

modules/customers/src/api/domain/index.ts

@@ -1,3 +1,4 @@
 export * from "./aggregates";
 export * from "./errors";
+export * from "./repositories";
 export * from "./value-objects";

modules/customers/src/api/domain/repositories/customer-repository.interface.ts

@@ -1,9 +1,8 @@
-import type { Criteria } from "@repo/rdx-criteria/server";
+import { Criteria } from "@repo/rdx-criteria/server";
-import type { UniqueID } from "@repo/rdx-ddd";
+import { UniqueID } from "@repo/rdx-ddd";
-import type { Collection, Result } from "@repo/rdx-utils";
+import { Collection, Result } from "@repo/rdx-utils";
-
+import { CustomerListDTO } from "../../infrastructure/mappers";
-import type { Customer } from "../../domain/aggregates";
+import { Customer } from "../aggregates";
-import type { CustomerSummary } from "../models";
 
 /**
  * Interfaz del repositorio para el agregado `Customer`.
@@ -57,7 +56,7 @@ export interface ICustomerRepository {
     companyId: UniqueID,
     criteria: Criteria,
     transaction: unknown
-  ): Promise<Result<Collection<CustomerSummary>, Error>>;
+  ): Promise<Result<Collection<CustomerListDTO>, Error>>;
 
   /**
    * Elimina un Customer por su ID, dentro de una empresa.

modules/customers/src/api/domain/value-objects/index.ts

@@ -1,4 +1,4 @@
-export * from "./customer-address-type.vo";
+export * from "./customer-address-type";
-export * from "./customer-number.vo";
+export * from "./customer-number";
-export * from "./customer-serie.vo";
+export * from "./customer-serie";
-export * from "./customer-status.vo";
+export * from "./customer-status";

modules/customers/src/api/index.ts

@@ -1,6 +1,6 @@
 import type { IModuleServer } from "@erp/core/api";
 
-import { customersRouter, models } from "./infrastructure";
+import { models } from "./infrastructure";
 
 export * from "./infrastructure/sequelize";
 
@@ -19,29 +19,25 @@ export const customersAPIModule: IModuleServer = {
   async setup(params) {
     const { env: ENV, app, database, baseRoutePath: API_BASE_PATH, logger } = params;
 
-    
-    // 1) Dominio interno
-    //const customerInternalDeps = buildCustomerDependencies(params);
-
-    // 2) Servicios públicos (Application Services)
-    //const customerServices = buildCustomerServices(customerInternalDeps);
-
     logger.info("🚀 Customers module dependencies registered", {
       label: this.name,
     });
-
     return {
       // Modelos Sequelize del módulo
       models,
 
       // Servicios expuestos a otros módulos
       services: {
-        //customers: customerServices,
+        customers: {
+          /*...*/
+        },
       },
 
       // Implementación privada del módulo
       internal: {
-        //customers: customerInternalDeps,
+        customers: {
+          /*...*/
+        },
       },
     };
   },
@@ -60,7 +56,7 @@ export const customersAPIModule: IModuleServer = {
     const customersInternalDeps = getInternal("customers", "customers");
 
     // Registro de rutas HTTP
-    customersRouter(params, customersInternalDeps);
+    //customersRouter(params, customersInternalDeps);
 
     logger.info("🚀 Customers module started", {
       label: this.name,

modules/customers/src/api/infrastructure/dependencies.ts

@@ -14,7 +14,7 @@ import {
 import { CustomerApplicationService } from "../application/customer-application.service";
 import { CustomerFullPresenter, ListCustomersPresenter } from "../application/presenters";
 
-import { CustomerDomainMapper, CustomerSummaryMapper } from "./mappers";
+import { CustomerDomainMapper, CustomerListMapper } from "./mappers";
 import { CustomerRepository } from "./sequelize";
 
 export type CustomerDeps = {
@@ -40,7 +40,7 @@ export function buildCustomerDependencies(params: ModuleParams): CustomerDeps {
   const mapperRegistry = new InMemoryMapperRegistry();
   mapperRegistry
     .registerDomainMapper({ resource: "customer" }, new CustomerDomainMapper())
-    .registerQueryMapper({ resource: "customer", query: "LIST" }, new CustomerSummaryMapper());
+    .registerQueryMapper({ resource: "customer", query: "LIST" }, new CustomerListMapper());
 
   // Repository & Services
   const repo = new CustomerRepository({ mapperRegistry, database });